Coinbase: Update exchange implementation (#1480)

* Slight enhance of Coinbase tests

Continual enhance of Coinbase tests

The revamp continues

Oh jeez the Orderbook part's unfinished don't look

Coinbase revamp, Orderbook still unfinished

* Coinbase revamp; CreateReport is still WIP

* More coinbase improvements; onto sandbox testing

* Coinbase revamp continues

* Coinbase revamp continues

* Coinbasepro revamp is ceaseless

* Coinbase revamp, starting on advanced trade API

* Coinbase Advanced Trade Starts in Ernest

V3 done, onto V2

Coinbase revamp nears completion

Coinbase revamp nears completion

Test commit should fail

Coinbase revamp nears completion

* Coinbase revamp stage wrapper

* Coinbase wrapper coherence continues

* Coinbase wrapper continues writhing

* Coinbase wrapper & codebase cleanup

* Coinbase updates & wrap progress

* More Coinbase wrapper progress

* Wrapper is wrapped, kinda

* Test & type checking

* Coinbase REST revamp finished

* Post-merge fix

* WS revamp begins

* WS Main Revamp Done?

* CB websocket tidying up

* Coinbase WS wrapperupperer

* Coinbase revamp done??

* Linter progress

* Continued lint cleanup

* Further lint cleanup

* Increased lint coverage

* Does this fix all sloppy reassigns & shadowing?

* Undoing retry policy change

* Documentation regeneration

* Coinbase code improvements

* Providing warning about known issue

* Updating an error to new format

* Making gocritic happy

* Review adherence

* Endpoints moved to V3 & nil pointer fixes

* Removing seemingly superfluous constant

* Glorious improvements

* Removing unused error

* Partial public endpoint addition

* Slight improvements

* Wrapper improvements; still a few errors left in other packages

* A lil Coinbase progress

* Json cleaning

* Lint appeasement

* Config repair

* Config fix (real)

* Little fix

* New public endpoint incorporation

* Additional fixes

* Improvements & Appeasements

* LineSaver

* Additional fixes

* Another fix

* Fixing picked nits

* Quick fixies

* Lil fixes

* Subscriptions: Add List.Enabled

* CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* Comment fix

* Subsequent fixes

* Issues hopefully fixed

* Lint fix

* Glorious fixes

* Json formatting

* ShazNits

* (L/N)i(n/)t

* Adding a test

* Tiny test improvement

* Template patch testing

* Fixes

* Further shaznits

* Lint nit

* JWT move and other fixes

* Small nits

* Shaznit, singular

* Post-merge fix

* Post-merge fixes

* Typo fix

* Some glorious nits

* Required changes

* Stop going

* Alias attempt

* Alias fix & test cleanup

* Test fix

* GetDepositAddress logic improvement

* Status update: Fixed

* Lint fix

* Happy birthday to PR 1480

* Cleanups

* Necessary nit corrections

* Fixing sillybug

* As per request

* Programming progress

* Order fixes

* Further fixies

* Test fix

* Pre-merge fixes

* More shaznits

* Context

* Sonic error handling

* Import fix

* Better Sonic error handling

* Perfect Sonic error handling?

* F purge

* Coinbase improvements

* API Update Conformity

* Coinbase continuation

* Coinbase order improvements

* Coinbase order improvements

* CreateOrderConfig improvements

* Managing API updates

* Coinbase API update progression

* jwt rename

* Comment link fix

* Coinbase v2 cleanup

* Post-merge fixes

* Review fixes

* GK's suggestions

* Linter fix

* Minor gbjk fixes

* Nit fixes

* Merge fix

* Lint fixes

* Coinbase rename stage 1

* Coinbase rename stage 2

* Coinbase rename stage 3

* Coinbase rename stage 4

* Coinbase rename final fix

* Coinbase: PoC on converting to request structs

* Applying requested changes

* Many review fixes, handled

* Thrashed by nits

* More minor modifications

* The last nit!?

---------

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

exchanges/futures/futures_test.go

@@ -88,7 +88,7 @@ func TestTrackNewOrder(t *testing.T) {
 	assert.ErrorIs(t, err, common.ErrNilPointer)
 
 	err = c.TrackNewOrder(&order.Detail{}, false)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	od := &order.Detail{
 		Exchange:  exch,
@@ -206,7 +206,7 @@ func TestSetupMultiPositionTracker(t *testing.T) {
 
 	setup := &MultiPositionTrackerSetup{}
 	_, err = SetupMultiPositionTracker(setup)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	setup.Exchange = testExchange
 	_, err = SetupMultiPositionTracker(setup)
@@ -249,7 +249,7 @@ func TestMultiPositionTrackerTrackNewOrder(t *testing.T) {
 		ExchangePNLCalculation: &FakePNL{},
 	}
 	_, err := SetupMultiPositionTracker(setup)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	setup.Exchange = testExchange
 	resp, err := SetupMultiPositionTracker(setup)
@@ -264,7 +264,7 @@ func TestMultiPositionTrackerTrackNewOrder(t *testing.T) {
 		OrderID:   "1",
 		Amount:    1,
 	})
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	err = resp.TrackNewOrder(&order.Detail{
 		Date:      tt,
@@ -417,7 +417,7 @@ func TestPositionControllerTestTrackNewOrder(t *testing.T) {
 		Side:      order.Long,
 		OrderID:   "lol",
 	})
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	err = pc.TrackNewOrder(&order.Detail{
 		Exchange:  testExchange,
@@ -524,7 +524,7 @@ func TestGetPositionsForExchange(t *testing.T) {
 	p := currency.NewBTCUSDT()
 
 	_, err := c.GetPositionsForExchange("", asset.Futures, p)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	pos, err := c.GetPositionsForExchange(testExchange, asset.Futures, p)
 	assert.ErrorIs(t, err, ErrPositionNotFound)
@@ -581,7 +581,7 @@ func TestClearPositionsForExchange(t *testing.T) {
 	c := &PositionController{}
 	p := currency.NewBTCUSDT()
 	err := c.ClearPositionsForExchange("", asset.Futures, p)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	err = c.ClearPositionsForExchange(testExchange, asset.Futures, p)
 	assert.ErrorIs(t, err, ErrPositionNotFound)
@@ -656,7 +656,7 @@ func TestSetupPositionTracker(t *testing.T) {
 	p, err = SetupPositionTracker(&PositionTrackerSetup{
 		Asset: asset.Spot,
 	})
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	if p != nil {
 		t.Error("expected nil")
@@ -758,7 +758,7 @@ func TestUpdateOpenPositionUnrealisedPNL(t *testing.T) {
 	pc := SetupPositionController()
 
 	_, err := pc.UpdateOpenPositionUnrealisedPNL("", asset.Futures, currency.NewBTCUSDT(), 2, time.Now())
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = pc.UpdateOpenPositionUnrealisedPNL("hi", asset.Futures, currency.NewBTCUSDT(), 2, time.Now())
 	assert.ErrorIs(t, err, ErrPositionNotFound)
@@ -803,7 +803,7 @@ func TestSetCollateralCurrency(t *testing.T) {
 	t.Parallel()
 	pc := SetupPositionController()
 	err := pc.SetCollateralCurrency("", asset.Spot, currency.EMPTYPAIR, currency.Code{})
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	err = pc.SetCollateralCurrency("hi", asset.Spot, currency.EMPTYPAIR, currency.Code{})
 	assert.ErrorIs(t, err, ErrNotFuturesAsset)
@@ -905,7 +905,7 @@ func TestMPTLiquidate(t *testing.T) {
 		Asset: item,
 	}
 	_, err = SetupPositionTracker(setup)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	setup.Exchange = "exch"
 	_, err = SetupPositionTracker(setup)
@@ -995,7 +995,7 @@ func TestGetOpenPosition(t *testing.T) {
 	tn := time.Now()
 
 	_, err := pc.GetOpenPosition("", asset.Futures, cp)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = pc.GetOpenPosition(testExchange, asset.Futures, cp)
 	assert.ErrorIs(t, err, ErrPositionNotFound)
@@ -1053,7 +1053,7 @@ func TestPCTrackFundingDetails(t *testing.T) {
 		Pair:  p,
 	}
 	err = pc.TrackFundingDetails(rates)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	rates.Exchange = testExchange
 	err = pc.TrackFundingDetails(rates)
@@ -1104,7 +1104,7 @@ func TestMPTTrackFundingDetails(t *testing.T) {
 		Pair:  cp,
 	}
 	err = mpt.TrackFundingDetails(rates)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	mpt.exchange = testExchange
 	rates = &fundingrate.HistoricalRates{
@@ -1206,7 +1206,7 @@ func TestPTTrackFundingDetails(t *testing.T) {
 
 	rates.Exchange = ""
 	err = p.TrackFundingDetails(rates)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	p = nil
 	err = p.TrackFundingDetails(rates)
@@ -1278,7 +1278,7 @@ func TestGetCurrencyForRealisedPNL(t *testing.T) {
 func TestCheckTrackerPrerequisitesLowerExchange(t *testing.T) {
 	t.Parallel()
 	_, err := checkTrackerPrerequisitesLowerExchange("", asset.Spot, currency.EMPTYPAIR)
-	assert.ErrorIs(t, err, errExchangeNameEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	upperExch := "IM UPPERCASE"
 	_, err = checkTrackerPrerequisitesLowerExchange(upperExch, asset.Spot, currency.EMPTYPAIR)