d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coinbase: Update exchange implementation (#1480)

Browse Source 
* Slight enhance of Coinbase tests

Continual enhance of Coinbase tests

The revamp continues

Oh jeez the Orderbook part's unfinished don't look

Coinbase revamp, Orderbook still unfinished

* Coinbase revamp; CreateReport is still WIP

* More coinbase improvements; onto sandbox testing

* Coinbase revamp continues

* Coinbase revamp continues

* Coinbasepro revamp is ceaseless

* Coinbase revamp, starting on advanced trade API

* Coinbase Advanced Trade Starts in Ernest

V3 done, onto V2

Coinbase revamp nears completion

Coinbase revamp nears completion

Test commit should fail

Coinbase revamp nears completion

* Coinbase revamp stage wrapper

* Coinbase wrapper coherence continues

* Coinbase wrapper continues writhing

* Coinbase wrapper & codebase cleanup

* Coinbase updates & wrap progress

* More Coinbase wrapper progress

* Wrapper is wrapped, kinda

* Test & type checking

* Coinbase REST revamp finished

* Post-merge fix

* WS revamp begins

* WS Main Revamp Done?

* CB websocket tidying up

* Coinbase WS wrapperupperer

* Coinbase revamp done??

* Linter progress

* Continued lint cleanup

* Further lint cleanup

* Increased lint coverage

* Does this fix all sloppy reassigns & shadowing?

* Undoing retry policy change

* Documentation regeneration

* Coinbase code improvements

* Providing warning about known issue

* Updating an error to new format

* Making gocritic happy

* Review adherence

* Endpoints moved to V3 & nil pointer fixes

* Removing seemingly superfluous constant

* Glorious improvements

* Removing unused error

* Partial public endpoint addition

* Slight improvements

* Wrapper improvements; still a few errors left in other packages

* A lil Coinbase progress

* Json cleaning

* Lint appeasement

* Config repair

* Config fix (real)

* Little fix

* New public endpoint incorporation

* Additional fixes

* Improvements & Appeasements

* LineSaver

* Additional fixes

* Another fix

* Fixing picked nits

* Quick fixies

* Lil fixes

* Subscriptions: Add List.Enabled

* CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* Comment fix

* Subsequent fixes

* Issues hopefully fixed

* Lint fix

* Glorious fixes

* Json formatting

* ShazNits

* (L/N)i(n/)t

* Adding a test

* Tiny test improvement

* Template patch testing

* Fixes

* Further shaznits

* Lint nit

* JWT move and other fixes

* Small nits

* Shaznit, singular

* Post-merge fix

* Post-merge fixes

* Typo fix

* Some glorious nits

* Required changes

* Stop going

* Alias attempt

* Alias fix & test cleanup

* Test fix

* GetDepositAddress logic improvement

* Status update: Fixed

* Lint fix

* Happy birthday to PR 1480

* Cleanups

* Necessary nit corrections

* Fixing sillybug

* As per request

* Programming progress

* Order fixes

* Further fixies

* Test fix

* Pre-merge fixes

* More shaznits

* Context

* Sonic error handling

* Import fix

* Better Sonic error handling

* Perfect Sonic error handling?

* F purge

* Coinbase improvements

* API Update Conformity

* Coinbase continuation

* Coinbase order improvements

* Coinbase order improvements

* CreateOrderConfig improvements

* Managing API updates

* Coinbase API update progression

* jwt rename

* Comment link fix

* Coinbase v2 cleanup

* Post-merge fixes

* Review fixes

* GK's suggestions

* Linter fix

* Minor gbjk fixes

* Nit fixes

* Merge fix

* Lint fixes

* Coinbase rename stage 1

* Coinbase rename stage 2

* Coinbase rename stage 3

* Coinbase rename stage 4

* Coinbase rename final fix

* Coinbase: PoC on converting to request structs

* Applying requested changes

* Many review fixes, handled

* Thrashed by nits

* More minor modifications

* The last nit!?

---------

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
This commit is contained in:
cranktakular
2025-09-16 13:37:00 +10:00
committed by GitHub
parent d957ddae62
commit fd9aaf00a2
78 changed files with 8850 additions and 3937 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
engine/rpcserver_test.go
View File

@@ -769,7 +769,7 @@ func TestGetHistoricCandles(t *testing.T) {
End: defaultEnd.Format(common.SimpleTimeFormatWithTimezone),
AssetType: asset.Spot.String(),
})
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
_, err = s.GetHistoricCandles(t.Context(), &gctrpc.GetHistoricCandlesRequest{
Exchange: "bruh",
@@ -1319,7 +1319,7 @@ func TestGetOrders(t *testing.T) {
AssetType: asset.Spot.String(),
Pair: p,
})
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
_, err = s.GetOrders(t.Context(), &gctrpc.GetOrdersRequest{
Exchange: "bruh",
@@ -1838,7 +1838,7 @@ func TestGetManagedOrders(t *testing.T) {
AssetType: asset.Spot.String(),
Pair: p,
})
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
_, err = s.GetManagedOrders(t.Context(), &gctrpc.GetOrdersRequest{
Exchange: "bruh",
@@ -2336,7 +2336,7 @@ func TestGetTechnicalAnalysis(t *testing.T) {
}
_, err = s.GetTechnicalAnalysis(t.Context(), &gctrpc.GetTechnicalAnalysisRequest{})
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
_, err = s.GetTechnicalAnalysis(t.Context(), &gctrpc.GetTechnicalAnalysisRequest{
Exchange: fakeExchangeName,
@@ -2572,7 +2572,7 @@ func TestGetMarginRatesHistory(t *testing.T) {
request := &gctrpc.GetMarginRatesHistoryRequest{}
_, err = s.GetMarginRatesHistory(t.Context(), request)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
request.Exchange = fakeExchangeName
_, err = s.GetMarginRatesHistory(t.Context(), request)
@@ -2725,7 +2725,7 @@ func TestGetFundingRates(t *testing.T) {
IncludePayments: false,
}
_, err = s.GetFundingRates(t.Context(), request)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
request.Exchange = exch.GetName()
_, err = s.GetFundingRates(t.Context(), request)
@@ -2818,7 +2818,7 @@ func TestGetLatestFundingRate(t *testing.T) {
IncludePredicted: false,
}
_, err = s.GetLatestFundingRate(t.Context(), request)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
request.Exchange = exch.GetName()
_, err = s.GetLatestFundingRate(t.Context(), request)
@@ -2910,7 +2910,7 @@ func TestGetManagedPosition(t *testing.T) {
Quote: "USD",
}
_, err = s.GetManagedPosition(t.Context(), request)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
request.Exchange = fakeExchangeName
_, err = s.GetManagedPosition(t.Context(), request)
@@ -3096,7 +3096,7 @@ func TestGetOrderbookMovement(t *testing.T) {
req := &gctrpc.GetOrderbookMovementRequest{}
_, err = s.GetOrderbookMovement(t.Context(), req)
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = "fake"
_, err = s.GetOrderbookMovement(t.Context(), req)
@@ -3189,7 +3189,7 @@ func TestGetOrderbookAmountByNominal(t *testing.T) {
req := &gctrpc.GetOrderbookAmountByNominalRequest{}
_, err = s.GetOrderbookAmountByNominal(t.Context(), req)
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = "fake"
_, err = s.GetOrderbookAmountByNominal(t.Context(), req)
@@ -3275,7 +3275,7 @@ func TestGetOrderbookAmountByImpact(t *testing.T) {
req := &gctrpc.GetOrderbookAmountByImpactRequest{}
_, err = s.GetOrderbookAmountByImpact(t.Context(), req)
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = "fake"
_, err = s.GetOrderbookAmountByImpact(t.Context(), req)
@@ -3611,7 +3611,7 @@ func TestSetCollateralMode(t *testing.T) {
req := &gctrpc.SetCollateralModeRequest{}
_, err = s.SetCollateralMode(t.Context(), req)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = fakeExchangeName
req.Asset = asset.USDTMarginedFutures.String()
@@ -3648,7 +3648,7 @@ func TestGetCollateralMode(t *testing.T) {
req := &gctrpc.GetCollateralModeRequest{}
_, err = s.GetCollateralMode(t.Context(), req)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = fakeExchangeName
req.Asset = asset.USDTMarginedFutures.String()
@@ -3683,7 +3683,7 @@ func TestGetOpenInterest(t *testing.T) {
req := &gctrpc.GetOpenInterestRequest{}
_, err = s.GetOpenInterest(t.Context(), req)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = fakeExchangeName
_, err = s.GetOpenInterest(t.Context(), req)
@@ -3869,7 +3869,7 @@ func TestGetCurrencyTradeURL(t *testing.T) {
req := &gctrpc.GetCurrencyTradeURLRequest{}
_, err = s.GetCurrencyTradeURL(t.Context(), req)
assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
req.Exchange = fakeExchangeName
_, err = s.GetCurrencyTradeURL(t.Context(), req)