Coinbase: Update exchange implementation (#1480)

* Slight enhance of Coinbase tests

Continual enhance of Coinbase tests

The revamp continues

Oh jeez the Orderbook part's unfinished don't look

Coinbase revamp, Orderbook still unfinished

* Coinbase revamp; CreateReport is still WIP

* More coinbase improvements; onto sandbox testing

* Coinbase revamp continues

* Coinbase revamp continues

* Coinbasepro revamp is ceaseless

* Coinbase revamp, starting on advanced trade API

* Coinbase Advanced Trade Starts in Ernest

V3 done, onto V2

Coinbase revamp nears completion

Coinbase revamp nears completion

Test commit should fail

Coinbase revamp nears completion

* Coinbase revamp stage wrapper

* Coinbase wrapper coherence continues

* Coinbase wrapper continues writhing

* Coinbase wrapper & codebase cleanup

* Coinbase updates & wrap progress

* More Coinbase wrapper progress

* Wrapper is wrapped, kinda

* Test & type checking

* Coinbase REST revamp finished

* Post-merge fix

* WS revamp begins

* WS Main Revamp Done?

* CB websocket tidying up

* Coinbase WS wrapperupperer

* Coinbase revamp done??

* Linter progress

* Continued lint cleanup

* Further lint cleanup

* Increased lint coverage

* Does this fix all sloppy reassigns & shadowing?

* Undoing retry policy change

* Documentation regeneration

* Coinbase code improvements

* Providing warning about known issue

* Updating an error to new format

* Making gocritic happy

* Review adherence

* Endpoints moved to V3 & nil pointer fixes

* Removing seemingly superfluous constant

* Glorious improvements

* Removing unused error

* Partial public endpoint addition

* Slight improvements

* Wrapper improvements; still a few errors left in other packages

* A lil Coinbase progress

* Json cleaning

* Lint appeasement

* Config repair

* Config fix (real)

* Little fix

* New public endpoint incorporation

* Additional fixes

* Improvements & Appeasements

* LineSaver

* Additional fixes

* Another fix

* Fixing picked nits

* Quick fixies

* Lil fixes

* Subscriptions: Add List.Enabled

* CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* fixup! CoinbasePro: Add subscription templating

* Comment fix

* Subsequent fixes

* Issues hopefully fixed

* Lint fix

* Glorious fixes

* Json formatting

* ShazNits

* (L/N)i(n/)t

* Adding a test

* Tiny test improvement

* Template patch testing

* Fixes

* Further shaznits

* Lint nit

* JWT move and other fixes

* Small nits

* Shaznit, singular

* Post-merge fix

* Post-merge fixes

* Typo fix

* Some glorious nits

* Required changes

* Stop going

* Alias attempt

* Alias fix & test cleanup

* Test fix

* GetDepositAddress logic improvement

* Status update: Fixed

* Lint fix

* Happy birthday to PR 1480

* Cleanups

* Necessary nit corrections

* Fixing sillybug

* As per request

* Programming progress

* Order fixes

* Further fixies

* Test fix

* Pre-merge fixes

* More shaznits

* Context

* Sonic error handling

* Import fix

* Better Sonic error handling

* Perfect Sonic error handling?

* F purge

* Coinbase improvements

* API Update Conformity

* Coinbase continuation

* Coinbase order improvements

* Coinbase order improvements

* CreateOrderConfig improvements

* Managing API updates

* Coinbase API update progression

* jwt rename

* Comment link fix

* Coinbase v2 cleanup

* Post-merge fixes

* Review fixes

* GK's suggestions

* Linter fix

* Minor gbjk fixes

* Nit fixes

* Merge fix

* Lint fixes

* Coinbase rename stage 1

* Coinbase rename stage 2

* Coinbase rename stage 3

* Coinbase rename stage 4

* Coinbase rename final fix

* Coinbase: PoC on converting to request structs

* Applying requested changes

* Many review fixes, handled

* Thrashed by nits

* More minor modifications

* The last nit!?

---------

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

engine/datahistory_manager.go

@@ -1195,11 +1195,11 @@ func (m *DataHistoryManager) validateJob(job *DataHistoryJob) error {
 	exchangeName := job.Exchange
 	if job.DataType == dataHistoryCandleValidationSecondarySourceType {
 		if job.SecondaryExchangeSource == "" {
-			return fmt.Errorf("job %s %w, secondary exchange name required to lookup existing results", job.Nickname, errExchangeNameUnset)
+			return fmt.Errorf("job %s %w, secondary exchange name required to lookup existing results", job.Nickname, common.ErrExchangeNameNotSet)
 		}
 		exchangeName = job.SecondaryExchangeSource
 		if job.Exchange == "" {
-			return fmt.Errorf("job %s %w, exchange name required to lookup existing results", job.Nickname, errExchangeNameUnset)
+			return fmt.Errorf("job %s %w, exchange name required to lookup existing results", job.Nickname, common.ErrExchangeNameNotSet)
 		}
 	}
 	exch, err := m.exchangeManager.GetExchangeByName(exchangeName)

engine/datahistory_manager_test.go

@@ -414,12 +414,12 @@ func TestValidateJob(t *testing.T) {
 
 	dhj.DataType = dataHistoryCandleValidationSecondarySourceType
 	err = m.validateJob(dhj)
-	assert.ErrorIs(t, err, errExchangeNameUnset)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	dhj.SecondaryExchangeSource = "lol"
 	dhj.Exchange = ""
 	err = m.validateJob(dhj)
-	assert.ErrorIs(t, err, errExchangeNameUnset)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 }
 
 func TestGetAllJobStatusBetween(t *testing.T) {

engine/depositaddress.go

@@ -3,7 +3,6 @@ package engine
 import (
 	"errors"
 	"fmt"
-	"maps"
 	"slices"
 	"strings"
 	"sync"
@@ -23,9 +22,12 @@ var (
 // DepositAddressManager manages the exchange deposit address store
 type DepositAddressManager struct {
 	m     sync.RWMutex
-	store map[string]map[string][]deposit.Address
+	store map[string]ExchangeDepositAddresses
 }
 
+// ExchangeDepositAddresses is a map of currencies to their deposit addresses
+type ExchangeDepositAddresses map[string][]deposit.Address
+
 // IsSynced returns whether or not the deposit address store has synced its data
 func (m *DepositAddressManager) IsSynced() bool {
 	if m.store == nil {
@@ -39,7 +41,7 @@ func (m *DepositAddressManager) IsSynced() bool {
 // SetupDepositAddressManager returns a DepositAddressManager
 func SetupDepositAddressManager() *DepositAddressManager {
 	return &DepositAddressManager{
-		store: make(map[string]map[string][]deposit.Address),
+		store: make(map[string]ExchangeDepositAddresses),
 	}
 }
 
@@ -86,7 +88,7 @@ func (m *DepositAddressManager) GetDepositAddressByExchangeAndCurrency(exchName,
 
 // GetDepositAddressesByExchange returns a list of cryptocurrency addresses for the specified
 // exchange if they exist
-func (m *DepositAddressManager) GetDepositAddressesByExchange(exchName string) (map[string][]deposit.Address, error) {
+func (m *DepositAddressManager) GetDepositAddressesByExchange(exchName string) (ExchangeDepositAddresses, error) {
 	m.m.RLock()
 	defer m.m.RUnlock()
 
@@ -99,15 +101,15 @@ func (m *DepositAddressManager) GetDepositAddressesByExchange(exchName string) (
 		return nil, ErrDepositAddressNotFound
 	}
 
-	cpy := maps.Clone(r)
-	for k, v := range cpy {
+	cpy := make(ExchangeDepositAddresses, len(r))
+	for k, v := range r {
 		cpy[k] = slices.Clone(v)
 	}
 	return cpy, nil
 }
 
 // Sync synchronises all deposit addresses
-func (m *DepositAddressManager) Sync(addresses map[string]map[string][]deposit.Address) error {
+func (m *DepositAddressManager) Sync(addresses map[string]ExchangeDepositAddresses) error {
 	if m == nil {
 		return fmt.Errorf("deposit address manager %w", ErrNilSubsystem)
 	}
@@ -118,7 +120,7 @@ func (m *DepositAddressManager) Sync(addresses map[string]map[string][]deposit.A
 	}
 
 	for k, v := range addresses {
-		r := make(map[string][]deposit.Address)
+		r := make(ExchangeDepositAddresses)
 		for w, x := range v {
 			r[strings.ToUpper(w)] = x
 		}

engine/depositaddress_test.go

@@ -21,7 +21,7 @@ func TestIsSynced(t *testing.T) {
 		t.Error("should be false")
 	}
 	m := SetupDepositAddressManager()
-	err := m.Sync(map[string]map[string][]deposit.Address{
+	err := m.Sync(map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{
@@ -49,7 +49,7 @@ func TestSetupDepositAddressManager(t *testing.T) {
 func TestSync(t *testing.T) {
 	t.Parallel()
 	m := SetupDepositAddressManager()
-	err := m.Sync(map[string]map[string][]deposit.Address{
+	err := m.Sync(map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{
@@ -70,7 +70,7 @@ func TestSync(t *testing.T) {
 	}
 
 	m.store = nil
-	err = m.Sync(map[string]map[string][]deposit.Address{
+	err = m.Sync(map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{
@@ -82,7 +82,7 @@ func TestSync(t *testing.T) {
 	assert.ErrorIs(t, err, ErrDepositAddressStoreIsNil)
 
 	m = nil
-	err = m.Sync(map[string]map[string][]deposit.Address{
+	err = m.Sync(map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{
@@ -100,7 +100,7 @@ func TestGetDepositAddressByExchangeAndCurrency(t *testing.T) {
 	_, err := m.GetDepositAddressByExchangeAndCurrency("", "", currency.BTC)
 	assert.ErrorIs(t, err, ErrDepositAddressStoreIsNil)
 
-	m.store = map[string]map[string][]deposit.Address{
+	m.store = map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{
@@ -155,7 +155,7 @@ func TestGetDepositAddressesByExchange(t *testing.T) {
 	_, err := m.GetDepositAddressesByExchange("")
 	assert.ErrorIs(t, err, ErrDepositAddressStoreIsNil)
 
-	m.store = map[string]map[string][]deposit.Address{
+	m.store = map[string]ExchangeDepositAddresses{
 		bitStamp: {
 			btc: []deposit.Address{
 				{

engine/engine_test.go

@@ -336,8 +336,7 @@ func TestSettingsPrint(t *testing.T) {
 }
 
 var unsupportedDefaultConfigExchanges = []string{
-	"poloniex",    // poloniex has dropped support for the API GCT has implemented //TODO: drop this when supported
-	"coinbasepro", // deprecated API. TODO: Remove this when the Coinbase update is merged
+	"poloniex", // poloniex has dropped support for the API GCT has implemented //TODO: drop this when supported
 }
 
 func TestGetDefaultConfigurations(t *testing.T) {

engine/exchange_manager.go

@@ -7,6 +7,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/thrasher-corp/gocryptotrader/common"
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
 	"github.com/thrasher-corp/gocryptotrader/log"
 )
@@ -17,7 +18,6 @@ var (
 	ErrExchangeNotFound      = errors.New("exchange not found")
 	ErrExchangeAlreadyLoaded = errors.New("exchange already loaded")
 	ErrExchangeFailedToLoad  = errors.New("exchange failed to load")
-	ErrExchangeNameIsEmpty   = errors.New("exchange name is empty")
 
 	errExchangeIsNil = errors.New("exchange is nil")
 )
@@ -81,7 +81,7 @@ func (m *ExchangeManager) RemoveExchange(exchangeName string) error {
 	}
 
 	if exchangeName == "" {
-		return fmt.Errorf("exchange manager: %w", ErrExchangeNameIsEmpty)
+		return fmt.Errorf("exchange manager: %w", common.ErrExchangeNameNotSet)
 	}
 
 	m.mtx.Lock()
@@ -105,7 +105,7 @@ func (m *ExchangeManager) GetExchangeByName(exchangeName string) (exchange.IBotE
 		return nil, fmt.Errorf("exchange manager: %w", ErrNilSubsystem)
 	}
 	if exchangeName == "" {
-		return nil, fmt.Errorf("exchange manager: %w", ErrExchangeNameIsEmpty)
+		return nil, fmt.Errorf("exchange manager: %w", common.ErrExchangeNameNotSet)
 	}
 	m.mtx.Lock()
 	defer m.mtx.Unlock()

engine/exchange_manager_test.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"github.com/thrasher-corp/gocryptotrader/common"
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/bitfinex"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/sharedtestvalues"
@@ -93,7 +94,7 @@ func TestExchangeManagerRemoveExchange(t *testing.T) {
 	m = NewExchangeManager()
 
 	err = m.RemoveExchange("")
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	err = m.RemoveExchange("Bitfinex")
 	require.ErrorIs(t, err, ErrExchangeNotFound)
@@ -130,7 +131,7 @@ func TestNewExchangeByName(t *testing.T) {
 
 	m = NewExchangeManager()
 	_, err = m.NewExchangeByName("")
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	exchanges := exchange.Exchanges
 	exchanges = append(exchanges, "fake")

engine/helpers.go

@@ -37,7 +37,7 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/exchanges/btcmarkets"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/btse"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/bybit"
-	"github.com/thrasher-corp/gocryptotrader/exchanges/coinbasepro"
+	"github.com/thrasher-corp/gocryptotrader/exchanges/coinbase"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/coinut"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/deposit"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/deribit"
@@ -694,8 +694,8 @@ func (bot *Engine) GetExchangeCryptocurrencyDepositAddress(ctx context.Context,
 }
 
 // GetAllExchangeCryptocurrencyDepositAddresses obtains an exchanges deposit cryptocurrency list
-func (bot *Engine) GetAllExchangeCryptocurrencyDepositAddresses() map[string]map[string][]deposit.Address {
-	result := make(map[string]map[string][]deposit.Address)
+func (bot *Engine) GetAllExchangeCryptocurrencyDepositAddresses() map[string]ExchangeDepositAddresses {
+	result := make(map[string]ExchangeDepositAddresses)
 	exchanges := bot.GetExchanges()
 	var depositSyncer sync.WaitGroup
 	depositSyncer.Add(len(exchanges))
@@ -992,8 +992,8 @@ func NewSupportedExchangeByName(name string) (exchange.IBotExchange, error) {
 		return new(deribit.Exchange), nil
 	case "exmo":
 		return new(exmo.Exchange), nil
-	case "coinbasepro":
-		return new(coinbasepro.Exchange), nil
+	case "coinbase":
+		return new(coinbase.Exchange), nil
 	case "gateio":
 		return new(gateio.Exchange), nil
 	case "gemini":

engine/order_manager.go

@@ -349,7 +349,7 @@ func (m *OrderManager) validate(exch exchange.IBotExchange, newOrder *order.Subm
 	}
 
 	if newOrder.Exchange == "" {
-		return ErrExchangeNameIsEmpty
+		return common.ErrExchangeNameNotSet
 	}
 
 	if err := newOrder.Validate(exch.GetTradingRequirements()); err != nil {

engine/order_manager_test.go

@@ -1276,7 +1276,7 @@ func TestSubmitFakeOrder(t *testing.T) {
 
 	ord := &order.Submit{}
 	_, err = o.SubmitFakeOrder(ord, resp, false)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	ord.Exchange = testExchange
 	ord.AssetType = asset.Spot

engine/rpcserver.go

@@ -64,7 +64,6 @@ var (
 	errExchangeNotEnabled      = errors.New("exchange is not enabled")
 	errExchangeBaseNotFound    = errors.New("cannot get exchange base")
 	errInvalidArguments        = errors.New("invalid arguments received")
-	errExchangeNameUnset       = errors.New("exchange name unset")
 	errCurrencyPairUnset       = errors.New("currency pair unset")
 	errInvalidTimes            = errors.New("invalid start and end times")
 	errAssetTypeUnset          = errors.New("asset type unset")
@@ -2102,7 +2101,7 @@ func (s *RPCServer) GetOrderbookStream(r *gctrpc.GetOrderbookStreamRequest, stre
 // GetExchangeOrderbookStream streams all orderbooks associated with an exchange
 func (s *RPCServer) GetExchangeOrderbookStream(r *gctrpc.GetExchangeOrderbookStreamRequest, stream gctrpc.GoCryptoTraderService_GetExchangeOrderbookStreamServer) error {
 	if r.Exchange == "" {
-		return errExchangeNameUnset
+		return common.ErrExchangeNameNotSet
 	}
 
 	if _, err := s.GetExchangeByName(r.Exchange); err != nil {
@@ -2172,7 +2171,7 @@ func (s *RPCServer) GetExchangeOrderbookStream(r *gctrpc.GetExchangeOrderbookStr
 // GetTickerStream streams the requested updated ticker
 func (s *RPCServer) GetTickerStream(r *gctrpc.GetTickerStreamRequest, stream gctrpc.GoCryptoTraderService_GetTickerStreamServer) error {
 	if r.Exchange == "" {
-		return errExchangeNameUnset
+		return common.ErrExchangeNameNotSet
 	}
 
 	if _, err := s.GetExchangeByName(r.Exchange); err != nil {
@@ -2244,7 +2243,7 @@ func (s *RPCServer) GetTickerStream(r *gctrpc.GetTickerStreamRequest, stream gct
 // GetExchangeTickerStream streams all tickers associated with an exchange
 func (s *RPCServer) GetExchangeTickerStream(r *gctrpc.GetExchangeTickerStreamRequest, stream gctrpc.GoCryptoTraderService_GetExchangeTickerStreamServer) error {
 	if r.Exchange == "" {
-		return errExchangeNameUnset
+		return common.ErrExchangeNameNotSet
 	}
 
 	if _, err := s.GetExchangeByName(r.Exchange); err != nil {

engine/rpcserver_test.go

@@ -769,7 +769,7 @@ func TestGetHistoricCandles(t *testing.T) {
 		End:       defaultEnd.Format(common.SimpleTimeFormatWithTimezone),
 		AssetType: asset.Spot.String(),
 	})
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = s.GetHistoricCandles(t.Context(), &gctrpc.GetHistoricCandlesRequest{
 		Exchange: "bruh",
@@ -1319,7 +1319,7 @@ func TestGetOrders(t *testing.T) {
 		AssetType: asset.Spot.String(),
 		Pair:      p,
 	})
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = s.GetOrders(t.Context(), &gctrpc.GetOrdersRequest{
 		Exchange:  "bruh",
@@ -1838,7 +1838,7 @@ func TestGetManagedOrders(t *testing.T) {
 		AssetType: asset.Spot.String(),
 		Pair:      p,
 	})
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = s.GetManagedOrders(t.Context(), &gctrpc.GetOrdersRequest{
 		Exchange:  "bruh",
@@ -2336,7 +2336,7 @@ func TestGetTechnicalAnalysis(t *testing.T) {
 	}
 
 	_, err = s.GetTechnicalAnalysis(t.Context(), &gctrpc.GetTechnicalAnalysisRequest{})
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	_, err = s.GetTechnicalAnalysis(t.Context(), &gctrpc.GetTechnicalAnalysisRequest{
 		Exchange: fakeExchangeName,
@@ -2572,7 +2572,7 @@ func TestGetMarginRatesHistory(t *testing.T) {
 
 	request := &gctrpc.GetMarginRatesHistoryRequest{}
 	_, err = s.GetMarginRatesHistory(t.Context(), request)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	request.Exchange = fakeExchangeName
 	_, err = s.GetMarginRatesHistory(t.Context(), request)
@@ -2725,7 +2725,7 @@ func TestGetFundingRates(t *testing.T) {
 		IncludePayments:  false,
 	}
 	_, err = s.GetFundingRates(t.Context(), request)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	request.Exchange = exch.GetName()
 	_, err = s.GetFundingRates(t.Context(), request)
@@ -2818,7 +2818,7 @@ func TestGetLatestFundingRate(t *testing.T) {
 		IncludePredicted: false,
 	}
 	_, err = s.GetLatestFundingRate(t.Context(), request)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	request.Exchange = exch.GetName()
 	_, err = s.GetLatestFundingRate(t.Context(), request)
@@ -2910,7 +2910,7 @@ func TestGetManagedPosition(t *testing.T) {
 		Quote:     "USD",
 	}
 	_, err = s.GetManagedPosition(t.Context(), request)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	request.Exchange = fakeExchangeName
 	_, err = s.GetManagedPosition(t.Context(), request)
@@ -3096,7 +3096,7 @@ func TestGetOrderbookMovement(t *testing.T) {
 
 	req := &gctrpc.GetOrderbookMovementRequest{}
 	_, err = s.GetOrderbookMovement(t.Context(), req)
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = "fake"
 	_, err = s.GetOrderbookMovement(t.Context(), req)
@@ -3189,7 +3189,7 @@ func TestGetOrderbookAmountByNominal(t *testing.T) {
 
 	req := &gctrpc.GetOrderbookAmountByNominalRequest{}
 	_, err = s.GetOrderbookAmountByNominal(t.Context(), req)
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = "fake"
 	_, err = s.GetOrderbookAmountByNominal(t.Context(), req)
@@ -3275,7 +3275,7 @@ func TestGetOrderbookAmountByImpact(t *testing.T) {
 
 	req := &gctrpc.GetOrderbookAmountByImpactRequest{}
 	_, err = s.GetOrderbookAmountByImpact(t.Context(), req)
-	require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	require.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = "fake"
 	_, err = s.GetOrderbookAmountByImpact(t.Context(), req)
@@ -3611,7 +3611,7 @@ func TestSetCollateralMode(t *testing.T) {
 
 	req := &gctrpc.SetCollateralModeRequest{}
 	_, err = s.SetCollateralMode(t.Context(), req)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = fakeExchangeName
 	req.Asset = asset.USDTMarginedFutures.String()
@@ -3648,7 +3648,7 @@ func TestGetCollateralMode(t *testing.T) {
 
 	req := &gctrpc.GetCollateralModeRequest{}
 	_, err = s.GetCollateralMode(t.Context(), req)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = fakeExchangeName
 	req.Asset = asset.USDTMarginedFutures.String()
@@ -3683,7 +3683,7 @@ func TestGetOpenInterest(t *testing.T) {
 
 	req := &gctrpc.GetOpenInterestRequest{}
 	_, err = s.GetOpenInterest(t.Context(), req)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = fakeExchangeName
 	_, err = s.GetOpenInterest(t.Context(), req)
@@ -3869,7 +3869,7 @@ func TestGetCurrencyTradeURL(t *testing.T) {
 
 	req := &gctrpc.GetCurrencyTradeURLRequest{}
 	_, err = s.GetCurrencyTradeURL(t.Context(), req)
-	assert.ErrorIs(t, err, ErrExchangeNameIsEmpty)
+	assert.ErrorIs(t, err, common.ErrExchangeNameNotSet)
 
 	req.Exchange = fakeExchangeName
 	_, err = s.GetCurrencyTradeURL(t.Context(), req)