d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-04 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

exchanges/qa: Add exchange wrapper testing suite (#1159)

Browse Source 
* initial concept of a nice validation tester for exchanges

* adds some datahandler design

* expand testing

* more tests and fixes

* minor end of day fix for bithumb

* fixes implementation issues

* more test coverage and improvements, but not sure if i should continue

* fix more wrapper implementations

* adds error type, more fixes

* changes signature, fixes implementations

* fixes more wrapper implementations

* one more bit

* more cleanup

* WOW things work?

* lintle 1/1337

* mini bump

* fixes all linting

* neaten

* GetOrderInfo+ asset pair fixes+improvements

* adds new websocket test

* expand ws testing

* fix bug, expand tests, improve implementation

* code coverage of a lot of new codes

* fixes everything

* reverts accidental changes

* minor fixes from reviewing code

* removes Bitfinex cancelBatchOrder implementation

* fixes dumb baby typo for babies

* mini nit fixes

* so many nits to address

* addresses all the nits

* Titlecase

* switcheroo

* removes websocket testing for now

* fix appveyor, minor test fix

* fixes typo, re-kindles killed kode

* skip binance wrapper tests when running CI

* expired context, huobi okx fixes

* kodespull

* fix ordering

* time fix because why not

* fix exmo, others

* hopefully this fixes all of my life's problems

* last thing today

* huobi, more like hypotrophy

* golangci-lint, more like mypooroldknee-splint

* fix huobi times by removing them

* should fix okx currency issues

* blocks the application

* adds last little contingency for pairs

* addresses most nits and new problems

* lovely fixed before seeing why okx sucks

* fixes issues with okx websocket

* the classic receieieivaier

* lintle

* adds test and fixes existing tests

* expands error handling messages during setup

* fixes dumb okx bugs introduced

* quick fix for lint and exmo

* fixes nixes

* fix exmo deposit issue

* lint

* fixes issue with extra asset runs missing

* fix surprise race

* all the lint and merge fixes

* fixes surprise bugs in OKx

* fixes issues with times and chains

* fixing all the merge stuff

* merge fix

* rm logs and a panic potential

* lovely lint lament

* an easy demonstration of scenario, but not of initial purpose

* put it in the bin

* Revert "put it in the bin"

This reverts commit 15c6490f713233d43f10957367fcbf18e3818bdd.

* re-add after immediate error popup

* fix mini poor test design

* okx okay

* merge fixes

* fixes issues discovered in lovely test

* I FORGOT TO COMMIT THIS

* nit fixaroonaboo

* forgoetten test fix

* revert old okx asset intrument work

* fixes

* revert problems I didnt understand. update bybit

* fix merge bugs

* test cleanup

* further improvements

* reshuffle and lint

* rm redundant CI_TEST by rm the CI_TEST field that is redundant

* path fix

* move to its own section, dont run on 32 bit + appveyor

* lint

* fix lbank

* address nits

* let it rip

* fix failing test time range

* niteroo boogaloo

* mod tidy, use common.SimpleTimeFormat
This commit is contained in:
Scott
2023-07-03 11:09:43 +10:00
committed by GitHub
parent ef605a3c19
commit fcc5ad4551
210 changed files with 38548 additions and 6519 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
exchanges/bithumb/bithumb_wrapper.go
View File

@@ -262,7 +262,11 @@ func (b *Bithumb) UpdateTradablePairs(ctx context.Context, forceUpdate bool) err
if err != nil {
return err
}
return b.UpdatePairs(pairs, asset.Spot, false, forceUpdate)
err = b.UpdatePairs(pairs, asset.Spot, false, forceUpdate)
if err != nil {
return err
}
return b.EnsureOnePairEnabled()
}
// UpdateTickers updates the ticker for all currency pairs of a given asset type
@@ -328,6 +332,12 @@ func (b *Bithumb) FetchOrderbook(ctx context.Context, p currency.Pair, assetType
// UpdateOrderbook updates and returns the orderbook for a currency pair
func (b *Bithumb) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType asset.Item) (*orderbook.Base, error) {
if p.IsEmpty() {
return nil, currency.ErrCurrencyPairEmpty
}
if err := b.CurrencyPairs.IsAssetEnabled(assetType); err != nil {
return nil, err
}
book := &orderbook.Base{
Exchange: b.Name,
Pair: p,
@@ -425,15 +435,28 @@ func (b *Bithumb) FetchAccountInfo(ctx context.Context, assetType asset.Item) (a
return acc, nil
}
// GetFundingHistory returns funding history, deposits and
// GetAccountFundingHistory returns funding history, deposits and
// withdrawals
func (b *Bithumb) GetFundingHistory(_ context.Context) ([]exchange.FundHistory, error) {
func (b *Bithumb) GetAccountFundingHistory(_ context.Context) ([]exchange.FundingHistory, error) {
return nil, common.ErrFunctionNotSupported
}
// GetWithdrawalsHistory returns previous withdrawals data
func (b *Bithumb) GetWithdrawalsHistory(_ context.Context, _ currency.Code, _ asset.Item) (resp []exchange.WithdrawalHistory, err error) {
return nil, common.ErrNotYetImplemented
func (b *Bithumb) GetWithdrawalsHistory(ctx context.Context, c currency.Code, _ asset.Item) ([]exchange.WithdrawalHistory, error) {
transactions, err := b.GetUserTransactions(ctx, 0, 0, 3, c, currency.EMPTYCODE)
if err != nil {
return nil, err
}
resp := make([]exchange.WithdrawalHistory, len(transactions.Data))
for i := range transactions.Data {
resp[i] = exchange.WithdrawalHistory{
Timestamp: time.UnixMilli(transactions.Data[i].TransferDate),
Currency: transactions.Data[i].OrderCurrency.String(),
Amount: transactions.Data[i].Amount,
Fee: transactions.Data[i].Fee,
}
}
return resp, nil
}
// GetRecentTrades returns the most recent trades for a currency and asset
@@ -455,7 +478,7 @@ func (b *Bithumb) GetRecentTrades(ctx context.Context, p currency.Pair, assetTyp
return nil, err
}
var t time.Time
t, err = time.Parse("2006-01-02 15:04:05", tradeData.Data[i].TransactionDate)
t, err = time.Parse(common.SimpleTimeFormat, tradeData.Data[i].TransactionDate)
if err != nil {
return nil, err
}
@@ -532,8 +555,8 @@ func (b *Bithumb) CancelOrder(ctx context.Context, o *order.Cancel) error {
}
// CancelBatchOrders cancels an orders by their corresponding ID numbers
func (b *Bithumb) CancelBatchOrders(_ context.Context, _ []order.Cancel) (order.CancelBatchResponse, error) {
return order.CancelBatchResponse{}, common.ErrNotYetImplemented
func (b *Bithumb) CancelBatchOrders(_ context.Context, _ []order.Cancel) (*order.CancelBatchResponse, error) {
return nil, common.ErrFunctionNotSupported
}
// CancelAllOrders cancels all orders associated with a currency pair
@@ -553,12 +576,7 @@ func (b *Bithumb) CancelAllOrders(ctx context.Context, orderCancellation *order.
}
for i := range currs {
orders, err := b.GetOrders(ctx,
"",
orderCancellation.Side.String(),
"100",
"",
currs[i].Base.String())
orders, err := b.GetOrders(ctx, "", orderCancellation.Side.String(), 100, time.Time{}, currs[i].Base, currency.EMPTYCODE)
if err != nil {
return cancelAllOrdersResponse, err
}
@@ -579,9 +597,37 @@ func (b *Bithumb) CancelAllOrders(ctx context.Context, orderCancellation *order.
}
// GetOrderInfo returns order information based on order ID
func (b *Bithumb) GetOrderInfo(_ context.Context, _ string, _ currency.Pair, _ asset.Item) (order.Detail, error) {
var orderDetail order.Detail
return orderDetail, common.ErrNotYetImplemented
func (b *Bithumb) GetOrderInfo(ctx context.Context, orderID string, pair currency.Pair, _ asset.Item) (*order.Detail, error) {
if pair.IsEmpty() {
return nil, currency.ErrCurrencyPairEmpty
}
orders, err := b.GetOrders(ctx, orderID, "", 0, time.Time{}, pair.Base, currency.EMPTYCODE)
if err != nil {
return nil, err
}
for i := range orders.Data {
if orders.Data[i].OrderID != orderID {
continue
}
orderDetail := order.Detail{
Amount: orders.Data[i].Units,
Exchange: b.Name,
ExecutedAmount: orders.Data[i].Units - orders.Data[i].UnitsRemaining,
OrderID: orders.Data[i].OrderID,
Date: orders.Data[i].OrderDate.Time(),
Price: orders.Data[i].Price,
RemainingAmount: orders.Data[i].UnitsRemaining,
Pair: pair,
}
if orders.Data[i].Type == "bid" {
orderDetail.Side = order.Buy
} else if orders.Data[i].Type == "ask" {
orderDetail.Side = order.Sell
}
return &orderDetail, nil
}
return nil, fmt.Errorf("%w %v", order.ErrOrderNotFound, orderID)
}
// GetDepositAddress returns a deposit address for a specified currency
@@ -626,8 +672,8 @@ func (b *Bithumb) WithdrawFiatFunds(ctx context.Context, withdrawRequest *withdr
if math.Mod(withdrawRequest.Amount, 1) != 0 {
return nil, errors.New("currency KRW does not support decimal places")
}
if withdrawRequest.Currency != currency.KRW {
return nil, errors.New("only KRW is supported")
if !withdrawRequest.Currency.Equal(currency.KRW) {
return nil, fmt.Errorf("only KRW supported, received '%v'", withdrawRequest.Currency)
}
bankDetails := strconv.FormatFloat(withdrawRequest.Fiat.Bank.BankCode, 'f', -1, 64) +
"_" + withdrawRequest.Fiat.Bank.BankName
@@ -665,7 +711,7 @@ func (b *Bithumb) GetFeeByType(ctx context.Context, feeBuilder *exchange.FeeBuil
}
// GetActiveOrders retrieves any orders that are active/open
func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersRequest) (order.FilteredOrders, error) {
func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
err := req.Validate()
if err != nil {
return nil, err
@@ -683,7 +729,7 @@ func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersReque
var orders []order.Detail
for x := range req.Pairs {
var resp Orders
resp, err = b.GetOrders(ctx, "", "", "1000", "", req.Pairs[x].Base.String())
resp, err = b.GetOrders(ctx, "", "", 1000, time.Time{}, req.Pairs[x].Base, currency.EMPTYCODE)
if err != nil {
return nil, err
}
@@ -721,7 +767,7 @@ func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersReque
// GetOrderHistory retrieves account order information
// Can Limit response to specific order status
func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.GetOrdersRequest) (order.FilteredOrders, error) {
func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
err := req.Validate()
if err != nil {
return nil, err
@@ -739,7 +785,7 @@ func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.GetOrdersReque
var orders []order.Detail
for x := range req.Pairs {
var resp Orders
resp, err = b.GetOrders(ctx, "", "", "1000", "", req.Pairs[x].Base.String())
resp, err = b.GetOrders(ctx, "", "", 1000, time.Time{}, req.Pairs[x].Base, currency.EMPTYCODE)
if err != nil {
return nil, err
}
@@ -803,9 +849,6 @@ func (b *Bithumb) GetHistoricCandles(ctx context.Context, pair currency.Pair, a
timeSeries := make([]kline.Candle, 0, len(candle.Data))
for x := range candle.Data {
if len(candle.Data[x]) < 6 {
return nil, errors.New("invalid candle length")
}
var tempCandle kline.Candle
if tempCandle.Time, err = convert.TimeFromUnixTimestampFloat(candle.Data[x][0]); err != nil {
return nil, fmt.Errorf("unable to convert timestamp: %w", err)
@@ -838,7 +881,7 @@ func (b *Bithumb) GetHistoricCandles(ctx context.Context, pair currency.Pair, a
// GetHistoricCandlesExtended returns candles between a time period for a set time interval
func (b *Bithumb) GetHistoricCandlesExtended(_ context.Context, _ currency.Pair, _ asset.Item, _ kline.Interval, _, _ time.Time) (*kline.Item, error) {
return nil, common.ErrNotYetImplemented
return nil, common.ErrFunctionNotSupported
}
// UpdateOrderExecutionLimits sets exchange executions for a required asset type
@@ -866,3 +909,8 @@ func (b *Bithumb) UpdateCurrencyStates(ctx context.Context, a asset.Item) error
}
return b.States.UpdateAll(a, payload)
}
// GetServerTime returns the current exchange server time.
func (b *Bithumb) GetServerTime(_ context.Context, _ asset.Item) (time.Time, error) {
return time.Time{}, common.ErrFunctionNotSupported
}