exchanges/qa: Add exchange wrapper testing suite (#1159)

* initial concept of a nice validation tester for exchanges * adds some datahandler design * expand testing * more tests and fixes * minor end of day fix for bithumb * fixes implementation issues * more test coverage and improvements, but not sure if i should continue * fix more wrapper implementations * adds error type, more fixes * changes signature, fixes implementations * fixes more wrapper implementations * one more bit * more cleanup * WOW things work? * lintle 1/1337 * mini bump * fixes all linting * neaten * GetOrderInfo+ asset pair fixes+improvements * adds new websocket test * expand ws testing * fix bug, expand tests, improve implementation * code coverage of a lot of new codes * fixes everything * reverts accidental changes * minor fixes from reviewing code * removes Bitfinex cancelBatchOrder implementation * fixes dumb baby typo for babies * mini nit fixes * so many nits to address * addresses all the nits * Titlecase * switcheroo * removes websocket testing for now * fix appveyor, minor test fix * fixes typo, re-kindles killed kode * skip binance wrapper tests when running CI * expired context, huobi okx fixes * kodespull * fix ordering * time fix because why not * fix exmo, others * hopefully this fixes all of my life's problems * last thing today * huobi, more like hypotrophy * golangci-lint, more like mypooroldknee-splint * fix huobi times by removing them * should fix okx currency issues * blocks the application * adds last little contingency for pairs * addresses most nits and new problems * lovely fixed before seeing why okx sucks * fixes issues with okx websocket * the classic receieieivaier * lintle * adds test and fixes existing tests * expands error handling messages during setup * fixes dumb okx bugs introduced * quick fix for lint and exmo * fixes nixes * fix exmo deposit issue * lint * fixes issue with extra asset runs missing * fix surprise race * all the lint and merge fixes * fixes surprise bugs in OKx * fixes issues with times and chains * fixing all the merge stuff * merge fix * rm logs and a panic potential * lovely lint lament * an easy demonstration of scenario, but not of initial purpose * put it in the bin * Revert "put it in the bin" This reverts commit 15c6490f713233d43f10957367fcbf18e3818bdd. * re-add after immediate error popup * fix mini poor test design * okx okay * merge fixes * fixes issues discovered in lovely test * I FORGOT TO COMMIT THIS * nit fixaroonaboo * forgoetten test fix * revert old okx asset intrument work * fixes * revert problems I didnt understand. update bybit * fix merge bugs * test cleanup * further improvements * reshuffle and lint * rm redundant CI_TEST by rm the CI_TEST field that is redundant * path fix * move to its own section, dont run on 32 bit + appveyor * lint * fix lbank * address nits * let it rip * fix failing test time range * niteroo boogaloo * mod tidy, use common.SimpleTimeFormat
2026-06-01 15:10:44 +00:00 · 2023-07-03 11:09:43 +10:00
parent ef605a3c19
commit fcc5ad4551
210 changed files with 38548 additions and 6519 deletions
--- a/exchanges/bithumb/bithumb.go
+++ b/exchanges/bithumb/bithumb.go
@@ -14,6 +14,7 @@ import (
 	"strings"
 	"time"

+	"github.com/thrasher-corp/gocryptotrader/common"
 	"github.com/thrasher-corp/gocryptotrader/common/crypto"
 	"github.com/thrasher-corp/gocryptotrader/currency"
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
@@ -239,7 +240,7 @@ func (b *Bithumb) GetAccountBalance(ctx context.Context, c string) (FullBalance,
 			var ok bool
 			val, ok = datum.(float64)
 			if !ok {
-				return fullBalance, errors.New("unable to type assert datum")
+				return fullBalance, common.GetTypeAssertError("float64", datum)
 			}
 		}

@@ -328,15 +329,18 @@ func (b *Bithumb) GetLastTransaction(ctx context.Context) (LastTransactionTicker
 // count: Value : 1 ~1000 (default : 100)
 // after: YYYY-MM-DD hh:mm:ss's UNIX Timestamp
 // (2014-11-28 16:40:01 = 1417160401000)
-func (b *Bithumb) GetOrders(ctx context.Context, orderID, transactionType, count, after, currency string) (Orders, error) {
+func (b *Bithumb) GetOrders(ctx context.Context, orderID, transactionType string, count int64, after time.Time, orderCurrency, paymentCurrency currency.Code) (Orders, error) {
 	response := Orders{}
 	params := url.Values{}

-	if currency == "" {
-		return response, errSymbolIsEmpty
+	if orderCurrency.IsEmpty() {
+		return response, currency.ErrCurrencyCodeEmpty
+	}
+	if !paymentCurrency.IsEmpty() {
+		params.Set("payment_currency", paymentCurrency.Upper().String())
 	}

-	params.Set("order_currency", strings.ToUpper(currency))
+	params.Set("order_currency", orderCurrency.Upper().String())

 	if len(orderID) > 0 {
 		params.Set("order_id", orderID)
@@ -346,12 +350,12 @@ func (b *Bithumb) GetOrders(ctx context.Context, orderID, transactionType, count
 		params.Set("type", transactionType)
 	}

-	if len(count) > 0 {
-		params.Set("count", count)
+	if count > 0 {
+		params.Set("count", strconv.FormatInt(count, 10))
 	}

-	if len(after) > 0 {
-		params.Set("after", after)
+	if !after.IsZero() {
+		params.Set("after", after.Format(common.SimpleTimeFormat))
 	}

 	return response,
@@ -359,11 +363,26 @@ func (b *Bithumb) GetOrders(ctx context.Context, orderID, transactionType, count
 }

 // GetUserTransactions returns customer transactions
-func (b *Bithumb) GetUserTransactions(ctx context.Context) (UserTransactions, error) {
-	response := UserTransactions{}
+func (b *Bithumb) GetUserTransactions(ctx context.Context, offset, count, searchType int64, orderCurrency, paymentCurrency currency.Code) (UserTransactions, error) {
+	params := url.Values{}
+	if offset > 0 {
+		params.Set("offset", strconv.FormatInt(offset, 10))
+	}
+	if count > 0 {
+		params.Set("count", strconv.FormatInt(count, 10))
+	}
+	if searchType > 0 {
+		params.Set("searchGb", strconv.FormatInt(searchType, 10))
+	}
+	if !orderCurrency.IsEmpty() {
+		params.Set("order_currency", orderCurrency.String())
+	}
+	if !paymentCurrency.IsEmpty() {
+		params.Set("payment_currency", paymentCurrency.String())
+	}
+	var response UserTransactions

-	return response,
-		b.SendAuthenticatedHTTPRequest(ctx, exchange.RestSpot, privateUserTrans, nil, &response)
+	return response, b.SendAuthenticatedHTTPRequest(ctx, exchange.RestSpot, privateUserTrans, params, &response)
 }

 // PlaceTrade executes a trade order
@@ -426,7 +445,7 @@ func (b *Bithumb) CancelTrade(ctx context.Context, transactionType, orderID, cur
 //
 // address: Currency withdrawing address
 // destination: Currency withdrawal Destination Tag (when withdraw XRP) OR
-// Currency withdrawal Payment Id (when withdraw XMR)
+// Currency withdrawal Payment ID (when withdraw XMR)
 // currency: BTC, ETH, DASH, LTC, ETC, XRP, BCH, XMR, ZEC, QTUM
 // (default value: BTC)
 // units: Quantity to withdraw currency
@@ -521,7 +540,7 @@ func (b *Bithumb) SendHTTPRequest(ctx context.Context, ep exchange.URL, path str
 	}
 	return b.SendPayload(ctx, request.Unset, func() (*request.Item, error) {
 		return item, nil
-	})
+	}, request.UnauthenticatedRequest)
 }

 // SendAuthenticatedHTTPRequest sends an authenticated HTTP request to bithumb
@@ -570,12 +589,11 @@ func (b *Bithumb) SendAuthenticatedHTTPRequest(ctx context.Context, ep exchange.
 			Headers:       headers,
 			Body:          bytes.NewBufferString(payload),
 			Result:        &intermediary,
-			AuthRequest:   true,
 			NonceEnabled:  true,
 			Verbose:       b.Verbose,
 			HTTPDebugging: b.HTTPDebugging,
 			HTTPRecording: b.HTTPRecording}, nil
-	})
+	}, request.AuthenticatedRequest)
 	if err != nil {
 		return err
 	}
--- a/exchanges/bithumb/bithumb_test.go
+++ b/exchanges/bithumb/bithumb_test.go
@@ -78,7 +78,7 @@ func TestGetTradablePairs(t *testing.T) {
 	t.Parallel()
 	_, err := b.GetTradablePairs(context.Background())
 	if err != nil {
-		t.Error("Bithumb GetTradablePairs() error", err)
+		t.Error(err)
 	}
 }

@@ -94,7 +94,7 @@ func TestGetAllTickers(t *testing.T) {
 	t.Parallel()
 	_, err := b.GetAllTickers(context.Background())
 	if err != nil {
-		t.Error("Bithumb GetAllTickers() error", err)
+		t.Error(err)
 	}
 }

@@ -102,15 +102,16 @@ func TestGetOrderBook(t *testing.T) {
 	t.Parallel()
 	_, err := b.GetOrderBook(context.Background(), testCurrency)
 	if err != nil {
-		t.Error("Bithumb GetOrderBook() error", err)
+		t.Error(err)
 	}
 }

 func TestGetTransactionHistory(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetTransactionHistory(context.Background(), testCurrency)
 	if err != nil {
-		t.Error("Bithumb GetTransactionHistory() error", err)
+		t.Error(err)
 	}
 }

@@ -139,7 +140,7 @@ func TestGetAccountBalance(t *testing.T) {

 	_, err := b.GetAccountBalance(context.Background(), testCurrency)
 	if err == nil {
-		t.Error("Bithumb GetAccountBalance() Expected error")
+		t.Error(err)
 	}
 }

@@ -148,68 +149,82 @@ func TestGetWalletAddress(t *testing.T) {
 	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)

 	_, err := b.GetWalletAddress(context.Background(), currency.BTC)
-	if err == nil {
-		t.Error("Bithumb GetWalletAddress() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestGetLastTransaction(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
 	_, err := b.GetLastTransaction(context.Background())
 	if err == nil {
-		t.Error("Bithumb GetLastTransaction() Expected error")
+		t.Error(err)
 	}
 }

 func TestGetOrders(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
 	_, err := b.GetOrders(context.Background(),
-		"1337", order.Bid.Lower(), "100", "", testCurrency)
-	if err == nil {
-		t.Error("Bithumb GetOrders() Expected error")
+		"1337", order.Bid.Lower(), 100, time.Time{}, currency.BTC, currency.KRW)
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestGetUserTransactions(t *testing.T) {
 	t.Parallel()
-	_, err := b.GetUserTransactions(context.Background())
-	if err == nil {
-		t.Error("Bithumb GetUserTransactions() Expected error")
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
+	_, err := b.GetUserTransactions(context.Background(), 0, 0, 0, currency.EMPTYCODE, currency.EMPTYCODE)
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestPlaceTrade(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	_, err := b.PlaceTrade(context.Background(),
 		testCurrency, order.Bid.Lower(), 0, 0)
-	if err == nil {
-		t.Error("Bithumb PlaceTrade() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestGetOrderDetails(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
 	_, err := b.GetOrderDetails(context.Background(),
 		"1337", order.Bid.Lower(), testCurrency)
-	if err == nil {
-		t.Error("Bithumb GetOrderDetails() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestCancelTrade(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	_, err := b.CancelTrade(context.Background(), "", "", "")
-	if err == nil {
-		t.Error("Bithumb CancelTrade() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestWithdrawCrypto(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	_, err := b.WithdrawCrypto(context.Background(),
 		"LQxiDhKU7idKiWQhx4ALKYkBx8xKEQVxJR", "", "ltc", 0)
-	if err == nil {
-		t.Error("Bithumb WithdrawCrypto() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

@@ -217,35 +232,41 @@ func TestRequestKRWDepositDetails(t *testing.T) {
 	t.Parallel()
 	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.RequestKRWDepositDetails(context.Background())
-	if err == nil {
-		t.Error("Bithumb RequestKRWDepositDetails() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestRequestKRWWithdraw(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	_, err := b.RequestKRWWithdraw(context.Background(),
 		"102_bank", "1337", 1000)
-	if err == nil {
-		t.Error("Bithumb RequestKRWWithdraw() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestMarketBuyOrder(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	p := currency.NewPair(currency.BTC, currency.KRW)
 	_, err := b.MarketBuyOrder(context.Background(), p, 0)
-	if err == nil {
-		t.Error("Bithumb MarketBuyOrder() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

 func TestMarketSellOrder(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	p := currency.NewPair(currency.BTC, currency.KRW)
 	_, err := b.MarketSellOrder(context.Background(), p, 0)
-	if err == nil {
-		t.Error("Bithumb MarketSellOrder() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

@@ -365,7 +386,7 @@ func TestFormatWithdrawPermissions(t *testing.T) {

 func TestGetActiveOrders(t *testing.T) {
 	t.Parallel()
-	var getOrdersRequest = order.GetOrdersRequest{
+	var getOrdersRequest = order.MultiOrderRequest{
 		Type:      order.AnyType,
 		Side:      order.Sell,
 		AssetType: asset.Spot,
@@ -381,10 +402,11 @@ func TestGetActiveOrders(t *testing.T) {

 func TestGetOrderHistory(t *testing.T) {
 	t.Parallel()
-	var getOrdersRequest = order.GetOrdersRequest{
+	var getOrdersRequest = order.MultiOrderRequest{
 		Type:      order.AnyType,
 		AssetType: asset.Spot,
 		Side:      order.AnySide,
+		Pairs:     currency.Pairs{currency.NewPair(currency.BTC, currency.KRW)},
 	}

 	_, err := b.GetOrderHistory(context.Background(), &getOrdersRequest)
@@ -489,6 +511,8 @@ func TestGetAccountInfo(t *testing.T) {

 func TestModifyOrder(t *testing.T) {
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
+
 	curr, err := currency.NewPairFromString("BTCUSD")
 	if err != nil {
 		t.Fatal(err)
@@ -501,8 +525,8 @@ func TestModifyOrder(t *testing.T) {
 		Pair:      curr,
 		AssetType: asset.Spot,
 	})
-	if err == nil {
-		t.Error("ModifyOrder() Expected error")
+	if err != nil {
+		t.Error(err)
 	}
 }

@@ -610,7 +634,7 @@ func TestGetHistoricCandlesExtended(t *testing.T) {
 	}
 	startTime := time.Now().Add(-time.Hour * 24)
 	_, err = b.GetHistoricCandlesExtended(context.Background(), pair, asset.Spot, kline.OneDay, startTime, time.Now())
-	if !errors.Is(err, common.ErrNotYetImplemented) {
+	if !errors.Is(err, common.ErrFunctionNotSupported) {
 		t.Fatal(err)
 	}
 }
@@ -749,3 +773,33 @@ func TestUpdateCurrencyStates(t *testing.T) {
 		t.Fatalf("received: %v but expected: %v", err, nil)
 	}
 }
+
+func TestGetWithdrawalsHistory(t *testing.T) {
+	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
+	_, err := b.GetWithdrawalsHistory(context.Background(), currency.BTC, asset.Spot)
+	if err != nil {
+		t.Error(err)
+	}
+}
+
+func TestGetOrderInfo(t *testing.T) {
+	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
+	_, err := b.GetOrderInfo(context.Background(), "1234", currency.NewPair(currency.BTC, currency.USDT), asset.Spot)
+	if err != nil {
+		t.Error(err)
+	}
+}
+
+func TestGetWithdrawalHistory(t *testing.T) {
+	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
+
+	_, err := b.GetWithdrawalsHistory(context.Background(), currency.BTC, asset.Spot)
+	if err != nil {
+		t.Error(err)
+	}
+}
--- a/exchanges/bithumb/bithumb_types.go
+++ b/exchanges/bithumb/bithumb_types.go
@@ -144,14 +144,17 @@ type OrderData struct {
 type UserTransactions struct {
 	Status string `json:"status"`
 	Data   []struct {
-		Search       string  `json:"search"`
-		TransferDate int64   `json:"transfer_date"`
-		Units        string  `json:"units"`
-		Price        float64 `json:"price,string"`
-		BTC1KRW      float64 `json:"btc1krw,string"`
-		Fee          string  `json:"fee"`
-		BTCRemain    float64 `json:"btc_remain,string"`
-		KRWRemain    float64 `json:"krw_remain,string"`
+		Search          int64         `json:"search,string"`
+		TransferDate    int64         `json:"transfer_date"`
+		OrderCurrency   currency.Code `json:"order_currency"`
+		PaymentCurrency currency.Code `json:"payment_currency"`
+		Units           float64       `json:"units,string"`
+		Price           float64       `json:"price,string"`
+		Amount          float64       `json:"amount,string"`
+		FeeCurrency     currency.Code `json:"fee_currency"`
+		Fee             float64       `json:"fee,string"`
+		OrderBalance    float64       `json:"order_balance,string"`
+		PaymentBalance  float64       `json:"payment_balance,string"`
 	} `json:"data"`
 	Message string `json:"message"`
 }
--- a/exchanges/bithumb/bithumb_wrapper.go
+++ b/exchanges/bithumb/bithumb_wrapper.go
@@ -262,7 +262,11 @@ func (b *Bithumb) UpdateTradablePairs(ctx context.Context, forceUpdate bool) err
 	if err != nil {
 		return err
 	}
-	return b.UpdatePairs(pairs, asset.Spot, false, forceUpdate)
+	err = b.UpdatePairs(pairs, asset.Spot, false, forceUpdate)
+	if err != nil {
+		return err
+	}
+	return b.EnsureOnePairEnabled()
 }

 // UpdateTickers updates the ticker for all currency pairs of a given asset type
@@ -328,6 +332,12 @@ func (b *Bithumb) FetchOrderbook(ctx context.Context, p currency.Pair, assetType

 // UpdateOrderbook updates and returns the orderbook for a currency pair
 func (b *Bithumb) UpdateOrderbook(ctx context.Context, p currency.Pair, assetType asset.Item) (*orderbook.Base, error) {
+	if p.IsEmpty() {
+		return nil, currency.ErrCurrencyPairEmpty
+	}
+	if err := b.CurrencyPairs.IsAssetEnabled(assetType); err != nil {
+		return nil, err
+	}
 	book := &orderbook.Base{
 		Exchange:        b.Name,
 		Pair:            p,
@@ -425,15 +435,28 @@ func (b *Bithumb) FetchAccountInfo(ctx context.Context, assetType asset.Item) (a
 	return acc, nil
 }

-// GetFundingHistory returns funding history, deposits and
+// GetAccountFundingHistory returns funding history, deposits and
 // withdrawals
-func (b *Bithumb) GetFundingHistory(_ context.Context) ([]exchange.FundHistory, error) {
+func (b *Bithumb) GetAccountFundingHistory(_ context.Context) ([]exchange.FundingHistory, error) {
 	return nil, common.ErrFunctionNotSupported
 }

 // GetWithdrawalsHistory returns previous withdrawals data
-func (b *Bithumb) GetWithdrawalsHistory(_ context.Context, _ currency.Code, _ asset.Item) (resp []exchange.WithdrawalHistory, err error) {
-	return nil, common.ErrNotYetImplemented
+func (b *Bithumb) GetWithdrawalsHistory(ctx context.Context, c currency.Code, _ asset.Item) ([]exchange.WithdrawalHistory, error) {
+	transactions, err := b.GetUserTransactions(ctx, 0, 0, 3, c, currency.EMPTYCODE)
+	if err != nil {
+		return nil, err
+	}
+	resp := make([]exchange.WithdrawalHistory, len(transactions.Data))
+	for i := range transactions.Data {
+		resp[i] = exchange.WithdrawalHistory{
+			Timestamp: time.UnixMilli(transactions.Data[i].TransferDate),
+			Currency:  transactions.Data[i].OrderCurrency.String(),
+			Amount:    transactions.Data[i].Amount,
+			Fee:       transactions.Data[i].Fee,
+		}
+	}
+	return resp, nil
 }

 // GetRecentTrades returns the most recent trades for a currency and asset
@@ -455,7 +478,7 @@ func (b *Bithumb) GetRecentTrades(ctx context.Context, p currency.Pair, assetTyp
 			return nil, err
 		}
 		var t time.Time
-		t, err = time.Parse("2006-01-02 15:04:05", tradeData.Data[i].TransactionDate)
+		t, err = time.Parse(common.SimpleTimeFormat, tradeData.Data[i].TransactionDate)
 		if err != nil {
 			return nil, err
 		}
@@ -532,8 +555,8 @@ func (b *Bithumb) CancelOrder(ctx context.Context, o *order.Cancel) error {
 }

 // CancelBatchOrders cancels an orders by their corresponding ID numbers
-func (b *Bithumb) CancelBatchOrders(_ context.Context, _ []order.Cancel) (order.CancelBatchResponse, error) {
-	return order.CancelBatchResponse{}, common.ErrNotYetImplemented
+func (b *Bithumb) CancelBatchOrders(_ context.Context, _ []order.Cancel) (*order.CancelBatchResponse, error) {
+	return nil, common.ErrFunctionNotSupported
 }

 // CancelAllOrders cancels all orders associated with a currency pair
@@ -553,12 +576,7 @@ func (b *Bithumb) CancelAllOrders(ctx context.Context, orderCancellation *order.
 	}

 	for i := range currs {
-		orders, err := b.GetOrders(ctx,
-			"",
-			orderCancellation.Side.String(),
-			"100",
-			"",
-			currs[i].Base.String())
+		orders, err := b.GetOrders(ctx, "", orderCancellation.Side.String(), 100, time.Time{}, currs[i].Base, currency.EMPTYCODE)
 		if err != nil {
 			return cancelAllOrdersResponse, err
 		}
@@ -579,9 +597,37 @@ func (b *Bithumb) CancelAllOrders(ctx context.Context, orderCancellation *order.
 }

 // GetOrderInfo returns order information based on order ID
-func (b *Bithumb) GetOrderInfo(_ context.Context, _ string, _ currency.Pair, _ asset.Item) (order.Detail, error) {
-	var orderDetail order.Detail
-	return orderDetail, common.ErrNotYetImplemented
+func (b *Bithumb) GetOrderInfo(ctx context.Context, orderID string, pair currency.Pair, _ asset.Item) (*order.Detail, error) {
+	if pair.IsEmpty() {
+		return nil, currency.ErrCurrencyPairEmpty
+	}
+	orders, err := b.GetOrders(ctx, orderID, "", 0, time.Time{}, pair.Base, currency.EMPTYCODE)
+	if err != nil {
+		return nil, err
+	}
+	for i := range orders.Data {
+		if orders.Data[i].OrderID != orderID {
+			continue
+		}
+		orderDetail := order.Detail{
+			Amount:          orders.Data[i].Units,
+			Exchange:        b.Name,
+			ExecutedAmount:  orders.Data[i].Units - orders.Data[i].UnitsRemaining,
+			OrderID:         orders.Data[i].OrderID,
+			Date:            orders.Data[i].OrderDate.Time(),
+			Price:           orders.Data[i].Price,
+			RemainingAmount: orders.Data[i].UnitsRemaining,
+			Pair:            pair,
+		}
+
+		if orders.Data[i].Type == "bid" {
+			orderDetail.Side = order.Buy
+		} else if orders.Data[i].Type == "ask" {
+			orderDetail.Side = order.Sell
+		}
+		return &orderDetail, nil
+	}
+	return nil, fmt.Errorf("%w %v", order.ErrOrderNotFound, orderID)
 }

 // GetDepositAddress returns a deposit address for a specified currency
@@ -626,8 +672,8 @@ func (b *Bithumb) WithdrawFiatFunds(ctx context.Context, withdrawRequest *withdr
 	if math.Mod(withdrawRequest.Amount, 1) != 0 {
 		return nil, errors.New("currency KRW does not support decimal places")
 	}
-	if withdrawRequest.Currency != currency.KRW {
-		return nil, errors.New("only KRW is supported")
+	if !withdrawRequest.Currency.Equal(currency.KRW) {
+		return nil, fmt.Errorf("only KRW supported, received '%v'", withdrawRequest.Currency)
 	}
 	bankDetails := strconv.FormatFloat(withdrawRequest.Fiat.Bank.BankCode, 'f', -1, 64) +
 		"_" + withdrawRequest.Fiat.Bank.BankName
@@ -665,7 +711,7 @@ func (b *Bithumb) GetFeeByType(ctx context.Context, feeBuilder *exchange.FeeBuil
 }

 // GetActiveOrders retrieves any orders that are active/open
-func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersRequest) (order.FilteredOrders, error) {
+func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
 	err := req.Validate()
 	if err != nil {
 		return nil, err
@@ -683,7 +729,7 @@ func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersReque
 	var orders []order.Detail
 	for x := range req.Pairs {
 		var resp Orders
-		resp, err = b.GetOrders(ctx, "", "", "1000", "", req.Pairs[x].Base.String())
+		resp, err = b.GetOrders(ctx, "", "", 1000, time.Time{}, req.Pairs[x].Base, currency.EMPTYCODE)
 		if err != nil {
 			return nil, err
 		}
@@ -721,7 +767,7 @@ func (b *Bithumb) GetActiveOrders(ctx context.Context, req *order.GetOrdersReque

 // GetOrderHistory retrieves account order information
 // Can Limit response to specific order status
-func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.GetOrdersRequest) (order.FilteredOrders, error) {
+func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.MultiOrderRequest) (order.FilteredOrders, error) {
 	err := req.Validate()
 	if err != nil {
 		return nil, err
@@ -739,7 +785,7 @@ func (b *Bithumb) GetOrderHistory(ctx context.Context, req *order.GetOrdersReque
 	var orders []order.Detail
 	for x := range req.Pairs {
 		var resp Orders
-		resp, err = b.GetOrders(ctx, "", "", "1000", "", req.Pairs[x].Base.String())
+		resp, err = b.GetOrders(ctx, "", "", 1000, time.Time{}, req.Pairs[x].Base, currency.EMPTYCODE)
 		if err != nil {
 			return nil, err
 		}
@@ -803,9 +849,6 @@ func (b *Bithumb) GetHistoricCandles(ctx context.Context, pair currency.Pair, a

 	timeSeries := make([]kline.Candle, 0, len(candle.Data))
 	for x := range candle.Data {
-		if len(candle.Data[x]) < 6 {
-			return nil, errors.New("invalid candle length")
-		}
 		var tempCandle kline.Candle
 		if tempCandle.Time, err = convert.TimeFromUnixTimestampFloat(candle.Data[x][0]); err != nil {
 			return nil, fmt.Errorf("unable to convert timestamp: %w", err)
@@ -838,7 +881,7 @@ func (b *Bithumb) GetHistoricCandles(ctx context.Context, pair currency.Pair, a

 // GetHistoricCandlesExtended returns candles between a time period for a set time interval
 func (b *Bithumb) GetHistoricCandlesExtended(_ context.Context, _ currency.Pair, _ asset.Item, _ kline.Interval, _, _ time.Time) (*kline.Item, error) {
-	return nil, common.ErrNotYetImplemented
+	return nil, common.ErrFunctionNotSupported
 }

 // UpdateOrderExecutionLimits sets exchange executions for a required asset type
@@ -866,3 +909,8 @@ func (b *Bithumb) UpdateCurrencyStates(ctx context.Context, a asset.Item) error
 	}
 	return b.States.UpdateAll(a, payload)
 }
+
+// GetServerTime returns the current exchange server time.
+func (b *Bithumb) GetServerTime(_ context.Context, _ asset.Item) (time.Time, error) {
+	return time.Time{}, common.ErrFunctionNotSupported
+}