exchanges/qa: Add exchange wrapper testing suite (#1159)

* initial concept of a nice validation tester for exchanges

* adds some datahandler design

* expand testing

* more tests and fixes

* minor end of day fix for bithumb

* fixes implementation issues

* more test coverage and improvements, but not sure if i should continue

* fix more wrapper implementations

* adds error type, more fixes

* changes signature, fixes implementations

* fixes more wrapper implementations

* one more bit

* more cleanup

* WOW things work?

* lintle 1/1337

* mini bump

* fixes all linting

* neaten

* GetOrderInfo+ asset pair fixes+improvements

* adds new websocket test

* expand ws testing

* fix bug, expand tests, improve implementation

* code coverage of a lot of new codes

* fixes everything

* reverts accidental changes

* minor fixes from reviewing code

* removes Bitfinex cancelBatchOrder implementation

* fixes dumb baby typo for babies

* mini nit fixes

* so many nits to address

* addresses all the nits

* Titlecase

* switcheroo

* removes websocket testing for now

* fix appveyor, minor test fix

* fixes typo, re-kindles killed kode

* skip binance wrapper tests when running CI

* expired context, huobi okx fixes

* kodespull

* fix ordering

* time fix because why not

* fix exmo, others

* hopefully this fixes all of my life's problems

* last thing today

* huobi, more like hypotrophy

* golangci-lint, more like mypooroldknee-splint

* fix huobi times by removing them

* should fix okx currency issues

* blocks the application

* adds last little contingency for pairs

* addresses most nits and new problems

* lovely fixed before seeing why okx sucks

* fixes issues with okx websocket

* the classic receieieivaier

* lintle

* adds test and fixes existing tests

* expands error handling messages during setup

* fixes dumb okx bugs introduced

* quick fix for lint and exmo

* fixes nixes

* fix exmo deposit issue

* lint

* fixes issue with extra asset runs missing

* fix surprise race

* all the lint and merge fixes

* fixes surprise bugs in OKx

* fixes issues with times and chains

* fixing all the merge stuff

* merge fix

* rm logs and a panic potential

* lovely lint lament

* an easy demonstration of scenario, but not of initial purpose

* put it in the bin

* Revert "put it in the bin"

This reverts commit 15c6490f713233d43f10957367fcbf18e3818bdd.

* re-add after immediate error popup

* fix mini poor test design

* okx okay

* merge fixes

* fixes issues discovered in lovely test

* I FORGOT TO COMMIT THIS

* nit fixaroonaboo

* forgoetten test fix

* revert old okx asset intrument work

* fixes

* revert problems I didnt understand. update bybit

* fix merge bugs

* test cleanup

* further improvements

* reshuffle and lint

* rm redundant CI_TEST by rm the CI_TEST field that is redundant

* path fix

* move to its own section, dont run on 32 bit + appveyor

* lint

* fix lbank

* address nits

* let it rip

* fix failing test time range

* niteroo boogaloo

* mod tidy, use common.SimpleTimeFormat

common/common.go

@@ -585,8 +585,13 @@ func GenerateRandomString(length uint, characters ...string) (string, error) {
 	return string(b), nil
 }
 
-// GetAssertError returns additional information for when an assertion failure
+// GetTypeAssertError returns additional information for when an assertion failure
 // occurs.
-func GetAssertError(required string, received interface{}) error {
-	return fmt.Errorf("%w from %T to %s", ErrTypeAssertFailure, received, required)
+// fieldDescription is an optional way to return what the affected field was for
+func GetTypeAssertError(required string, received interface{}, fieldDescription ...string) error {
+	var description string
+	if len(fieldDescription) > 0 {
+		description = " for: " + strings.Join(fieldDescription, ", ")
+	}
+	return fmt.Errorf("%w from %T to %s%s", ErrTypeAssertFailure, received, required, description)
 }

common/common_test.go

@@ -806,20 +806,30 @@ func TestParseStartEndDate(t *testing.T) {
 }
 
 func TestGetAssertError(t *testing.T) {
-	err := GetAssertError("*[]string", float64(0))
+	err := GetTypeAssertError("*[]string", float64(0))
 	if err.Error() != "type assert failure from float64 to *[]string" {
 		t.Fatal(err)
 	}
 
-	err = GetAssertError("<nil>", nil)
+	err = GetTypeAssertError("<nil>", nil)
 	if err.Error() != "type assert failure from <nil> to <nil>" {
 		t.Fatal(err)
 	}
 
-	err = GetAssertError("bruh", struct{}{})
+	err = GetTypeAssertError("bruh", struct{}{})
 	if !errors.Is(err, ErrTypeAssertFailure) {
 		t.Fatalf("received: '%v' but expected: '%v'", err, ErrTypeAssertFailure)
 	}
+
+	err = GetTypeAssertError("string", struct{}{})
+	if err.Error() != "type assert failure from struct {} to string" {
+		t.Errorf("unexpected error message: %v", err)
+	}
+
+	err = GetTypeAssertError("string", struct{}{}, "bidSize")
+	if err.Error() != "type assert failure from struct {} to string for: bidSize" {
+		t.Errorf("unexpected error message: %v", err)
+	}
 }
 
 func TestMatchesEmailPattern(t *testing.T) {

common/file/archive/zip_test.go

@@ -57,11 +57,18 @@ func TestZip(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if filepath.Base(o[0]) != "binance.json" {
-		t.Fatal("unexpected archive result received")
+	var found bool
+	for i := range o {
+		if filepath.Base(o[i]) == "binance.json" {
+			found = true
+		}
 	}
-	if expected := 6; len(o) != expected {
-		t.Fatalf("expected %v files to be extracted received: %v ", expected, len(o))
+	if !found {
+		t.Fatal("could not find file in zip")
+	}
+
+	if expected := 6; len(o) < expected {
+		t.Fatalf("expected at least %v files to be extracted, received: %v ", expected, len(o))
 	}
 
 	folder = filepath.Join("..", "..", "..", "testdata", "invalid_file.json")