d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bitfinex: Fix intermittent TestGenerateSubscriptions and ticker FRRAmountAvailable failures (#1865)

Browse Source 
* Bitfinex: Fix intermittent TestGenerateSubscriptions and ticker FRRAmountAvailable failures

* Bitfinex: Add comment for FRRAmountAvailable
This commit is contained in:
Adrian Gallagher
2025-04-01 17:05:34 +11:00
committed by GitHub
parent 177f2a7c03
commit f69abcd0ae
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
exchanges/bitfinex/bitfinex.go
View File

@@ -707,7 +707,7 @@ func tickerFromResp(symbol string, respAny []any) (*Ticker, error) {
}, nil
}
var fundingTickerFields = []string{"FlashReturnRate", "Bid", "BidPeriod", "BidSize", "Ask", "AskPeriod", "AskSize", "DailyChange", "DailyChangePercentage", "LastPrice", "DailyVolume", "DailyHigh", "DailyLow", "", "", "FFRAmountAvailable"}
var fundingTickerFields = []string{"FlashReturnRate", "Bid", "BidPeriod", "BidSize", "Ask", "AskPeriod", "AskSize", "DailyChange", "DailyChangePercentage", "LastPrice", "DailyVolume", "DailyHigh", "DailyLow", "", "", "FRRAmountAvailable"}
func tickerFromFundingResp(symbol string, respAny []any) (*Ticker, error) {
if len(respAny) != 16 {
@@ -738,7 +738,7 @@ func tickerFromFundingResp(symbol string, respAny []any) (*Ticker, error) {
Volume: resp[10],
High: resp[11],
Low: resp[12],
FFRAmountAvailable: resp[15],
FRRAmountAvailable: resp[15],
}, nil
}

6
exchanges/bitfinex/bitfinex_test.go
View File

@@ -284,7 +284,7 @@ func TestTickerFromFundingResp(t *testing.T) {
assert.Equal(t, 11.11, tick.Volume, "Tick Volume should be correct")
assert.Equal(t, 12.12, tick.High, "Tick High should be correct")
assert.Equal(t, 13.13, tick.Low, "Tick Low should be correct")
assert.Equal(t, 15.15, tick.FFRAmountAvailable, "Tick FFRAmountAvailable should be correct")
assert.Equal(t, 15.15, tick.FRRAmountAvailable, "Tick FRRAmountAvailable should be correct")
}
func TestGetTickerFunding(t *testing.T) {
@@ -314,7 +314,7 @@ func checkFundingTick(tb testing.TB, tick *Ticker) {
assert.Positive(tb, tick.AskPeriod, "Tick AskPeriod should be positive")
assert.Positive(tb, tick.AskSize, "Tick AskSize should be positive")
assert.Positive(tb, tick.Last, "Tick Last should be positive")
assert.Positive(tb, tick.FFRAmountAvailable, "Tick FFRAmountavailable should be positive")
// Can't test FRRAmountAvailable as it's occasionally 0
}
func TestGetTrades(t *testing.T) {
@@ -1134,6 +1134,8 @@ func TestWSAuth(t *testing.T) {
func TestGenerateSubscriptions(t *testing.T) {
t.Parallel()
b := new(Bitfinex) //nolint:govet // Intentional shadow of b to avoid future copy/paste mistakes
require.NoError(t, testexch.Setup(b), "Setup must not error")
b.Websocket.SetCanUseAuthenticatedEndpoints(true)
require.True(t, b.Websocket.CanUseAuthenticatedEndpoints(), "CanUseAuthenticatedEndpoints must return true")
subs, err := b.generateSubscriptions()

2
exchanges/bitfinex/bitfinex_types.go
View File

@@ -149,7 +149,7 @@ type Ticker struct {
Volume float64
High float64
Low float64
FFRAmountAvailable float64
FRRAmountAvailable float64 // Flash Return Rate amount available
}
// DerivativeDataResponse stores data for queried derivative