linter: Enable gofumpt and run against codebase (#1848)

* linter: Enable gofumpt and run against codebase

* Address shazbert's nits

* gofumpt: Fix issues after rebase
This commit is contained in:
Adrian Gallagher
2025-03-18 10:23:16 +11:00
committed by GitHub
parent 748ed71455
commit f5faca2eb2
189 changed files with 1541 additions and 1104 deletions

View File

@@ -47,7 +47,6 @@ func TestSubmitValidate(t *testing.T) {
Submit: &Submit{Exchange: "test"},
}, // empty pair
{
ExpectedErr: ErrAssetNotSet,
Submit: &Submit{Exchange: "test", Pair: testPair},
}, // valid pair but invalid asset
@@ -316,7 +315,7 @@ func TestSubmitResponse_DeriveDetail(t *testing.T) {
func TestOrderSides(t *testing.T) {
t.Parallel()
var os = Buy
os := Buy
if os.String() != "BUY" {
t.Errorf("unexpected string %s", os.String())
}
@@ -442,7 +441,7 @@ func TestInferCostsAndTimes(t *testing.T) {
func TestFilterOrdersByType(t *testing.T) {
t.Parallel()
var orders = []Detail{
orders := []Detail{
{
Type: ImmediateOrCancel,
},
@@ -494,7 +493,7 @@ func BenchmarkFilterOrdersByType(b *testing.B) {
func TestFilterOrdersBySide(t *testing.T) {
t.Parallel()
var orders = []Detail{
orders := []Detail{
{
Side: Buy,
},
@@ -546,7 +545,7 @@ func BenchmarkFilterOrdersBySide(b *testing.B) {
func TestFilterOrdersByTimeRange(t *testing.T) {
t.Parallel()
var orders = []Detail{
orders := []Detail{
{
Date: time.Unix(100, 0),
},
@@ -634,7 +633,7 @@ func BenchmarkFilterOrdersByTimeRange(b *testing.B) {
func TestFilterOrdersByPairs(t *testing.T) {
t.Parallel()
var orders = []Detail{
orders := []Detail{
{
Pair: currency.NewPair(currency.BTC, currency.USD),
},
@@ -647,16 +646,20 @@ func TestFilterOrdersByPairs(t *testing.T) {
{}, // Unpopulated fields are preserved for API differences
}
currencies := []currency.Pair{currency.NewPair(currency.BTC, currency.USD),
currencies := []currency.Pair{
currency.NewPair(currency.BTC, currency.USD),
currency.NewPair(currency.LTC, currency.EUR),
currency.NewPair(currency.DOGE, currency.RUB)}
currency.NewPair(currency.DOGE, currency.RUB),
}
FilterOrdersByPairs(&orders, currencies)
if len(orders) != 4 {
t.Errorf("Orders failed to be filtered. Expected %v, received %v", 3, len(orders))
}
currencies = []currency.Pair{currency.NewPair(currency.BTC, currency.USD),
currency.NewPair(currency.LTC, currency.EUR)}
currencies = []currency.Pair{
currency.NewPair(currency.BTC, currency.USD),
currency.NewPair(currency.LTC, currency.EUR),
}
FilterOrdersByPairs(&orders, currencies)
if len(orders) != 3 {
t.Errorf("Orders failed to be filtered. Expected %v, received %v", 2, len(orders))
@@ -1143,7 +1146,7 @@ func TestUpdateOrderFromModifyResponse(t *testing.T) {
}
func TestUpdateOrderFromDetail(t *testing.T) {
var leet = "1337"
leet := "1337"
updated := time.Now()
@@ -1432,7 +1435,7 @@ func TestValidationOnOrderTypes(t *testing.T) {
t.Fatalf("received: '%v' but expected: '%v'", err, errUnrecognisedOrderType)
}
var errTestError = errors.New("test error")
errTestError := errors.New("test error")
getOrders.Type = AnyType
err = getOrders.Validate(validate.Check(func() error {
return errTestError
@@ -1985,7 +1988,7 @@ func TestGetOrdersRequest_Filter(t *testing.T) {
request.Type = AnyType
request.Side = AnySide
var orders = []Detail{
orders := []Detail{
{OrderID: "0", Pair: btcusd, AssetType: asset.Spot, Type: Limit, Side: Buy},
{OrderID: "1", Pair: btcusd, AssetType: asset.Spot, Type: Limit, Side: Sell},
{OrderID: "2", Pair: btcusd, AssetType: asset.Spot, Type: Market, Side: Buy},