linter: Enable gofumpt and run against codebase (#1848)

* linter: Enable gofumpt and run against codebase

* Address shazbert's nits

* gofumpt: Fix issues after rebase
This commit is contained in:
Adrian Gallagher
2025-03-18 10:23:16 +11:00
committed by GitHub
parent 748ed71455
commit f5faca2eb2
189 changed files with 1541 additions and 1104 deletions

View File

@@ -114,9 +114,7 @@ const (
recvWindowSize5000 = 5000
)
var (
recvWindowSize5000String = strconv.Itoa(recvWindowSize5000)
)
var recvWindowSize5000String = strconv.Itoa(recvWindowSize5000)
// This is a list of error Messages to be returned by binanceus endpoint methods.
var (
@@ -1487,7 +1485,7 @@ func (bi *Binanceus) WithdrawCrypto(ctx context.Context, arg *withdraw.Request)
}
params.Set("amount", strconv.FormatFloat(arg.Amount, 'f', 0, 64))
var response WithdrawalResponse
var er = bi.SendAuthHTTPRequest(ctx,
er := bi.SendAuthHTTPRequest(ctx,
exchange.RestSpotSupplementary,
http.MethodPost, applyWithdrawal,
params, spotDefaultRate, &response)
@@ -1716,8 +1714,7 @@ func (bi *Binanceus) GetSubAccountDepositAddress(ctx context.Context, arg SubAcc
}
// GetSubAccountDepositHistory retrieves sub-account deposit history.
func (bi *Binanceus) GetSubAccountDepositHistory(ctx context.Context, email string, coin currency.Code,
status int, startTime, endTime time.Time, limit, offset int) ([]SubAccountDepositItem, error) {
func (bi *Binanceus) GetSubAccountDepositHistory(ctx context.Context, email string, coin currency.Code, status int, startTime, endTime time.Time, limit, offset int) ([]SubAccountDepositItem, error) {
params := url.Values{}
if !common.MatchesEmailPattern(email) {
return nil, errMissingSubAccountEmail
@@ -1807,7 +1804,8 @@ func (bi *Binanceus) SendAPIKeyHTTPRequest(ctx context.Context, ePath exchange.U
Result: result,
Verbose: bi.Verbose,
HTTPDebugging: bi.HTTPDebugging,
HTTPRecording: bi.HTTPRecording}
HTTPRecording: bi.HTTPRecording,
}
return bi.SendPayload(ctx, f, func() (*request.Item, error) {
return item, nil
@@ -1854,7 +1852,8 @@ func (bi *Binanceus) SendAuthHTTPRequest(ctx context.Context, ePath exchange.URL
Result: &interim,
Verbose: bi.Verbose,
HTTPDebugging: bi.HTTPDebugging,
HTTPRecording: bi.HTTPRecording}, nil
HTTPRecording: bi.HTTPRecording,
}, nil
}, request.AuthenticatedRequest)
if err != nil {
return err

View File

@@ -182,7 +182,7 @@ func TestGetFeeByType(t *testing.T) {
func TestSubmitOrder(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCannotManipulateOrders(t, bi, canManipulateRealOrders)
var orderSubmission = &order.Submit{
orderSubmission := &order.Submit{
Pair: currency.Pair{
Base: currency.XRP,
Quote: currency.USD,
@@ -226,7 +226,7 @@ func TestCancelOrder(t *testing.T) {
if err != nil && !(errors.Is(err, errEitherOrderIDOrClientOrderIDIsRequired) || strings.Contains(err.Error(), "ID not set")) {
t.Errorf("Binanceus CancelOrder() expecting %v, but found %v", errEitherOrderIDOrClientOrderIDIsRequired, err)
}
var cancellationOrder = &order.Cancel{
cancellationOrder := &order.Cancel{
OrderID: "1",
Pair: pair,
AssetType: asset.Spot,
@@ -240,7 +240,7 @@ func TestCancelOrder(t *testing.T) {
func TestCancelAllOrders(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi, canManipulateRealOrders)
var orderCancellation = &order.Cancel{
orderCancellation := &order.Cancel{
Pair: currency.NewPair(currency.LTC, currency.BTC),
AssetType: asset.Spot,
}
@@ -309,7 +309,7 @@ func TestWithdrawFiat(t *testing.T) {
func TestGetActiveOrders(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi)
var getOrdersRequest = order.MultiOrderRequest{
getOrdersRequest := order.MultiOrderRequest{
Type: order.AnyType,
AssetType: asset.Spot,
Side: order.AnySide,
@@ -349,7 +349,7 @@ func TestWithdraw(t *testing.T) {
func TestGetFee(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi)
var feeBuilder = &exchange.FeeBuilder{
feeBuilder := &exchange.FeeBuilder{
Amount: 1,
FeeType: exchange.CryptocurrencyTradeFee,
Pair: currency.NewPair(currency.BTC, currency.LTC),
@@ -359,7 +359,7 @@ func TestGetFee(t *testing.T) {
if er != nil {
t.Fatal("Binanceus GetFeeByType() error", er)
}
var withdrawalFeeBuilder = &exchange.FeeBuilder{
withdrawalFeeBuilder := &exchange.FeeBuilder{
Amount: 1,
FeeType: exchange.CryptocurrencyWithdrawalFee,
Pair: currency.NewPair(currency.BTC, currency.LTC),
@@ -369,7 +369,7 @@ func TestGetFee(t *testing.T) {
if er != nil {
t.Fatal("Binanceus GetFeeByType() error", er)
}
var offlineFeeTradeBuilder = &exchange.FeeBuilder{
offlineFeeTradeBuilder := &exchange.FeeBuilder{
Amount: 1,
FeeType: exchange.OfflineTradeFee,
Pair: currency.NewPair(currency.BTC, currency.LTC),
@@ -559,6 +559,7 @@ func TestGetUserAPITradingStatus(t *testing.T) {
t.Error("Binanceus GetUserAPITradingStatus() error", er)
}
}
func TestGetTradeFee(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi)
@@ -1222,6 +1223,7 @@ func TestDepositHistory(t *testing.T) {
t.Error("Binanceus DepositHistory() error", er)
}
}
func TestFiatDepositHistory(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi)
@@ -1540,7 +1542,7 @@ func TestWebsocketPartialOrderBookDepthStream(t *testing.T) {
func TestWebsocketBookTicker(t *testing.T) {
t.Parallel()
var bookTickerJSON = []byte(
bookTickerJSON := []byte(
`{
"stream": "btcusdt@bookTicker",
"data": {
@@ -1555,7 +1557,7 @@ func TestWebsocketBookTicker(t *testing.T) {
if err := bi.wsHandleData(bookTickerJSON); err != nil {
t.Error("Binanceus Book Ticker error", err)
}
var bookTickerForAllSymbols = []byte(`
bookTickerForAllSymbols := []byte(`
{
"stream" : "!bookTicker",
"data":{
@@ -1574,7 +1576,7 @@ func TestWebsocketBookTicker(t *testing.T) {
func TestWebsocketAggTrade(t *testing.T) {
t.Parallel()
var aggTradejson = []byte(
aggTradejson := []byte(
`{
"stream":"btcusdt@aggTrade",
"data": {
@@ -1785,6 +1787,7 @@ func TestQuickEnableCryptoWithdrawal(t *testing.T) {
t.Errorf("Binanceus QuickEnableCryptoWithdrawal() expecting %s, but found %v", "unexpected end of JSON input", er)
}
}
func TestQuickDisableCryptoWithdrawal(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, bi)

View File

@@ -541,7 +541,7 @@ func (bi *Binanceus) UpdateLocalBuffer(wsdp *WebsocketDepthStream) (bool, error)
// GenerateSubscriptions generates the default subscription set
func (bi *Binanceus) GenerateSubscriptions() (subscription.List, error) {
var channels = []string{"@ticker", "@trade", "@kline_1m", "@depth@100ms"}
channels := []string{"@ticker", "@trade", "@kline_1m", "@depth@100ms"}
var subscriptions subscription.List
pairs, err := bi.GetEnabledPairs(asset.Spot)