linter: Enable gofumpt and run against codebase (#1848)

* linter: Enable gofumpt and run against codebase

* Address shazbert's nits

* gofumpt: Fix issues after rebase
This commit is contained in:
Adrian Gallagher
2025-03-18 10:23:16 +11:00
committed by GitHub
parent 748ed71455
commit f5faca2eb2
189 changed files with 1541 additions and 1104 deletions

View File

@@ -486,7 +486,8 @@ func RPCTestSetup(t *testing.T) *Engine {
Enabled: currency.Pairs{cp},
AssetEnabled: true,
ConfigFormat: &currency.PairFormat{Uppercase: true},
RequestFormat: &currency.PairFormat{Uppercase: true}}
RequestFormat: &currency.PairFormat{Uppercase: true},
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -505,7 +506,8 @@ func RPCTestSetup(t *testing.T) *Engine {
Enabled: currency.Pairs{cp},
AssetEnabled: true,
ConfigFormat: &currency.PairFormat{Uppercase: true},
RequestFormat: &currency.PairFormat{Uppercase: true}}
RequestFormat: &currency.PairFormat{Uppercase: true},
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -1343,7 +1345,8 @@ func TestGetOrders(t *testing.T) {
Enabled: currency.Pairs{cp},
AssetEnabled: true,
ConfigFormat: &currency.PairFormat{Uppercase: true},
RequestFormat: &currency.PairFormat{Uppercase: true}}
RequestFormat: &currency.PairFormat{Uppercase: true},
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -1453,7 +1456,8 @@ func TestGetOrder(t *testing.T) {
Enabled: currency.Pairs{cp},
AssetEnabled: true,
ConfigFormat: &currency.PairFormat{Uppercase: true},
RequestFormat: &currency.PairFormat{Uppercase: true}}
RequestFormat: &currency.PairFormat{Uppercase: true},
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -1565,7 +1569,7 @@ func TestCheckVars(t *testing.T) {
err = checkParams("Binance", e, asset.Spot, currency.NewPair(currency.BTC, currency.USDT))
assert.ErrorIs(t, err, errCurrencyPairInvalid, "checkParams should error correctly")
var data = []currency.Pair{
data := []currency.Pair{
{Delimiter: currency.DashDelimiter, Base: currency.BTC, Quote: currency.USDT},
}
@@ -1584,7 +1588,7 @@ func TestCheckVars(t *testing.T) {
func TestParseEvents(t *testing.T) {
t.Parallel()
var exchangeName = "Binance"
exchangeName := "Binance"
testData := make([]*withdraw.Response, 5)
for x := range 5 {
test := fmt.Sprintf("test-%v", x)
@@ -1659,7 +1663,8 @@ func TestRPCServerUpsertDataHistoryJob(t *testing.T) {
b.CurrencyPairs.Pairs[asset.Spot] = &currency.PairStore{
Available: currency.Pairs{cp},
Enabled: currency.Pairs{cp},
AssetEnabled: true}
AssetEnabled: true,
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -1931,7 +1936,8 @@ func TestGetManagedOrders(t *testing.T) {
Enabled: currency.Pairs{cp},
AssetEnabled: true,
ConfigFormat: &currency.PairFormat{Uppercase: true},
RequestFormat: &currency.PairFormat{Uppercase: true}}
RequestFormat: &currency.PairFormat{Uppercase: true},
}
err = em.Add(exch)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
@@ -2161,7 +2167,8 @@ func TestCurrencyStateWithdraw(t *testing.T) {
Engine: &Engine{},
}).CurrencyStateWithdraw(context.Background(),
&gctrpc.CurrencyStateWithdrawRequest{
Exchange: "wow", Asset: "meow"})
Exchange: "wow", Asset: "meow",
})
if !errors.Is(err, asset.ErrNotSupported) {
t.Fatalf("received: %v, but expected: %v", err, asset.ErrNotSupported)
}
@@ -2170,7 +2177,8 @@ func TestCurrencyStateWithdraw(t *testing.T) {
Engine: &Engine{},
}).CurrencyStateWithdraw(context.Background(),
&gctrpc.CurrencyStateWithdrawRequest{
Exchange: "wow", Asset: "spot"})
Exchange: "wow", Asset: "spot",
})
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Fatalf("received: %v, but expected: %v", err, ErrSubSystemNotStarted)
}
@@ -2244,8 +2252,10 @@ func TestCurrencyStateTradingPair(t *testing.T) {
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
s := RPCServer{Engine: &Engine{ExchangeManager: em,
currencyStateManager: &CurrencyStateManager{started: 1, iExchangeManager: em}}}
s := RPCServer{Engine: &Engine{
ExchangeManager: em,
currencyStateManager: &CurrencyStateManager{started: 1, iExchangeManager: em},
}}
_, err = s.CurrencyStateTradingPair(context.Background(),
&gctrpc.CurrencyStateTradingPairRequest{