linter: Enable gofumpt and run against codebase (#1848)

* linter: Enable gofumpt and run against codebase

* Address shazbert's nits

* gofumpt: Fix issues after rebase
This commit is contained in:
Adrian Gallagher
2025-03-18 10:23:16 +11:00
committed by GitHub
parent 748ed71455
commit f5faca2eb2
189 changed files with 1541 additions and 1104 deletions

View File

@@ -6,8 +6,7 @@ import (
// Version0 is a baseline version with no changes, so we can downgrade back to nothing
// It does not implement any upgrade interfaces
type Version0 struct {
}
type Version0 struct{}
func init() {
Manager.registerVersion(0, &Version0{})

View File

@@ -10,8 +10,7 @@ import (
)
// Version1 is an ExchangeVersion to upgrade currency pair format for exchanges
type Version1 struct {
}
type Version1 struct{}
func init() {
Manager.registerVersion(1, &Version1{})

View File

@@ -16,8 +16,7 @@ var (
)
// Version4 is an Exchange upgrade to move currencyPairs.assetTypes to currencyPairs.pairs.*.assetEnabled
type Version4 struct {
}
type Version4 struct{}
func init() {
Manager.registerVersion(4, &Version4{})
@@ -40,7 +39,7 @@ func (v *Version4) UpgradeExchange(_ context.Context, e []byte) ([]byte, error)
return e, fmt.Errorf("%w: %w", errUpgradingAssetTypes, err)
}
assetEnabledFn := func(assetBytes []byte, v []byte, _ jsonparser.ValueType, _ int) (err error) {
assetEnabledFn := func(assetBytes, v []byte, _ jsonparser.ValueType, _ int) (err error) {
asset := string(assetBytes)
if toEnable[asset] {
e, err = jsonparser.Set(e, []byte(`true`), "currencyPairs", "pairs", asset, "assetEnabled")
@@ -70,7 +69,7 @@ func (v *Version4) UpgradeExchange(_ context.Context, e []byte) ([]byte, error)
func (v *Version4) DowngradeExchange(_ context.Context, e []byte) ([]byte, error) {
assetTypes := []string{}
assetEnabledFn := func(asset []byte, v []byte, _ jsonparser.ValueType, _ int) error {
assetEnabledFn := func(asset, v []byte, _ jsonparser.ValueType, _ int) error {
if b, err := jsonparser.GetBoolean(v, "assetEnabled"); err == nil {
if b {
assetTypes = append(assetTypes, fmt.Sprintf("%q", asset))

View File

@@ -81,7 +81,7 @@ func TestVersion4Downgrade(t *testing.T) {
require.Equal(t, jsonparser.Array, vT, "assetTypes must be an array")
require.Equal(t, `["spot","options_combo"]`, string(v), "assetTypes must be correct")
assetEnabledFn := func(k []byte, v []byte, _ jsonparser.ValueType, _ int) error {
assetEnabledFn := func(k, v []byte, _ jsonparser.ValueType, _ int) error {
_, err = jsonparser.GetBoolean(v, "assetEnabled")
require.ErrorIsf(t, err, jsonparser.KeyPathNotFoundError, "assetEnabled must be removed from %s", k)
return nil