(QOL) Improve test setup for logger, improve test coverage for database (#447)

* Improved test setup for logger, improved test coverage for database

* removed some new lines

* add new line

* removed database config detailS

* removed lines

* code cleanup

database/testhelpers/test_helpers.go

@@ -0,0 +1,100 @@
+package testhelpers
+
+import (
+	"os"
+	"reflect"
+
+	"github.com/thrasher-corp/gocryptotrader/database"
+	"github.com/thrasher-corp/gocryptotrader/database/drivers"
+	psqlConn "github.com/thrasher-corp/gocryptotrader/database/drivers/postgres"
+	sqliteConn "github.com/thrasher-corp/gocryptotrader/database/drivers/sqlite3"
+)
+
+var (
+	// TempDir temp folder for sqlite database
+	TempDir string
+	// PostgresTestDatabase postgresql database config details
+	PostgresTestDatabase *database.Config
+)
+
+// GetConnectionDetails returns connection details for CI or test db instances
+func GetConnectionDetails() *database.Config {
+	_, exists := os.LookupEnv("TRAVIS")
+	if exists {
+		return &database.Config{
+			Enabled: true,
+			Driver:  "postgres",
+			ConnectionDetails: drivers.ConnectionDetails{
+				Host:     "localhost",
+				Port:     5432,
+				Username: "postgres",
+				Password: "",
+				Database: "gct_dev_ci",
+				SSLMode:  "",
+			},
+		}
+	}
+
+	_, exists = os.LookupEnv("APPVEYOR")
+	if exists {
+		return &database.Config{
+			Enabled: true,
+			Driver:  "postgres",
+			ConnectionDetails: drivers.ConnectionDetails{
+				Host:     "localhost",
+				Port:     5432,
+				Username: "postgres",
+				Password: "Password12!",
+				Database: "gct_dev_ci",
+				SSLMode:  "",
+			},
+		}
+	}
+
+	return &database.Config{
+		Enabled:           true,
+		Driver:            "postgres",
+		ConnectionDetails: drivers.ConnectionDetails{
+			// Host:     "",
+			// Port:     5432,
+			// Username: "",
+			// Password: "",
+			// Database: "",
+			// SSLMode:  "",
+		},
+	}
+}
+
+// ConnectToDatabase opens connection to database and returns pointer to instance of database.DB
+func ConnectToDatabase(conn *database.Config) (dbConn *database.Db, err error) {
+	database.DB.Config = conn
+
+	if conn.Driver == database.DBPostgreSQL {
+		dbConn, err = psqlConn.Connect()
+		if err != nil {
+			return nil, err
+		}
+	} else if conn.Driver == database.DBSQLite3 || conn.Driver == database.DBSQLite {
+		database.DB.DataPath = TempDir
+		dbConn, err = sqliteConn.Connect()
+
+		if err != nil {
+			return nil, err
+		}
+	}
+	database.DB.Connected = true
+	return
+}
+
+// CloseDatabase closes database connection
+func CloseDatabase(conn *database.Db) (err error) {
+	if conn != nil {
+		return conn.SQL.Close()
+	}
+	return nil
+}
+
+// CheckValidConfig checks if database connection details are empty
+func CheckValidConfig(config *drivers.ConnectionDetails) bool {
+	return !reflect.DeepEqual(drivers.ConnectionDetails{}, *config)
+}

database/testhelpers/test_helpers_test.go

@@ -0,0 +1,94 @@
+package testhelpers
+
+import (
+	"fmt"
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/thrasher-corp/gocryptotrader/database"
+	"github.com/thrasher-corp/gocryptotrader/database/drivers"
+)
+
+func TestMain(m *testing.M) {
+	var err error
+	PostgresTestDatabase = GetConnectionDetails()
+	TempDir, err = ioutil.TempDir("", "gct-temp")
+	if err != nil {
+		fmt.Printf("failed to create temp file: %v", err)
+		os.Exit(1)
+	}
+
+	t := m.Run()
+
+	err = os.RemoveAll(TempDir)
+	if err != nil {
+		fmt.Printf("Failed to remove temp db file: %v", err)
+	}
+
+	os.Exit(t)
+}
+
+func TestDatabaseConnect(t *testing.T) {
+	testCases := []struct {
+		name   string
+		config *database.Config
+		closer func(dbConn *database.Db) error
+		output interface{}
+	}{
+		{
+			"SQLite",
+			&database.Config{
+				Driver:            database.DBSQLite3,
+				ConnectionDetails: drivers.ConnectionDetails{Database: "./testdb.db"},
+			},
+			CloseDatabase,
+			nil,
+		},
+		{
+			"SQliteNoDatabase",
+			&database.Config{
+				Driver: database.DBSQLite3,
+				ConnectionDetails: drivers.ConnectionDetails{
+					Host: "localhost",
+				},
+			},
+			nil,
+			database.ErrNoDatabaseProvided,
+		},
+		{
+			name:   "Postgres",
+			config: PostgresTestDatabase,
+			output: nil,
+		},
+	}
+
+	for _, tests := range testCases {
+		test := tests
+		t.Run(test.name, func(t *testing.T) {
+			if !CheckValidConfig(&test.config.ConnectionDetails) {
+				t.Skip("database not configured skipping test")
+			}
+
+			dbConn, err := ConnectToDatabase(test.config)
+			if err != nil {
+				switch v := test.output.(type) {
+				case error:
+					if v.Error() != err.Error() {
+						t.Fatal(err)
+					}
+					return
+				default:
+					break
+				}
+			}
+
+			if test.closer != nil {
+				err = test.closer(dbConn)
+				if err != nil {
+					t.Log(err)
+				}
+			}
+		})
+	}
+}