golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space

log/logger.go

@@ -19,8 +19,7 @@ func NewSubLogger(name string) (*SubLogger, error) {
 		return nil, errEmptyLoggerName
 	}
 	name = strings.ToUpper(name)
-	_, ok := subLoggers[name]
-	if ok {
+	if _, ok := subLoggers[name]; ok {
 		return nil, errSubLoggerAlreadyregistered
 	}
 	return registerNewSubLogger(name), nil
@@ -43,7 +42,10 @@ func (l *Logger) newLogEvent(data, header, slName string, w io.Writer) error {
 		return errors.New("io.Writer not set")
 	}
 
-	e := eventPool.Get().(*Event)
+	e, ok := eventPool.Get().(*Event)
+	if !ok {
+		return errors.New("unable to type asset event")
+	}
 	e.output = w
 	e.data = append(e.data, []byte(header)...)
 	if l.ShowLogSystemName {

log/logger_setup.go

@@ -12,7 +12,7 @@ import (
 
 func getWriters(s *SubLoggerConfig) io.Writer {
 	mw := MultiWriter()
-	m := mw.(*multiWriter)
+	m := mw.(*multiWriter) // nolint // type assert not required
 
 	outputWriters := strings.Split(s.Output, "|")
 	for x := range outputWriters {

log/logger_test.go

@@ -68,27 +68,26 @@ func BenchmarkInfo(b *testing.B) {
 }
 
 func SetupTestDisabled(t *testing.T) {
+	t.Helper()
 	SetupDisabled()
 }
 
 func TestAddWriter(t *testing.T) {
 	mw := MultiWriter()
-	m := mw.(*multiWriter)
+	m := mw.(*multiWriter) // nolint // type assert not required
 
 	m.Add(ioutil.Discard)
 	m.Add(os.Stdin)
 	m.Add(os.Stdout)
 
-	total := len(m.writers)
-
-	if total != 3 {
+	if total := len(m.writers); total != 3 {
 		t.Errorf("expected m.Writers to be 3 %v", total)
 	}
 }
 
 func TestRemoveWriter(t *testing.T) {
 	mw := MultiWriter()
-	m := mw.(*multiWriter)
+	m := mw.(*multiWriter) // nolint // type assert not required
 
 	m.Add(ioutil.Discard)
 	m.Add(os.Stdin)
@@ -148,8 +147,7 @@ func TestValidSubLogger(t *testing.T) {
 }
 
 func TestCloseLogger(t *testing.T) {
-	err := CloseLogger()
-	if err != nil {
+	if err := CloseLogger(); err != nil {
 		t.Errorf("CloseLogger() failed %v", err)
 	}
 }