d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

golangci-lint/CI: Bump versions and introduce new linters (#798)

Browse Source 
* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gctscript/modules/ta/indicators/atr.go
View File

@@ -48,7 +48,13 @@ func atr(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 6 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[2])
if err != nil {
allErrors = append(allErrors, err.Error())

9
gctscript/modules/ta/indicators/bbands.go
View File

@@ -61,7 +61,14 @@ func bbands(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
var t []interface{}
t, ok = ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 6 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[2])
if err != nil {
allErrors = append(allErrors, err.Error())

8
gctscript/modules/ta/indicators/correlation.go
View File

@@ -50,7 +50,13 @@ func correlationCoefficient(args ...objects.Object) (objects.Object, error) {
var ohlcvClose []float64
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[4])
if err != nil {
allErrors = append(allErrors, err.Error())

8
gctscript/modules/ta/indicators/ema.go
View File

@@ -49,7 +49,13 @@ func ema(args ...objects.Object) (objects.Object, error) {
var ohlcvClose []float64
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[4])
if err != nil {

8
gctscript/modules/ta/indicators/macd.go
View File

@@ -50,7 +50,13 @@ func macd(args ...objects.Object) (objects.Object, error) {
var ohlcvClose []float64
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[4])
if err != nil {
allErrors = append(allErrors, err.Error())

8
gctscript/modules/ta/indicators/mfi.go
View File

@@ -49,7 +49,13 @@ func mfi(args ...objects.Object) (objects.Object, error) {
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 6 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[2])
if err != nil {
allErrors = append(allErrors, err.Error())

8
gctscript/modules/ta/indicators/obv.go
View File

@@ -48,7 +48,13 @@ func obv(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 6 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[2])
if err != nil {
allErrors = append(allErrors, err.Error())

8
gctscript/modules/ta/indicators/rsi.go
View File

@@ -49,7 +49,13 @@ func rsi(args ...objects.Object) (objects.Object, error) {
var ohlcvClose []float64
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[4])
if err != nil {

8
gctscript/modules/ta/indicators/sma.go
View File

@@ -49,7 +49,13 @@ func sma(args ...objects.Object) (objects.Object, error) {
var ohlcvClose []float64
var allErrors []string
for x := range ohlcvInputData {
t := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]interface{})
if !ok {
return nil, errors.New("unable to type assert ohlcvInputData")
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")
}
value, err := toFloat64(t[4])
if err != nil {
allErrors = append(allErrors, err.Error())

3
gctscript/vm/manager.go
View File

@@ -73,8 +73,7 @@ func (g *GctScriptManager) Stop() error {
atomic.CompareAndSwapInt32(&g.started, 1, 0)
}()
err := g.ShutdownAll()
if err != nil {
if err := g.ShutdownAll(); err != nil {
return err
}
close(g.shutdown)

1
gctscript/vm/manager_test.go
View File

@@ -37,6 +37,7 @@ func TestNewManager(t *testing.T) {
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
got, err := NewManager(tt.args.config)
if (err != nil) != tt.wantErr {
t.Errorf("NewManager() error = %v, wantErr %v", err, tt.wantErr)

5
gctscript/vm/vm_test.go
View File

@@ -279,7 +279,7 @@ func TestVMWithRunnerOnce(t *testing.T) {
config: configHelper(true, true, maxTestVirtualMachines),
started: 1,
}
vmCount := VMSCount.Len()
vmCount := VMSCount.Len() // nolint:ifshort,nolintlint // false positive and triggers only on Windows
VM := manager.New()
if VM == nil {
t.Fatal("Failed to allocate new VM exiting")
@@ -533,8 +533,7 @@ func TestVMLimit(t *testing.T) {
config: configHelper(true, false, 0),
started: 1,
}
testVM := manager.New()
if testVM != nil {
if testVM := manager.New(); testVM != nil {
t.Fatal("expected nil but received pointer to VM")
}
}

9
gctscript/wrappers/gct/exchange/exchange_test.go
View File

@@ -47,8 +47,7 @@ var (
func TestMain(m *testing.M) {
var t int
err := setupEngine()
if err != nil {
if err := setupEngine(); err != nil {
fmt.Printf("Failed to configure exchange test cannot continue: %v", err)
os.Exit(1)
}
@@ -59,10 +58,8 @@ func TestMain(m *testing.M) {
func TestExchange_Exchanges(t *testing.T) {
t.Parallel()
x := exchangeTest.Exchanges(false)
y := len(x)
if y != 1 {
t.Fatalf("expected 1 received %v", y)
if x := exchangeTest.Exchanges(false); len(x) != 1 {
t.Fatalf("expected 1 received %v", x)
}
}