golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space

exchanges/stream/websocket_test.go

@@ -167,8 +167,7 @@ func TestSetup(t *testing.T) {
 func TestTrafficMonitorTimeout(t *testing.T) {
 	t.Parallel()
 	ws := *New()
-	err := ws.Setup(defaultSetup)
-	if err != nil {
+	if err := ws.Setup(defaultSetup); err != nil {
 		t.Fatal(err)
 	}
 	ws.trafficTimeout = time.Second * 2
@@ -650,6 +649,7 @@ func TestDial(t *testing.T) {
 	for i := range testCases {
 		testData := &testCases[i]
 		t.Run(testData.WC.ExchangeName, func(t *testing.T) {
+			t.Parallel()
 			if testData.WC.ProxyURL != "" && !useProxyTests {
 				t.Skip("Proxy testing not enabled, skipping")
 			}
@@ -697,6 +697,7 @@ func TestSendMessage(t *testing.T) {
 	for i := range testCases {
 		testData := &testCases[i]
 		t.Run(testData.WC.ExchangeName, func(t *testing.T) {
+			t.Parallel()
 			if testData.WC.ProxyURL != "" && !useProxyTests {
 				t.Skip("Proxy testing not enabled, skipping")
 			}
@@ -737,7 +738,7 @@ func TestSendMessageWithResponse(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	go readMessages(wc, t)
+	go readMessages(t, wc)
 
 	request := testRequest{
 		Event: "subscribe",
@@ -755,7 +756,8 @@ func TestSendMessageWithResponse(t *testing.T) {
 }
 
 // readMessages helper func
-func readMessages(wc *WebsocketConnection, t *testing.T) {
+func readMessages(t *testing.T, wc *WebsocketConnection) {
+	t.Helper()
 	timer := time.NewTimer(20 * time.Second)
 	for {
 		select {