d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-02 15:10:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

golangci-lint/CI: Bump versions and introduce new linters (#798)

Browse Source 
* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
exchanges/okgroup/okgroup.go
View File

@@ -546,11 +546,11 @@ func FormatParameters(request interface{}) (parameters string) {
func (o *OKGroup) GetErrorCode(code interface{}) error {
var assertedCode string
switch reflect.TypeOf(code).String() {
case "float64":
assertedCode = strconv.FormatFloat(code.(float64), 'f', -1, 64)
case "string":
assertedCode = code.(string)
switch d := code.(type) {
case float64:
assertedCode = strconv.FormatFloat(d, 'f', -1, 64)
case string:
assertedCode = d
default:
return errors.New("unusual type returned")
}

66
exchanges/okgroup/okgroup_wrapper.go
View File

@@ -276,8 +276,7 @@ func (o *OKGroup) GetFundingHistory(ctx context.Context) (resp []exchange.FundHi
// SubmitOrder submits a new order
func (o *OKGroup) SubmitOrder(ctx context.Context, s *order.Submit) (order.SubmitResponse, error) {
err := s.Validate()
if err != nil {
if err := s.Validate(); err != nil {
return order.SubmitResponse{}, err
}
@@ -625,37 +624,34 @@ func (o *OKGroup) GetHistoricCandles(ctx context.Context, pair currency.Pair, a
}
for x := range candles {
t := candles[x].([]interface{})
tempCandle := kline.Candle{}
t, ok := candles[x].([]interface{})
if !ok {
return kline.Item{}, errors.New("unable to type asset candle data")
}
if len(t) < 6 {
return kline.Item{}, errors.New("incorrect candles data length")
}
v, ok := t[0].(string)
if !ok {
return kline.Item{}, errors.New("unexpected value received")
return kline.Item{}, errors.New("unable to type asset time data")
}
tempCandle.Time, err = time.Parse(time.RFC3339, v)
if err != nil {
var tempCandle kline.Candle
if tempCandle.Time, err = time.Parse(time.RFC3339, v); err != nil {
return kline.Item{}, err
}
tempCandle.Open, err = convert.FloatFromString(t[1])
if err != nil {
if tempCandle.Open, err = convert.FloatFromString(t[1]); err != nil {
return kline.Item{}, err
}
tempCandle.High, err = convert.FloatFromString(t[2])
if err != nil {
if tempCandle.High, err = convert.FloatFromString(t[2]); err != nil {
return kline.Item{}, err
}
tempCandle.Low, err = convert.FloatFromString(t[3])
if err != nil {
if tempCandle.Low, err = convert.FloatFromString(t[3]); err != nil {
return kline.Item{}, err
}
tempCandle.Close, err = convert.FloatFromString(t[4])
if err != nil {
if tempCandle.Close, err = convert.FloatFromString(t[4]); err != nil {
return kline.Item{}, err
}
tempCandle.Volume, err = convert.FloatFromString(t[5])
if err != nil {
if tempCandle.Volume, err = convert.FloatFromString(t[5]); err != nil {
return kline.Item{}, err
}
ret.Candles = append(ret.Candles, tempCandle)
@@ -703,37 +699,37 @@ func (o *OKGroup) GetHistoricCandlesExtended(ctx context.Context, pair currency.
}
for i := range candles {
t := candles[i].([]interface{})
tempCandle := kline.Candle{}
t, ok := candles[i].([]interface{})
if !ok {
return kline.Item{}, errors.New("unable to type assert candles data")
}
if len(t) < 6 {
return kline.Item{}, errors.New("candle data length invalid")
}
v, ok := t[0].(string)
if !ok {
return kline.Item{}, errors.New("unexpected value received")
return kline.Item{}, errors.New("unable to type assert time value")
}
tempCandle.Time, err = time.Parse(time.RFC3339, v)
if err != nil {
var tempCandle kline.Candle
if tempCandle.Time, err = time.Parse(time.RFC3339, v); err != nil {
return kline.Item{}, err
}
tempCandle.Open, err = convert.FloatFromString(t[1])
if err != nil {
if tempCandle.Open, err = convert.FloatFromString(t[1]); err != nil {
return kline.Item{}, err
}
tempCandle.High, err = convert.FloatFromString(t[2])
if err != nil {
if tempCandle.High, err = convert.FloatFromString(t[2]); err != nil {
return kline.Item{}, err
}
tempCandle.Low, err = convert.FloatFromString(t[3])
if err != nil {
if tempCandle.Low, err = convert.FloatFromString(t[3]); err != nil {
return kline.Item{}, err
}
tempCandle.Close, err = convert.FloatFromString(t[4])
if err != nil {
if tempCandle.Close, err = convert.FloatFromString(t[4]); err != nil {
return kline.Item{}, err
}
tempCandle.Volume, err = convert.FloatFromString(t[5])
if err != nil {
if tempCandle.Volume, err = convert.FloatFromString(t[5]); err != nil {
return kline.Item{}, err
}
ret.Candles = append(ret.Candles, tempCandle)