golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions

View File

@@ -8,9 +8,7 @@ import (
func TestGet(t *testing.T) {
var nonce Nonce
nonce.Set(112321313)
expected := Value(112321313)
result := nonce.Get()
if expected != result {
if expected, result := Value(112321313), nonce.Get(); expected != result {
t.Errorf("Expected %d got %d", expected, result)
}
}
@@ -18,9 +16,7 @@ func TestGet(t *testing.T) {
func TestGetInc(t *testing.T) {
var nonce Nonce
nonce.Set(1)
expected := Value(2)
result := nonce.GetInc()
if expected != result {
if expected, result := Value(2), nonce.GetInc(); expected != result {
t.Errorf("Expected %d got %d", expected, result)
}
}
@@ -28,9 +24,7 @@ func TestGetInc(t *testing.T) {
func TestSet(t *testing.T) {
var nonce Nonce
nonce.Set(1)
expected := Value(1)
result := nonce.Get()
if expected != result {
if result, expected := nonce.Get(), Value(1); expected != result {
t.Errorf("Expected %d got %d", expected, result)
}
}
@@ -62,9 +56,7 @@ func TestNonceConcurrency(t *testing.T) {
wg.Wait()
result := nonce.Get()
expected := Value(12312 + 1000)
if expected != result {
if expected, result := Value(12312+1000), nonce.Get(); expected != result {
t.Errorf("Expected %d got %d", expected, result)
}
}