golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions

View File

@@ -1151,7 +1151,7 @@ func (f *FTX) SendAuthHTTPRequest(ctx context.Context, ep exchange.URL, method,
}
newRequest := func() (*request.Item, error) {
ts := strconv.FormatInt(time.Now().UnixNano()/1000000, 10)
ts := strconv.FormatInt(time.Now().UnixMilli(), 10)
var body io.Reader
var hmac, payload []byte

View File

@@ -1364,7 +1364,7 @@ func TestCompatibleOrderVars(t *testing.T) {
t.Errorf("received %v expected %v", orderVars.Status, order.Filled)
}
orderVars, err = f.compatibleOrderVars(context.Background(),
_, err = f.compatibleOrderVars(context.Background(),
"buy",
"closed",
"limit",
@@ -1375,7 +1375,7 @@ func TestCompatibleOrderVars(t *testing.T) {
t.Errorf("received %v expected %v", err, errInvalidOrderAmounts)
}
orderVars, err = f.compatibleOrderVars(context.Background(),
_, err = f.compatibleOrderVars(context.Background(),
"buy",
"fake",
"limit",

View File

@@ -77,7 +77,7 @@ func (f *FTX) WsConnect() error {
// WsAuth sends an authentication message to receive auth data
func (f *FTX) WsAuth() error {
intNonce := time.Now().UnixNano() / 1000000
intNonce := time.Now().UnixMilli()
strNonce := strconv.FormatInt(intNonce, 10)
hmac, err := crypto.GetHMAC(
crypto.HashSHA256,

View File

@@ -251,8 +251,7 @@ func TestParsingOrders(t *testing.T) {
},
"type": "update"
}`)
err := f.wsHandleData(data)
if err != nil {
if err := f.wsHandleData(data); err != nil {
t.Error(err)
}
}
@@ -274,8 +273,7 @@ func TestParsingWSTradesData(t *testing.T) {
}
]
}`)
err := f.wsHandleData(data)
if err != nil {
if err := f.wsHandleData(data); err != nil {
t.Error(err)
}
}
@@ -295,8 +293,7 @@ func TestParsingWSTickerData(t *testing.T) {
"time": 1589505004.4237103
}
}`)
err := f.wsHandleData(data)
if err != nil {
if err := f.wsHandleData(data); err != nil {
t.Error(err)
}
}
@@ -323,8 +320,7 @@ func TestParsingWSOrdersData(t *testing.T) {
},
"type": "update"
}`)
err := f.wsHandleData(data)
if err != nil {
if err := f.wsHandleData(data); err != nil {
t.Error(err)
}
}
@@ -360,8 +356,7 @@ func TestParsingMarketsData(t *testing.T) {
"group": "quarterly"}}},
"action": "partial"
}`)
err := f.wsHandleData(data)
if err != nil {
if err := f.wsHandleData(data); err != nil {
t.Error(err)
}
}