d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-07 15:11:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

golangci-lint/CI: Bump versions and introduce new linters (#798)

Browse Source 
* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
exchanges/coinbene/coinbene_websocket.go
View File

@@ -443,8 +443,7 @@ func (c *Coinbene) getCurrencyFromWsTopic(assetType asset.Item, channelTopic str
// Subscribe sends a websocket message to receive data from the channel
func (c *Coinbene) Subscribe(channelsToSubscribe []stream.ChannelSubscription) error {
maxSubsPerHour := 240
if len(channelsToSubscribe) > maxSubsPerHour {
if maxSubsPerHour := 240; len(channelsToSubscribe) > maxSubsPerHour {
return fmt.Errorf("channel subscriptions length %d exceeds coinbene's limit of %d, try reducing enabled pairs",
len(channelsToSubscribe),
maxSubsPerHour)

13
exchanges/coinbene/coinbene_wrapper.go
View File

@@ -382,8 +382,7 @@ func (c *Coinbene) UpdateTickers(ctx context.Context, a asset.Item) error {
// UpdateTicker updates and returns the ticker for a currency pair
func (c *Coinbene) UpdateTicker(ctx context.Context, p currency.Pair, a asset.Item) (*ticker.Price, error) {
err := c.UpdateTickers(ctx, a)
if err != nil {
if err := c.UpdateTickers(ctx, a); err != nil {
return nil, err
}
return ticker.GetTicker(c.Name, p, a)
@@ -893,11 +892,17 @@ func (c *Coinbene) GetHistoricCandles(ctx context.Context, pair currency.Pair, a
}
for x := range candles.Data {
if len(candles.Data[x]) < 6 {
return kline.Item{}, errors.New("unexpected candle data length")
}
var tempCandle kline.Candle
tempTime := candles.Data[x][0].(string)
tempTime, ok := candles.Data[x][0].(string)
if !ok {
return kline.Item{}, errors.New("timestamp conversion failed")
}
timestamp, err := time.Parse(time.RFC3339, tempTime)
if err != nil {
continue
return kline.Item{}, err
}
tempCandle.Time = timestamp
open, ok := candles.Data[x][1].(string)