golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions

View File

@@ -34,8 +34,7 @@ func promptForConfigEncryption() (bool, error) {
log.Println("Would you like to encrypt your config file (y/n)?")
input := ""
_, err := fmt.Scanln(&input)
if err != nil {
if _, err := fmt.Scanln(&input); err != nil {
return false, err
}
@@ -194,8 +193,7 @@ func ConfirmECS(file []byte) bool {
// or errors, if the prefix wasn't found
func skipECS(file io.Reader) error {
buf := make([]byte, len(EncryptConfirmString))
_, err := io.ReadFull(file, buf)
if err != nil {
if _, err := io.ReadFull(file, buf); err != nil {
return err
}
if string(buf) != EncryptConfirmString {