mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-06-07 15:11:03 +00:00
golangci-lint/CI: Bump versions and introduce new linters (#798)
* golangci-lint/CI: Bump versions
Fix remaining linter issues
* Specifically set AppVeyor version
* Fix the infamous typos 👀
* Add go env cmd to AppVeyor
* Add go version cmd to AppVeyor
* Specify AppVeyor image, adjust linters
* Update go get to go install due to deprecation
* Bump golangci-lint timeout time for AppVeyor
* Change NW contract to NQ
* Address nitters
* GetRandomPair -> Pair{}
* Address nits
* Address time nitterinos plus additional tweaks
* More time inception upgrades!
* Bending time and space
This commit is contained in:
@@ -248,15 +248,13 @@ func TestStringDataContains(t *testing.T) {
|
||||
originalHaystack := []string{"hello", "world", "USDT", "Contains", "string"}
|
||||
originalNeedle := "USD"
|
||||
anotherNeedle := "thing"
|
||||
expectedOutput := true
|
||||
expectedOutputTwo := false
|
||||
actualResult := StringDataContains(originalHaystack, originalNeedle)
|
||||
if actualResult != expectedOutput {
|
||||
if expectedOutput := true; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
actualResult = StringDataContains(originalHaystack, anotherNeedle)
|
||||
if actualResult != expectedOutputTwo {
|
||||
if expectedOutput := false; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
@@ -267,15 +265,13 @@ func TestStringDataCompare(t *testing.T) {
|
||||
originalHaystack := []string{"hello", "WoRld", "USDT", "Contains", "string"}
|
||||
originalNeedle := "WoRld"
|
||||
anotherNeedle := "USD"
|
||||
expectedOutput := true
|
||||
expectedOutputTwo := false
|
||||
actualResult := StringDataCompare(originalHaystack, originalNeedle)
|
||||
if actualResult != expectedOutput {
|
||||
if expectedOutput := true; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
actualResult = StringDataCompare(originalHaystack, anotherNeedle)
|
||||
if actualResult != expectedOutputTwo {
|
||||
if expectedOutput := false; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
@@ -286,16 +282,14 @@ func TestStringDataCompareUpper(t *testing.T) {
|
||||
originalHaystack := []string{"hello", "WoRld", "USDT", "Contains", "string"}
|
||||
originalNeedle := "WoRld"
|
||||
anotherNeedle := "WoRldD"
|
||||
expectedOutput := true
|
||||
expectedOutputTwo := false
|
||||
actualResult := StringDataCompareInsensitive(originalHaystack, originalNeedle)
|
||||
if actualResult != expectedOutput {
|
||||
if expectedOutput := true; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
|
||||
actualResult = StringDataCompareInsensitive(originalHaystack, anotherNeedle)
|
||||
if actualResult != expectedOutputTwo {
|
||||
if expectedOutput := false; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
@@ -306,15 +300,13 @@ func TestStringDataContainsUpper(t *testing.T) {
|
||||
originalHaystack := []string{"bLa", "BrO", "sUp"}
|
||||
originalNeedle := "Bla"
|
||||
anotherNeedle := "ning"
|
||||
expectedOutput := true
|
||||
expectedOutputTwo := false
|
||||
actualResult := StringDataContainsInsensitive(originalHaystack, originalNeedle)
|
||||
if actualResult != expectedOutput {
|
||||
if expectedOutput := true; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
actualResult = StringDataContainsInsensitive(originalHaystack, anotherNeedle)
|
||||
if actualResult != expectedOutputTwo {
|
||||
if expectedOutput := false; actualResult != expectedOutput {
|
||||
t.Errorf("Expected '%v'. Actual '%v'",
|
||||
expectedOutput, actualResult)
|
||||
}
|
||||
@@ -410,8 +402,7 @@ func TestGetURIPath(t *testing.T) {
|
||||
|
||||
func TestGetExecutablePath(t *testing.T) {
|
||||
t.Parallel()
|
||||
_, err := GetExecutablePath()
|
||||
if err != nil {
|
||||
if _, err := GetExecutablePath(); err != nil {
|
||||
t.Errorf("Common GetExecutablePath. Error: %s", err)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user