golangci-lint/CI: Bump versions and introduce new linters (#798)

* golangci-lint/CI: Bump versions

Fix remaining linter issues

* Specifically set AppVeyor version

* Fix the infamous typos 👀

* Add go env cmd to AppVeyor

* Add go version cmd to AppVeyor

* Specify AppVeyor image, adjust linters

* Update go get to go install due to deprecation

* Bump golangci-lint timeout time for AppVeyor

* Change NW contract to NQ

* Address nitters

* GetRandomPair -> Pair{}

* Address nits

* Address time nitterinos plus additional tweaks

* More time inception upgrades!

* Bending time and space
This commit is contained in:
Adrian Gallagher
2021-10-14 16:38:53 +11:00
committed by GitHub
parent 0a91af0f2e
commit f0d45aa1d2
194 changed files with 1506 additions and 1233 deletions

View File

@@ -130,16 +130,14 @@ func TestRemove(t *testing.T) {
func TestGetNewest(t *testing.T) {
lruCache := New(2)
k, _ := lruCache.getNewest()
if k != nil {
if k, _ := lruCache.getNewest(); k != nil {
t.Fatal("expected GetNewest() on empty cache to return nil")
}
}
func TestGetOldest(t *testing.T) {
lruCache := New(2)
k, _ := lruCache.getOldest()
if k != nil {
if k, _ := lruCache.getOldest(); k != nil {
t.Fatal("expected GetOldest() on empty cache to return nil")
}
}

9
common/cache/lru.go vendored
View File

@@ -47,8 +47,7 @@ func (l *LRU) Get(key interface{}) interface{} {
// GetOldest returns the oldest entry
func (l *LRU) getOldest() (key, value interface{}) {
x := l.l.Back()
if x != nil {
if x := l.l.Back(); x != nil {
return x.Value.(*item).key, x.Value.(*item).value
}
return
@@ -56,8 +55,7 @@ func (l *LRU) getOldest() (key, value interface{}) {
// GetNewest returns the newest entry
func (l *LRU) getNewest() (key, value interface{}) {
x := l.l.Front()
if x != nil {
if x := l.l.Front(); x != nil {
return x.Value.(*item).key, x.Value.(*item).value
}
return
@@ -93,8 +91,7 @@ func (l *LRU) Len() uint64 {
// removeOldest removes the oldest item from the cache.
func (l *LRU) removeOldestEntry() {
i := l.l.Back()
if i != nil {
if i := l.l.Back(); i != nil {
l.removeElement(i)
}
}