d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-05 15:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rangeValCopy linter issues (#275)

Browse Source 
* first pass of linter fixes for range val

* fixed the remaining issues for pointers

* changed as requested
This commit is contained in:
Adam
2019-04-10 17:04:32 +10:00
committed by Adrian Gallagher
parent e56fc26d93
commit d69713f59d
29 changed files with 563 additions and 557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
exchanges/itbit/itbit_wrapper.go
View File

@@ -252,10 +252,10 @@ func (i *ItBit) CancelAllOrders(orderCancellation *exchange.OrderCancellation) (
return cancelAllOrdersResponse, err
}
for _, openOrder := range openOrders {
err = i.CancelExistingOrder(orderCancellation.WalletAddress, openOrder.ID)
for j := range openOrders {
err = i.CancelExistingOrder(orderCancellation.WalletAddress, openOrders[j].ID)
if err != nil {
cancelAllOrdersResponse.OrderStatus[openOrder.ID] = err.Error()
cancelAllOrdersResponse.OrderStatus[openOrders[j].ID] = err.Error()
}
}
@@ -325,22 +325,22 @@ func (i *ItBit) GetActiveOrders(getOrdersRequest *exchange.GetOrdersRequest) ([]
}
var orders []exchange.OrderDetail
for _, order := range allOrders {
symbol := currency.NewPairDelimiter(order.Instrument,
for j := range allOrders {
symbol := currency.NewPairDelimiter(allOrders[j].Instrument,
i.ConfigCurrencyPairFormat.Delimiter)
side := exchange.OrderSide(strings.ToUpper(order.Side))
orderDate, err := time.Parse(time.RFC3339, order.CreatedTime)
side := exchange.OrderSide(strings.ToUpper(allOrders[j].Side))
orderDate, err := time.Parse(time.RFC3339, allOrders[j].CreatedTime)
if err != nil {
log.Warnf("Exchange %v Func %v Order %v Could not parse date to unix with value of %v",
i.Name, "GetActiveOrders", order.ID, order.CreatedTime)
i.Name, "GetActiveOrders", allOrders[j].ID, allOrders[j].CreatedTime)
}
orders = append(orders, exchange.OrderDetail{
ID: order.ID,
ID: allOrders[j].ID,
OrderSide: side,
Amount: order.Amount,
ExecutedAmount: order.AmountFilled,
RemainingAmount: (order.Amount - order.AmountFilled),
Amount: allOrders[j].Amount,
ExecutedAmount: allOrders[j].AmountFilled,
RemainingAmount: (allOrders[j].Amount - allOrders[j].AmountFilled),
Exchange: i.Name,
OrderDate: orderDate,
CurrencyPair: symbol,
@@ -373,26 +373,26 @@ func (i *ItBit) GetOrderHistory(getOrdersRequest *exchange.GetOrdersRequest) ([]
}
var orders []exchange.OrderDetail
for _, order := range allOrders {
if order.Type == "open" {
for j := range allOrders {
if allOrders[j].Type == "open" {
continue
}
symbol := currency.NewPairDelimiter(order.Instrument,
symbol := currency.NewPairDelimiter(allOrders[j].Instrument,
i.ConfigCurrencyPairFormat.Delimiter)
side := exchange.OrderSide(strings.ToUpper(order.Side))
orderDate, err := time.Parse(time.RFC3339, order.CreatedTime)
side := exchange.OrderSide(strings.ToUpper(allOrders[j].Side))
orderDate, err := time.Parse(time.RFC3339, allOrders[j].CreatedTime)
if err != nil {
log.Warnf("Exchange %v Func %v Order %v Could not parse date to unix with value of %v",
i.Name, "GetActiveOrders", order.ID, order.CreatedTime)
i.Name, "GetActiveOrders", allOrders[j].ID, allOrders[j].CreatedTime)
}
orders = append(orders, exchange.OrderDetail{
ID: order.ID,
ID: allOrders[j].ID,
OrderSide: side,
Amount: order.Amount,
ExecutedAmount: order.AmountFilled,
RemainingAmount: (order.Amount - order.AmountFilled),
Amount: allOrders[j].Amount,
ExecutedAmount: allOrders[j].AmountFilled,
RemainingAmount: (allOrders[j].Amount - allOrders[j].AmountFilled),
Exchange: i.Name,
OrderDate: orderDate,
CurrencyPair: symbol,