d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-09 07:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rangeValCopy linter issues (#275)

Browse Source 
* first pass of linter fixes for range val

* fixed the remaining issues for pointers

* changed as requested
This commit is contained in:
Adam
2019-04-10 17:04:32 +10:00
committed by Adrian Gallagher
parent e56fc26d93
commit d69713f59d
29 changed files with 563 additions and 557 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
exchanges/binance/binance.go
View File

@@ -158,9 +158,9 @@ func (b *Binance) GetExchangeValidCurrencyPairs() ([]string, error) {
return nil, err
}
for _, symbol := range info.Symbols {
if symbol.Status == "TRADING" {
validCurrencyPairs = append(validCurrencyPairs, symbol.BaseAsset+"-"+symbol.QuoteAsset)
for i := range info.Symbols {
if info.Symbols[i].Status == "TRADING" {
validCurrencyPairs = append(validCurrencyPairs, info.Symbols[i].BaseAsset+"-"+info.Symbols[i].QuoteAsset)
}
}
return validCurrencyPairs, nil

44
exchanges/binance/binance_wrapper.go
View File

@@ -275,10 +275,10 @@ func (b *Binance) CancelAllOrders(_ *exchange.OrderCancellation) (exchange.Cance
return cancelAllOrdersResponse, err
}
for _, order := range openOrders {
_, err = b.CancelExistingOrder(order.Symbol, order.OrderID, "")
for i := range openOrders {
_, err = b.CancelExistingOrder(openOrders[i].Symbol, openOrders[i].OrderID, "")
if err != nil {
cancelAllOrdersResponse.OrderStatus[strconv.FormatInt(order.OrderID, 10)] = err.Error()
cancelAllOrdersResponse.OrderStatus[strconv.FormatInt(openOrders[i].OrderID, 10)] = err.Error()
}
}
@@ -344,21 +344,21 @@ func (b *Binance) GetActiveOrders(getOrdersRequest *exchange.GetOrdersRequest) (
return nil, err
}
for _, order := range resp {
orderSide := exchange.OrderSide(strings.ToUpper(order.Side))
orderType := exchange.OrderType(strings.ToUpper(order.Type))
orderDate := time.Unix(int64(order.Time), 0)
for i := range resp {
orderSide := exchange.OrderSide(strings.ToUpper(resp[i].Side))
orderType := exchange.OrderType(strings.ToUpper(resp[i].Type))
orderDate := time.Unix(int64(resp[i].Time), 0)
orders = append(orders, exchange.OrderDetail{
Amount: order.OrigQty,
Amount: resp[i].OrigQty,
OrderDate: orderDate,
Exchange: b.Name,
ID: fmt.Sprintf("%v", order.OrderID),
ID: fmt.Sprintf("%v", resp[i].OrderID),
OrderSide: orderSide,
OrderType: orderType,
Price: order.Price,
Status: order.Status,
CurrencyPair: currency.NewPairFromString(order.Symbol),
Price: resp[i].Price,
Status: resp[i].Status,
CurrencyPair: currency.NewPairFromString(resp[i].Symbol),
})
}
}
@@ -384,25 +384,25 @@ func (b *Binance) GetOrderHistory(getOrdersRequest *exchange.GetOrdersRequest) (
return nil, err
}
for _, order := range resp {
orderSide := exchange.OrderSide(strings.ToUpper(order.Side))
orderType := exchange.OrderType(strings.ToUpper(order.Type))
orderDate := time.Unix(int64(order.Time), 0)
for i := range resp {
orderSide := exchange.OrderSide(strings.ToUpper(resp[i].Side))
orderType := exchange.OrderType(strings.ToUpper(resp[i].Type))
orderDate := time.Unix(int64(resp[i].Time), 0)
// New orders are covered in GetOpenOrders
if order.Status == "NEW" {
if resp[i].Status == "NEW" {
continue
}
orders = append(orders, exchange.OrderDetail{
Amount: order.OrigQty,
Amount: resp[i].OrigQty,
OrderDate: orderDate,
Exchange: b.Name,
ID: fmt.Sprintf("%v", order.OrderID),
ID: fmt.Sprintf("%v", resp[i].OrderID),
OrderSide: orderSide,
OrderType: orderType,
Price: order.Price,
CurrencyPair: currency.NewPairFromString(order.Symbol),
Status: order.Status,
Price: resp[i].Price,
CurrencyPair: currency.NewPairFromString(resp[i].Symbol),
Status: resp[i].Status,
})
}
}