d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-01 23:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

build/ci: Update Go to v1.24, golangci-lint to v1.64.6 and fix issues (#1804)

Browse Source 
* build/ci: Update Go to v1.24, golangci-lint to v1.64.5 and fix issues

* Address shazbert's nitters

* linter/config: Fix new linter issue and use versionSize const

* Address gk's nitters and fix additional linter issue after rebase

* Address glorious nits

* staticcheck: Fix additional linter issues after upgrading to Go 1.24.1 and golangci-lint v1.64.6

Also addresses nits

* Improve testing, assertify usage and use common.ErrParsingWSField

* TestCreateNewStrategy: Replace must > should wording
This commit is contained in:
Adrian Gallagher
2025-03-10 16:33:55 +11:00
committed by GitHub
parent c086e281cf
commit d64d56f77c
114 changed files with 5080 additions and 9355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
exchanges/okx/okx.go
View File

@@ -5224,7 +5224,7 @@ func (ok *Okx) GetInsuranceFundInformation(ctx context.Context, arg *InsuranceFu
}
// CurrencyUnitConvert convert currency to contract, or contract to currency
func (ok *Okx) CurrencyUnitConvert(ctx context.Context, instrumentID string, quantity, orderPrice float64, convertType uint, unitOfCcy currency.Code, operationTypeOpen bool) (*UnitConvertResponse, error) {
func (ok *Okx) CurrencyUnitConvert(ctx context.Context, instrumentID string, quantity, orderPrice float64, convertType uint64, unitOfCcy currency.Code, operationTypeOpen bool) (*UnitConvertResponse, error) {
if instrumentID == "" {
return nil, errMissingInstrumentID
}
@@ -5238,7 +5238,7 @@ func (ok *Okx) CurrencyUnitConvert(ctx context.Context, instrumentID string, qua
params.Set("px", strconv.FormatFloat(orderPrice, 'f', 0, 64))
}
if convertType > 0 {
params.Set("type", strconv.Itoa(int(convertType)))
params.Set("type", strconv.FormatUint(convertType, 10))
}
switch unitOfCcy {
case currency.USDC, currency.USDT:

8
exchanges/okx/okx_websocket.go
View File

@@ -1066,7 +1066,7 @@ func (ok *Okx) WsProcessSnapshotOrderBook(data *WsOrderBookData, pair currency.P
pair,
err)
}
if signedChecksum != data.Checksum {
if signedChecksum != uint32(data.Checksum) { //nolint:gosec // Requires type casting
return fmt.Errorf("%w %v",
errInvalidChecksum,
pair)
@@ -1115,7 +1115,7 @@ func (ok *Okx) WsProcessUpdateOrderbook(data *WsOrderBookData, pair currency.Pai
if err != nil {
return err
}
update.Checksum = uint32(data.Checksum)
update.Checksum = uint32(data.Checksum) //nolint:gosec // Requires type casting
for i := range assets {
ob := update
ob.Asset = assets[i]
@@ -1163,7 +1163,7 @@ func (ok *Okx) CalculateUpdateOrderbookChecksum(orderbookData *orderbook.Base, c
}
// CalculateOrderbookChecksum alternates over the first 25 bid and ask entries from websocket data.
func (ok *Okx) CalculateOrderbookChecksum(orderbookData *WsOrderBookData) (int32, error) {
func (ok *Okx) CalculateOrderbookChecksum(orderbookData *WsOrderBookData) (uint32, error) {
var checksum strings.Builder
for i := range allowableIterations {
if len(orderbookData.Bids)-1 >= i {
@@ -1185,7 +1185,7 @@ func (ok *Okx) CalculateOrderbookChecksum(orderbookData *WsOrderBookData) (int32
}
}
checksumStr := strings.TrimSuffix(checksum.String(), wsOrderbookChecksumDelimiter)
return int32(crc32.ChecksumIEEE([]byte(checksumStr))), nil
return crc32.ChecksumIEEE([]byte(checksumStr)), nil
}
// wsHandleMarkPriceCandles processes candlestick mark price push data as a result of subscription to "mark-price-candle*" channel.