build/ci: Update Go to v1.24, golangci-lint to v1.64.6 and fix issues (#1804)

* build/ci: Update Go to v1.24, golangci-lint to v1.64.5 and fix issues

* Address shazbert's nitters

* linter/config: Fix new linter issue and use versionSize const

* Address gk's nitters and fix additional linter issue after rebase

* Address glorious nits

* staticcheck: Fix additional linter issues after upgrading to Go 1.24.1 and golangci-lint v1.64.6

Also addresses nits

* Improve testing, assertify usage and use common.ErrParsingWSField

* TestCreateNewStrategy: Replace must > should wording
This commit is contained in:
Adrian Gallagher
2025-03-10 16:33:55 +11:00
committed by GitHub
parent c086e281cf
commit d64d56f77c
114 changed files with 5080 additions and 9355 deletions

View File

@@ -618,7 +618,7 @@ func (bi *Binanceus) GetOrderInfo(ctx context.Context, orderID string, pair curr
return nil, err
}
orderIDInt, err := strconv.ParseInt(orderID, 10, 64)
orderIDInt, err := strconv.ParseUint(orderID, 10, 64)
if err != nil {
return nil, fmt.Errorf("invalid orderID %w", err)
}
@@ -632,7 +632,7 @@ func (bi *Binanceus) GetOrderInfo(ctx context.Context, orderID string, pair curr
var orderType order.Type
resp, err := bi.GetOrder(ctx, &OrderRequestParams{
Symbol: symbolValue,
OrderID: uint64(orderIDInt),
OrderID: orderIDInt,
})
if err != nil {
return nil, err
@@ -653,7 +653,7 @@ func (bi *Binanceus) GetOrderInfo(ctx context.Context, orderID string, pair curr
return &order.Detail{
Amount: resp.OrigQty,
Exchange: bi.Name,
OrderID: strconv.FormatInt(int64(resp.OrderID), 10),
OrderID: strconv.FormatUint(resp.OrderID, 10),
ClientOrderID: resp.ClientOrderID,
Side: orderSide,
Type: orderType,
@@ -764,7 +764,7 @@ func (bi *Binanceus) GetActiveOrders(ctx context.Context, getOrdersRequest *orde
Amount: resp[x].OrigQty,
Date: resp[x].Time,
Exchange: bi.Name,
OrderID: strconv.FormatInt(int64(resp[x].OrderID), 10),
OrderID: strconv.FormatUint(resp[x].OrderID, 10),
ClientOrderID: resp[x].ClientOrderID,
Side: orderSide,
Type: orderType,