d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-07 15:11:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

build/ci: Update Go to v1.24, golangci-lint to v1.64.6 and fix issues (#1804)

Browse Source 
* build/ci: Update Go to v1.24, golangci-lint to v1.64.5 and fix issues

* Address shazbert's nitters

* linter/config: Fix new linter issue and use versionSize const

* Address gk's nitters and fix additional linter issue after rebase

* Address glorious nits

* staticcheck: Fix additional linter issues after upgrading to Go 1.24.1 and golangci-lint v1.64.6

Also addresses nits

* Improve testing, assertify usage and use common.ErrParsingWSField

* TestCreateNewStrategy: Replace must > should wording
This commit is contained in:
Adrian Gallagher
2025-03-10 16:33:55 +11:00
committed by GitHub
parent c086e281cf
commit d64d56f77c
114 changed files with 5080 additions and 9355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
engine/datahistory_manager.go
View File

@@ -178,7 +178,7 @@ func (m *DataHistoryManager) compareJobsToData(jobs ...*DataHistoryJob) error {
}
var err error
for i := range jobs {
jobs[i].rangeHolder, err = kline.CalculateCandleDateRanges(jobs[i].StartDate, jobs[i].EndDate, jobs[i].Interval, uint32(jobs[i].RequestSizeLimit))
jobs[i].rangeHolder, err = kline.CalculateCandleDateRanges(jobs[i].StartDate, jobs[i].EndDate, jobs[i].Interval, jobs[i].RequestSizeLimit)
if err != nil {
return err
}
@@ -354,7 +354,7 @@ func (m *DataHistoryManager) runDataJob(job *DataHistoryJob, exch exchange.IBotE
if !m.IsRunning() {
return ErrSubSystemNotStarted
}
var intervalsProcessed int64
var intervalsProcessed uint64
var err error
var result *DataHistoryJobResult
ranges:
@@ -404,7 +404,7 @@ ranges:
job.DataType)
}
var failures int64
var failures uint64
hasDataInRange := false
resultLookup, ok := job.Results[job.rangeHolder.Ranges[i].Start.Time.Unix()]
if ok {
@@ -503,9 +503,9 @@ func (m *DataHistoryManager) runValidationJob(job *DataHistoryJob, exch exchange
if !m.IsRunning() {
return ErrSubSystemNotStarted
}
var intervalsProcessed int64
var intervalsProcessed uint64
var jobIntervals, intervalsToCheck []time.Time
intervalLength := job.Interval.Duration() * time.Duration(job.RequestSizeLimit)
intervalLength := job.Interval.Duration() * time.Duration(job.RequestSizeLimit) //nolint:gosec // TODO: Ensure size limit can't overflow
for i := job.StartDate; i.Before(job.EndDate); i = i.Add(intervalLength) {
jobIntervals = append(jobIntervals, i)
}
@@ -513,7 +513,7 @@ func (m *DataHistoryManager) runValidationJob(job *DataHistoryJob, exch exchange
timesToFetch:
for t, results := range job.Results {
tt := time.Unix(t, 0)
if len(results) < int(job.MaxRetryAttempts) {
if uint64(len(results)) < job.MaxRetryAttempts {
for x := range results {
if results[x].Status == dataHistoryStatusComplete {
continue timesToFetch
@@ -1156,7 +1156,7 @@ func (m *DataHistoryManager) UpsertJob(job *DataHistoryJob, insertOnly bool) err
if job.DataType == dataHistoryConvertCandlesDataType {
interval = job.ConversionInterval
}
job.rangeHolder, err = kline.CalculateCandleDateRanges(job.StartDate, job.EndDate, interval, uint32(job.RequestSizeLimit))
job.rangeHolder, err = kline.CalculateCandleDateRanges(job.StartDate, job.EndDate, interval, job.RequestSizeLimit)
if err != nil {
return err
}
@@ -1256,7 +1256,7 @@ func (m *DataHistoryManager) validateJob(job *DataHistoryJob) error {
}
if job.DataType == dataHistoryCandleValidationDataType {
if job.DecimalPlaceComparison < 0 {
if job.DecimalPlaceComparison == 0 {
log.Warnf(log.DataHistory, "job %s decimal place comparison %v invalid. defaulting to %v decimal places when comparing data for validation", job.Nickname, job.DecimalPlaceComparison, defaultDecimalPlaceComparison)
job.DecimalPlaceComparison = defaultDecimalPlaceComparison
}