d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-19 07:26:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

build/ci: Update Go to v1.24, golangci-lint to v1.64.6 and fix issues (#1804)

Browse Source 
* build/ci: Update Go to v1.24, golangci-lint to v1.64.5 and fix issues

* Address shazbert's nitters

* linter/config: Fix new linter issue and use versionSize const

* Address gk's nitters and fix additional linter issue after rebase

* Address glorious nits

* staticcheck: Fix additional linter issues after upgrading to Go 1.24.1 and golangci-lint v1.64.6

Also addresses nits

* Improve testing, assertify usage and use common.ErrParsingWSField

* TestCreateNewStrategy: Replace must > should wording
This commit is contained in:
Adrian Gallagher
2025-03-10 16:33:55 +11:00
committed by GitHub
parent c086e281cf
commit d64d56f77c
114 changed files with 5080 additions and 9355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
database/drivers/drivers_type.go
View File

@@ -3,7 +3,7 @@ package drivers
// ConnectionDetails holds DSN information
type ConnectionDetails struct {
Host string `json:"host"`
Port uint16 `json:"port"`
Port uint32 `json:"port"`
Username string `json:"username"`
Password string `json:"password"`
Database string `json:"database"`

20
database/repository/datahistoryjob/datahistoryjob.go
View File

@@ -264,7 +264,7 @@ func upsertSqlite(ctx context.Context, tx *sql.Tx, jobs ...*DataHistoryJob) erro
Created: time.Now().UTC().Format(time.RFC3339),
ConversionInterval: null.Float64{Float64: float64(jobs[i].ConversionInterval), Valid: jobs[i].ConversionInterval > 0},
OverwriteData: null.Int64{Int64: overwrite, Valid: overwrite == 1},
DecimalPlaceComparison: null.Int64{Int64: jobs[i].DecimalPlaceComparison, Valid: jobs[i].DecimalPlaceComparison > 0},
DecimalPlaceComparison: null.Int64{Int64: int64(jobs[i].DecimalPlaceComparison), Valid: jobs[i].DecimalPlaceComparison > 0}, //nolint:gosec // TODO: Make uint64
ReplaceOnIssue: null.Int64{Int64: replaceOnIssue, Valid: replaceOnIssue == 1},
IssueTolerancePercentage: null.Float64{Float64: jobs[i].IssueTolerancePercentage, Valid: jobs[i].IssueTolerancePercentage > 0},
}
@@ -315,7 +315,7 @@ func upsertPostgres(ctx context.Context, tx *sql.Tx, jobs ...*DataHistoryJob) er
Created: time.Now().UTC(),
ConversionInterval: null.Float64{Float64: float64(jobs[i].ConversionInterval), Valid: jobs[i].ConversionInterval > 0},
OverwriteData: null.Bool{Bool: jobs[i].OverwriteData, Valid: jobs[i].OverwriteData},
DecimalPlaceComparison: null.Int{Int: int(jobs[i].DecimalPlaceComparison), Valid: jobs[i].DecimalPlaceComparison > 0},
DecimalPlaceComparison: null.Int{Int: int(jobs[i].DecimalPlaceComparison), Valid: jobs[i].DecimalPlaceComparison > 0}, //nolint:gosec // TODO: Make uint64
ReplaceOnIssue: null.Bool{Bool: jobs[i].ReplaceOnIssue, Valid: jobs[i].ReplaceOnIssue},
IssueTolerancePercentage: null.Float64{Float64: jobs[i].IssueTolerancePercentage, Valid: jobs[i].IssueTolerancePercentage > 0},
}
@@ -711,17 +711,17 @@ func (db *DBService) createSQLiteDataHistoryJobResponse(result *sqlite3.Datahist
StartDate: ts,
EndDate: tEnd,
Interval: int64(result.Interval),
RequestSizeLimit: int64(result.RequestSize),
RequestSizeLimit: uint64(result.RequestSize),
DataType: int64(result.DataType),
MaxRetryAttempts: int64(result.MaxRetries),
BatchSize: int64(result.BatchCount),
MaxRetryAttempts: uint64(result.MaxRetries),
BatchSize: uint64(result.BatchCount),
Status: int64(result.Status),
CreatedDate: c,
PrerequisiteJobID: prereqID,
PrerequisiteJobNickname: prereqNickname,
ConversionInterval: int64(result.ConversionInterval.Float64),
OverwriteData: result.OverwriteData.Int64 == 1,
DecimalPlaceComparison: result.DecimalPlaceComparison.Int64,
DecimalPlaceComparison: uint64(result.DecimalPlaceComparison.Int64), //nolint:gosec // TODO: Make uint64
SecondarySourceExchangeName: secondaryExchangeName,
IssueTolerancePercentage: result.IssueTolerancePercentage.Float64,
ReplaceOnIssue: result.ReplaceOnIssue.Int64 == 1,
@@ -789,10 +789,10 @@ func (db *DBService) createPostgresDataHistoryJobResponse(result *postgres.Datah
StartDate: result.StartTime,
EndDate: result.EndTime,
Interval: int64(result.Interval),
RequestSizeLimit: int64(result.RequestSize),
RequestSizeLimit: uint64(result.RequestSize),
DataType: int64(result.DataType),
MaxRetryAttempts: int64(result.MaxRetries),
BatchSize: int64(result.BatchCount),
MaxRetryAttempts: uint64(result.MaxRetries),
BatchSize: uint64(result.BatchCount),
Status: int64(result.Status),
CreatedDate: result.Created,
Results: jobResults,
@@ -800,7 +800,7 @@ func (db *DBService) createPostgresDataHistoryJobResponse(result *postgres.Datah
PrerequisiteJobNickname: prereqNickname,
ConversionInterval: int64(result.ConversionInterval.Float64),
OverwriteData: result.OverwriteData.Bool,
DecimalPlaceComparison: int64(result.DecimalPlaceComparison.Int),
DecimalPlaceComparison: uint64(result.DecimalPlaceComparison.Int), //nolint:gosec // TODO: Make uint64
SecondarySourceExchangeName: secondaryExchangeName,
IssueTolerancePercentage: result.IssueTolerancePercentage.Float64,
ReplaceOnIssue: result.ReplaceOnIssue.Bool,

8
database/repository/datahistoryjob/datahistoryjob_types.go
View File

@@ -22,10 +22,10 @@ type DataHistoryJob struct {
StartDate time.Time
EndDate time.Time
Interval int64
RequestSizeLimit int64
RequestSizeLimit uint64
DataType int64
MaxRetryAttempts int64
BatchSize int64
MaxRetryAttempts uint64
BatchSize uint64
Status int64
CreatedDate time.Time
Results []*datahistoryjobresult.DataHistoryJobResult
@@ -33,7 +33,7 @@ type DataHistoryJob struct {
PrerequisiteJobNickname string
ConversionInterval int64
OverwriteData bool
DecimalPlaceComparison int64
DecimalPlaceComparison uint64
SecondarySourceExchangeName string
IssueTolerancePercentage float64
ReplaceOnIssue bool