build/ci: Update Go to v1.24, golangci-lint to v1.64.6 and fix issues (#1804)

* build/ci: Update Go to v1.24, golangci-lint to v1.64.5 and fix issues

* Address shazbert's nitters

* linter/config: Fix new linter issue and use versionSize const

* Address gk's nitters and fix additional linter issue after rebase

* Address glorious nits

* staticcheck: Fix additional linter issues after upgrading to Go 1.24.1 and golangci-lint v1.64.6

Also addresses nits

* Improve testing, assertify usage and use common.ErrParsingWSField

* TestCreateNewStrategy: Replace must > should wording
This commit is contained in:
Adrian Gallagher
2025-03-10 16:33:55 +11:00
committed by GitHub
parent c086e281cf
commit d64d56f77c
114 changed files with 5080 additions and 9355 deletions

View File

@@ -652,7 +652,7 @@ func TestItemString(t *testing.T) {
// 546290 2192 ns/op 8 B/op 1 allocs/op // Previous
func BenchmarkNewCode(b *testing.B) {
b.ReportAllocs()
for x := 0; x < b.N; x++ {
for b.Loop() {
_ = NewCode("someCode")
}
}

View File

@@ -424,7 +424,7 @@ func BenchmarkGetCrypto(b *testing.B) {
NewPair(LTC, USDT),
}
for x := 0; x < b.N; x++ {
for b.Loop() {
_ = pairs.GetCrypto()
}
}
@@ -524,7 +524,7 @@ func BenchmarkPairsString(b *testing.B) {
NewPair(DAI, XRP),
}
for x := 0; x < b.N; x++ {
for b.Loop() {
_ = pairs.Strings()
}
}
@@ -544,7 +544,7 @@ func BenchmarkPairsFormat(b *testing.B) {
formatting := PairFormat{Delimiter: "/", Uppercase: false}
for x := 0; x < b.N; x++ {
for b.Loop() {
_ = pairs.Format(formatting)
}
}
@@ -562,7 +562,7 @@ func BenchmarkRemovePairsByFilter(b *testing.B) {
NewPair(DAI, XRP),
}
for x := 0; x < b.N; x++ {
for b.Loop() {
_ = pairs.RemovePairsByFilter(USD)
}
}
@@ -916,7 +916,7 @@ func BenchmarkFindDifferences(b *testing.B) {
compare, err := NewPairsFromStrings([]string{"ETH-123", "LTC-123", "MEOW-123"})
require.NoError(b, err)
for i := 0; i < b.N; i++ {
for b.Loop() {
_, err = original.FindDifferences(compare, EMPTYFORMAT)
require.NoError(b, err)
}

View File

@@ -146,7 +146,7 @@ func BenchmarkFindMatchingPairsBetween(b *testing.B) {
BTCM: BTC,
})
for i := 0; i < b.N; i++ {
for b.Loop() {
_ = FindMatchingPairsBetween(PairsWithTranslation{spotPairs, translations}, PairsWithTranslation{futuresPairs, translations})
}
}