d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-08 15:11:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

exchanges: Initial context propagation (#744)

Browse Source 
* gct: phase one context awareness pass

* exchanges: context propagation pass

* common/requester: force context requirement

* gctcli/exchanges: linter fix

* rpcserver: fix test using dummy rpc server

* backtester: fix comments

* grpc: add correct cancel and timeout for commands

* rpcserver_test: add comment on dummy server

* common: deprecated SendHTTPGetRequest

* linter: fix

* linter: turn on no context check

* apichecker: fix context linter issue

* binance: use param context

* common: remove checks as this gets executed before main

* common: change mutex to RW as clients can be used by multiple go routines.

* common: remove init and JIT default client. Unexport global variables and add protection.

* common: Add comments

* bithumb: after dinner mints fix
This commit is contained in:
Ryan O'Hara-Reid
2021-09-11 13:52:07 +10:00
committed by GitHub
parent 72516f7268
commit d636049fb2
168 changed files with 8085 additions and 6996 deletions
Download Patch File Download Diff File Expand all files Collapse all files

197
common/common_test.go
View File

@@ -1,7 +1,9 @@
package common
import (
"context"
"errors"
"net/http"
"net/url"
"os"
"os/user"
@@ -14,6 +16,106 @@ import (
"time"
)
func TestSendHTTPRequest(t *testing.T) {
// t.Parallel() not used to maintain code coverage for assigning the default
// HTTPClient.
methodPost := "pOst"
methodGet := "GeT"
methodDelete := "dEleTe"
methodGarbage := "ding"
headers := make(map[string]string)
headers["Content-Type"] = "application/x-www-form-urlencoded"
_, err := SendHTTPRequest(context.Background(),
methodGarbage, "https://www.google.com", headers,
strings.NewReader(""), true,
)
if err == nil {
t.Error("Expected error 'invalid HTTP method specified'")
}
_, err = SendHTTPRequest(context.Background(),
methodPost, "https://www.google.com", headers,
strings.NewReader(""), true,
)
if err != nil {
t.Error(err)
}
_, err = SendHTTPRequest(context.Background(),
methodGet, "https://www.google.com", headers,
strings.NewReader(""), true,
)
if err != nil {
t.Error(err)
}
err = SetHTTPUserAgent("GCTbot/1337.69 (+http://www.lol.com/)")
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
_, err = SendHTTPRequest(context.Background(),
methodDelete, "https://www.google.com", headers,
strings.NewReader(""), true,
)
if err != nil {
t.Error(err)
}
_, err = SendHTTPRequest(context.Background(),
methodGet, ":missingprotocolscheme", headers,
strings.NewReader(""), true,
)
if err == nil {
t.Error("Common HTTPRequest accepted missing protocol")
}
_, err = SendHTTPRequest(context.Background(),
methodGet, "test://unsupportedprotocolscheme", headers,
strings.NewReader(""), true,
)
if err == nil {
t.Error("Common HTTPRequest accepted invalid protocol")
}
}
func TestSetHTTPClientWithTimeout(t *testing.T) {
t.Parallel()
err := SetHTTPClientWithTimeout(-0)
if !errors.Is(err, errCannotSetInvalidTimeout) {
t.Fatalf("received: %v but expected: %v", err, errCannotSetInvalidTimeout)
}
err = SetHTTPClientWithTimeout(time.Second * 15)
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
}
func TestSetHTTPUserAgent(t *testing.T) {
t.Parallel()
err := SetHTTPUserAgent("")
if !errors.Is(err, errUserAgentInvalid) {
t.Fatalf("received: %v but expected: %v", err, errUserAgentInvalid)
}
err = SetHTTPUserAgent("testy test")
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
}
func TestSetHTTPClient(t *testing.T) {
t.Parallel()
err := SetHTTPClient(nil)
if !errors.Is(err, errHTTPClientInvalid) {
t.Fatalf("received: %v but expected: %v", err, errHTTPClientInvalid)
}
err = SetHTTPClient(new(http.Client))
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
}
func TestIsEnabled(t *testing.T) {
t.Parallel()
expected := "Enabled"
@@ -231,96 +333,6 @@ func TestYesOrNo(t *testing.T) {
}
}
func TestSendHTTPRequest(t *testing.T) {
methodPost := "pOst"
methodGet := "GeT"
methodDelete := "dEleTe"
methodGarbage := "ding"
headers := make(map[string]string)
headers["Content-Type"] = "application/x-www-form-urlencoded"
_, err := SendHTTPRequest(
methodGarbage, "https://www.google.com", headers,
strings.NewReader(""),
)
if err == nil {
t.Error("Expected error 'invalid HTTP method specified'")
}
_, err = SendHTTPRequest(
methodPost, "https://www.google.com", headers,
strings.NewReader(""),
)
if err != nil {
t.Error(err)
}
_, err = SendHTTPRequest(
methodGet, "https://www.google.com", headers,
strings.NewReader(""),
)
if err != nil {
t.Error(err)
}
_, err = SendHTTPRequest(
methodDelete, "https://www.google.com", headers,
strings.NewReader(""),
)
if err != nil {
t.Error(err)
}
_, err = SendHTTPRequest(
methodGet, ":missingprotocolscheme", headers,
strings.NewReader(""),
)
if err == nil {
t.Error("Common HTTPRequest accepted missing protocol")
}
_, err = SendHTTPRequest(
methodGet, "test://unsupportedprotocolscheme", headers,
strings.NewReader(""),
)
if err == nil {
t.Error("Common HTTPRequest accepted invalid protocol")
}
}
func TestSendHTTPGetRequest(t *testing.T) {
t.Parallel()
type test struct {
Address string `json:"address"`
ETH struct {
Balance float64 `json:"balance"`
TotalIn float64 `json:"totalIn"`
TotalOut float64 `json:"totalOut"`
} `json:"ETH"`
}
ethURL := `https://api.ethplorer.io/getAddressInfo/0xff71cb760666ab06aa73f34995b42dd4b85ea07b?apiKey=freekey`
result := test{}
var badresult int
err := SendHTTPGetRequest(ethURL, true, true, &result)
if err != nil {
t.Errorf("common SendHTTPGetRequest error: %s", err)
}
err = SendHTTPGetRequest("DINGDONG", true, false, &result)
if err == nil {
t.Error("common SendHTTPGetRequest error")
}
err = SendHTTPGetRequest(ethURL, false, false, &result)
if err != nil {
t.Errorf("common SendHTTPGetRequest error: %s", err)
}
err = SendHTTPGetRequest("https://httpstat.us/202", false, false, &result)
if err == nil {
t.Error("= common SendHTTPGetRequest error: Ignored unexpected status code")
}
err = SendHTTPGetRequest(ethURL, true, false, &badresult)
if err == nil {
t.Error("common SendHTTPGetRequest error: Unmarshalled into bad type")
}
}
func TestEncodeURLValues(t *testing.T) {
t.Parallel()
urlstring := "https://www.test.com"
@@ -498,6 +510,7 @@ func TestCreateDir(t *testing.T) {
}
func TestChangePermission(t *testing.T) {
t.Parallel()
testDir := filepath.Join(os.TempDir(), "TestFileASDFGHJ")
switch runtime.GOOS {
case "windows":
@@ -557,6 +570,7 @@ func initStringSlice(size int) (out []string) {
}
func TestSplitStringSliceByLimit(t *testing.T) {
t.Parallel()
slice50 := initStringSlice(50)
out := SplitStringSliceByLimit(slice50, 20)
if len(out) != 3 {
@@ -576,6 +590,7 @@ func TestSplitStringSliceByLimit(t *testing.T) {
}
func TestInArray(t *testing.T) {
t.Parallel()
InArray(nil, nil)
array := [6]int{2, 3, 5, 7, 11, 13}
@@ -614,6 +629,7 @@ func TestInArray(t *testing.T) {
}
func TestErrors(t *testing.T) {
t.Parallel()
var test Errors
if test.Error() != "" {
t.Fatal("string should be nil")
@@ -629,6 +645,7 @@ func TestErrors(t *testing.T) {
}
func TestParseStartEndDate(t *testing.T) {
t.Parallel()
pt := time.Date(1999, 1, 1, 0, 0, 0, 0, time.Local)
ft := time.Date(2222, 1, 1, 0, 0, 0, 0, time.Local)
et := time.Date(2020, 1, 1, 1, 0, 0, 0, time.Local)