codebase: Cleanup various things (#1935)

* codebase: Rid base64/hex to string common funcs

* codebase: Rid local scope variable usage and other improvements

* codebase: Refactor currency pair usage across multiple exchanges

- Updated HitBTC tests to use the new currency pair format.
- Modified Kraken futures types to use currency.Pair instead of string for Symbol.
- Adjusted Kraken wrapper methods to handle currency pairs correctly.
- Refined OKX tests and types to utilize currency.Pair for instrument IDs.
- Enhanced Poloniex tests to consistently use predefined currency pairs.
- Streamlined order and orderbook tests to replace string pairs with currency.NewBTCUSD().
- Improved Yobit tests to utilize a standardized currency pair format.
- Updated validator wrapper to use currency pairs directly instead of string conversions.

* codebase: Use types.Number where possible

* refactor: update PayoutFee type to types.Number for consistency

* Refactor: Remove crypto functions to use standard library and other minor changes

- Removed custom crypto functions for SHA256, SHA512, and MD5 from the common/crypto package.
- Replaced usages of removed functions with standard library implementations in various files including:
  - cmd/websocket_client/main.go
  - engine/apiserver.go
  - exchanges/kraken/kraken.go
  - exchanges/lbank/lbank.go
  - exchanges/okx/okx_business_websocket.go
  - exchanges/kucoin/kucoin_websocket.go
  - gctscript/vm/vm.go
- Updated tests to reflect changes in the crypto functions.
- Renamed several functions for clarity, particularly in the context of order book updates across multiple exchanges.

* refactor: replace assert with require for consistency in test assertions

* refactor: Improve Binance futures candlestick test, standardise orderbook update function names and improve test parallelism

* refactor: Replace require.Len with require.Equal for better output in TestGetFuturesKlineData
This commit is contained in:
Adrian Gallagher
2025-06-12 14:12:36 +10:00
committed by GitHub
parent ce134a0a1d
commit d5ba674fc4
115 changed files with 1327 additions and 3112 deletions

View File

@@ -6,6 +6,8 @@ import (
"path/filepath"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/database"
"github.com/thrasher-corp/gocryptotrader/database/drivers"
"github.com/thrasher-corp/gocryptotrader/database/testhelpers"
@@ -55,7 +57,8 @@ func TestMain(m *testing.M) {
}
func TestInsertMany(t *testing.T) {
testCases := []struct {
t.Parallel()
for _, tc := range []struct {
name string
config *database.Config
seedDB func() error
@@ -75,43 +78,30 @@ func TestInsertMany(t *testing.T) {
},
seedDB: seed,
},
}
for x := range testCases {
test := testCases[x]
t.Run(test.name, func(t *testing.T) {
if !testhelpers.CheckValidConfig(&test.config.ConnectionDetails) {
} {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
if !testhelpers.CheckValidConfig(&tc.config.ConnectionDetails) {
t.Skip("database not configured skipping test")
}
dbConn, err := testhelpers.ConnectToDatabase(test.config)
if err != nil {
t.Fatal(err)
dbConn, err := testhelpers.ConnectToDatabase(tc.config)
require.NoError(t, err)
if tc.seedDB != nil {
require.NoError(t, tc.seedDB())
}
if test.seedDB != nil {
err = test.seedDB()
if err != nil {
t.Error(err)
}
}
err = InsertMany(testExchanges)
if err != nil {
t.Fatal(err)
}
require.NoError(t, InsertMany(testExchanges))
err = testhelpers.CloseDatabase(dbConn)
if err != nil {
t.Error(err)
}
assert.NoError(t, err)
})
}
}
func TestOneAndOneByUUID(t *testing.T) {
testCases := []struct {
for _, tc := range []struct {
name string
config *database.Config
seedDB func() error
@@ -131,45 +121,27 @@ func TestOneAndOneByUUID(t *testing.T) {
},
seedDB: seed,
},
}
for x := range testCases {
test := testCases[x]
t.Run(test.name, func(t *testing.T) {
if !testhelpers.CheckValidConfig(&test.config.ConnectionDetails) {
} {
t.Run(tc.name, func(t *testing.T) {
if !testhelpers.CheckValidConfig(&tc.config.ConnectionDetails) {
t.Skip("database not configured skipping test")
}
dbConn, err := testhelpers.ConnectToDatabase(test.config)
if err != nil {
t.Fatal(err)
}
dbConn, err := testhelpers.ConnectToDatabase(tc.config)
require.NoError(t, err)
if test.seedDB != nil {
err = test.seedDB()
if err != nil {
t.Error(err)
}
if tc.seedDB != nil {
require.NoError(t, tc.seedDB())
}
ret, err := One("one")
if err != nil {
t.Fatal(err)
}
require.NoError(t, err)
ret2, err := OneByUUID(ret.UUID)
if err != nil {
t.Fatal(err)
}
require.NoError(t, err)
if ret.Name != ret2.Name {
t.Fatalf("unexpected value received: %v", ret2.Name)
}
err = testhelpers.CloseDatabase(dbConn)
if err != nil {
t.Error(err)
}
assert.Equal(t, ret.Name, ret2.Name)
assert.NoError(t, testhelpers.CloseDatabase(dbConn))
})
}
}