linters: Add modernise tool check and fix issues (#2012)

* linters: Add modernise tool check and fix issues

* engine: Simplify exch.SetDefaults call and remove localWG

* CI: Revert config versions lint workflow
This commit is contained in:
Adrian Gallagher
2025-08-26 12:45:13 +10:00
committed by GitHub
parent 85403fe801
commit d5b2cf1759
22 changed files with 103 additions and 159 deletions

View File

@@ -179,7 +179,7 @@ Run the following after completing changes:
This ensures proper formatting across the codebase.
## Linters
## Linters and other miscellaneous checks
Run the following to check for linting issues:
@@ -187,6 +187,14 @@ Run the following to check for linting issues:
golangci-lint run ./... (or make lint)
```
Run the following tool to check for Go modernise issues:
```console
make modernise
```
Several other miscellaneous checks will be ran via [GitHub actions](/.github/workflows/misc.yml).
- All lint warnings and errors must be resolved before merging.
- Use `//nolint:linter-name` sparingly and always explain the reason in a comment next to the code.
- Examples of valid use: