linters: Add modernise tool check and fix issues (#2012)

* linters: Add modernise tool check and fix issues

* engine: Simplify exch.SetDefaults call and remove localWG

* CI: Revert config versions lint workflow
This commit is contained in:
Adrian Gallagher
2025-08-26 12:45:13 +10:00
committed by GitHub
parent 85403fe801
commit d5b2cf1759
22 changed files with 103 additions and 159 deletions

View File

@@ -1321,37 +1321,27 @@ func TestLiveLoop(t *testing.T) {
// dataUpdated case
var wg sync.WaitGroup
wg.Add(1)
go func() {
err = bt.liveCheck()
assert.NoError(t, err)
wg.Done()
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.dataUpdated <- true
dc.shutdown <- true
wg.Wait()
// shutdown from error case
wg.Add(1)
dc.started = 0
go func() {
defer wg.Done()
err = bt.liveCheck()
assert.NoError(t, err)
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.shutdownErr <- true
wg.Wait()
// shutdown case
dc.started = 1
bt.shutdown = make(chan struct{})
wg.Add(1)
go func() {
defer wg.Done()
err = bt.liveCheck()
assert.NoError(t, err)
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.shutdown <- true
wg.Wait()