d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

linters: Add modernise tool check and fix issues (#2012)

Browse Source 
* linters: Add modernise tool check and fix issues

* engine: Simplify exch.SetDefaults call and remove localWG

* CI: Revert config versions lint workflow
This commit is contained in:
Adrian Gallagher
2025-08-26 12:45:13 +10:00
committed by GitHub
parent 85403fe801
commit d5b2cf1759
22 changed files with 103 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
backtester/engine/backtest.go
View File

@@ -81,25 +81,20 @@ func (bt *BackTest) RunLive() error {
if bt.LiveDataHandler == nil {
return errLiveOnly
}
var err error
if bt.LiveDataHandler.IsRealOrders() {
err = bt.LiveDataHandler.UpdateFunding(false)
if err != nil {
if err := bt.LiveDataHandler.UpdateFunding(false); err != nil {
return err
}
}
err = bt.LiveDataHandler.Start()
if err != nil {
if err := bt.LiveDataHandler.Start(); err != nil {
return err
}
bt.wg.Add(1)
go func() {
err = bt.liveCheck()
if err != nil {
bt.wg.Go(func() {
if err := bt.liveCheck(); err != nil {
log.Errorln(common.LiveStrategy, err)
}
bt.wg.Done()
}()
})
return nil
}

28
backtester/engine/backtest_test.go
View File

@@ -1321,37 +1321,27 @@ func TestLiveLoop(t *testing.T) {
// dataUpdated case
var wg sync.WaitGroup
wg.Add(1)
go func() {
err = bt.liveCheck()
assert.NoError(t, err)
wg.Done()
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.dataUpdated <- true
dc.shutdown <- true
wg.Wait()
// shutdown from error case
wg.Add(1)
dc.started = 0
go func() {
defer wg.Done()
err = bt.liveCheck()
assert.NoError(t, err)
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.shutdownErr <- true
wg.Wait()
// shutdown case
dc.started = 1
bt.shutdown = make(chan struct{})
wg.Add(1)
go func() {
defer wg.Done()
err = bt.liveCheck()
assert.NoError(t, err)
}()
wg.Go(func() {
assert.NoError(t, bt.liveCheck())
})
dc.shutdown <- true
wg.Wait()

21
backtester/engine/live_test.go
View File

@@ -135,12 +135,9 @@ func TestLiveHandlerStopFromError(t *testing.T) {
dc.started = 1
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
err = dc.SignalStopFromError(errNoCredsNoLive)
assert.NoError(t, err)
}()
wg.Go(func() {
assert.NoError(t, dc.SignalStopFromError(errNoCredsNoLive))
})
wg.Wait()
var dh *dataChecker
@@ -177,19 +174,15 @@ func TestUpdated(t *testing.T) {
dataUpdated: make(chan bool, 10),
}
var wg sync.WaitGroup
wg.Add(1)
go func() {
wg.Go(func() {
_ = dc.Updated()
wg.Done()
}()
})
wg.Wait()
dc = nil
wg.Add(1)
go func() {
wg.Go(func() {
_ = dc.Updated()
wg.Done()
}()
})
wg.Wait()
}