Engine: Protocol Features, coverage, types, BTC markets websocket (#368)

* Attempts to update orderbook so it doesn't need to sort

* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features

* update existing feature lists. Expands list definition to match my emotions

* Adds bithumb bitmex and bitstamp. adds a couple more types

* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini

* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb

* Who can forget good old alphapoint?

* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features

* Adds extra data not in the documentation :/

* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet

* Removes import cycle via duplicate structs.

* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary

* Increase coverage in code.go

* One way of determining a test has failed, is when to it fails. Removed redundant explanation

* Increases code coverage of conversion

* Lint fixes

* Fixes orderbook tests

* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook

* Secret lints that did not show up via Windows linting

* Adds protocol package to contain exchange features

* Fixes protocol implementation

* Fixes ws tests

* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have

* imports and casing

* Fixes two more nil error checks

exchanges/lakebtc/lakebtc_test.go

@@ -35,11 +35,11 @@ func TestSetup(t *testing.T) {
 		cfg := config.GetConfig()
 		err := cfg.LoadConfig("../../testdata/configtest.json", true)
 		if err != nil {
-			log.Fatal("Test Failed - LakeBTC load config error", err)
+			log.Fatal("LakeBTC load config error", err)
 		}
 		lakebtcConfig, err := cfg.GetExchangeConfig("LakeBTC")
 		if err != nil {
-			t.Error("Test Failed - LakeBTC Setup() init error")
+			t.Error("LakeBTC Setup() init error")
 		}
 		lakebtcConfig.API.AuthenticatedSupport = true
 		lakebtcConfig.API.Credentials.Key = apiKey
@@ -47,7 +47,7 @@ func TestSetup(t *testing.T) {
 		lakebtcConfig.Features.Enabled.Websocket = true
 		err = l.Setup(lakebtcConfig)
 		if err != nil {
-			t.Fatal("Test Failed - LakeBTC setup error", err)
+			t.Fatal("LakeBTC setup error", err)
 		}
 		l.API.Endpoints.WebsocketURL = lakeBTCWSURL
 		setupRan = true
@@ -58,7 +58,7 @@ func TestFetchTradablePairs(t *testing.T) {
 	t.Parallel()
 	_, err := l.FetchTradablePairs(asset.Spot)
 	if err != nil {
-		t.Fatalf("Test failed. GetTradablePairs err: %s", err)
+		t.Fatalf("GetTradablePairs err: %s", err)
 	}
 }
 
@@ -66,7 +66,7 @@ func TestGetTicker(t *testing.T) {
 	t.Parallel()
 	_, err := l.GetTicker()
 	if err != nil {
-		t.Error("Test Failed - GetTicker() error", err)
+		t.Error("GetTicker() error", err)
 	}
 }
 
@@ -74,7 +74,7 @@ func TestGetOrderBook(t *testing.T) {
 	t.Parallel()
 	_, err := l.GetOrderBook("BTCUSD")
 	if err != nil {
-		t.Error("Test Failed - GetOrderBook() error", err)
+		t.Error("GetOrderBook() error", err)
 	}
 }
 
@@ -82,7 +82,7 @@ func TestGetTradeHistory(t *testing.T) {
 	t.Parallel()
 	_, err := l.GetTradeHistory("BTCUSD")
 	if err != nil {
-		t.Error("Test Failed - GetTradeHistory() error", err)
+		t.Error("GetTradeHistory() error", err)
 	}
 }
 
@@ -93,7 +93,7 @@ func TestTrade(t *testing.T) {
 	}
 	_, err := l.Trade(false, 0, 0, "USD")
 	if err == nil {
-		t.Error("Test Failed - Trade() error", err)
+		t.Error("Trade() Expected error")
 	}
 }
 
@@ -104,7 +104,7 @@ func TestGetOpenOrders(t *testing.T) {
 	}
 	_, err := l.GetOpenOrders()
 	if err == nil {
-		t.Error("Test Failed - GetOpenOrders() error", err)
+		t.Error("GetOpenOrders() Expected error")
 	}
 }
 
@@ -115,7 +115,7 @@ func TestGetOrders(t *testing.T) {
 	}
 	_, err := l.GetOrders([]int64{1, 2})
 	if err == nil {
-		t.Error("Test Failed - GetOrders() error", err)
+		t.Error("GetOrders() Expected error")
 	}
 }
 
@@ -126,7 +126,7 @@ func TestCancelOrder(t *testing.T) {
 	}
 	err := l.CancelExistingOrder(1337)
 	if err == nil {
-		t.Error("Test Failed - CancelExistingOrder() error", err)
+		t.Error("CancelExistingOrder() Expected error")
 	}
 }
 
@@ -137,7 +137,7 @@ func TestGetTrades(t *testing.T) {
 	}
 	_, err := l.GetTrades(1337)
 	if err == nil {
-		t.Error("Test Failed - GetTrades() error", err)
+		t.Error("GetTrades() Expected error")
 	}
 }
 
@@ -148,7 +148,7 @@ func TestGetExternalAccounts(t *testing.T) {
 	}
 	_, err := l.GetExternalAccounts()
 	if err == nil {
-		t.Error("Test Failed - GetExternalAccounts() error", err)
+		t.Error("GetExternalAccounts() Expected error")
 	}
 }
 
@@ -187,7 +187,7 @@ func TestGetFee(t *testing.T) {
 	// CryptocurrencyTradeFee Basic
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0.002) || err != nil {
 		t.Error(err)
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0.002), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0.002), resp)
 	}
 
 	// CryptocurrencyTradeFee High quantity
@@ -195,7 +195,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder.Amount = 1000
 	feeBuilder.PurchasePrice = 1000
 	if resp, err := l.GetFee(feeBuilder); resp != float64(2000) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(2000), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(2000), resp)
 		t.Error(err)
 	}
 
@@ -203,7 +203,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder = setFeeBuilder()
 	feeBuilder.IsMaker = true
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0.0015) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0.0015), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0.0015), resp)
 		t.Error(err)
 	}
 
@@ -211,14 +211,14 @@ func TestGetFee(t *testing.T) {
 	feeBuilder = setFeeBuilder()
 	feeBuilder.PurchasePrice = -1000
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0), resp)
 		t.Error(err)
 	}
 	// CryptocurrencyWithdrawalFee Basic
 	feeBuilder = setFeeBuilder()
 	feeBuilder.FeeType = exchange.CryptocurrencyWithdrawalFee
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0), resp)
 		t.Error(err)
 	}
 
@@ -227,7 +227,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder.Pair.Base = currency.NewCode("hello")
 	feeBuilder.FeeType = exchange.CryptocurrencyWithdrawalFee
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0), resp)
 		t.Error(err)
 	}
 
@@ -235,7 +235,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder = setFeeBuilder()
 	feeBuilder.FeeType = exchange.CyptocurrencyDepositFee
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0.001) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0.001), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0.001), resp)
 		t.Error(err)
 	}
 
@@ -243,7 +243,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder = setFeeBuilder()
 	feeBuilder.FeeType = exchange.InternationalBankDepositFee
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0), resp)
 		t.Error(err)
 	}
 
@@ -252,7 +252,7 @@ func TestGetFee(t *testing.T) {
 	feeBuilder.FeeType = exchange.InternationalBankWithdrawalFee
 	feeBuilder.FiatCurrency = currency.USD
 	if resp, err := l.GetFee(feeBuilder); resp != float64(0) || err != nil {
-		t.Errorf("Test Failed - GetFee() error. Expected: %f, Received: %f", float64(0), resp)
+		t.Errorf("GetFee() error. Expected: %f, Received: %f", float64(0), resp)
 		t.Error(err)
 	}
 }
@@ -393,7 +393,7 @@ func TestCancelAllExchangeOrders(t *testing.T) {
 func TestModifyOrder(t *testing.T) {
 	_, err := l.ModifyOrder(&exchange.ModifyOrder{})
 	if err == nil {
-		t.Error("Test failed - ModifyOrder() error")
+		t.Error("ModifyOrder() Expected error")
 	}
 }
 
@@ -456,12 +456,12 @@ func TestGetDepositAddress(t *testing.T) {
 	if areTestAPIKeysSet() {
 		_, err := l.GetDepositAddress(currency.BTC, "")
 		if err != nil {
-			t.Error("Test Failed - GetDepositAddress() error", err)
+			t.Error("GetDepositAddress() error", err)
 		}
 	} else {
 		_, err := l.GetDepositAddress(currency.DASH, "")
 		if err == nil {
-			t.Error("Test Failed - GetDepositAddress() error cannot be nil")
+			t.Error("GetDepositAddress() error cannot be nil")
 		}
 	}
 }

exchanges/lakebtc/lakebtc_wrapper.go

@@ -14,6 +14,7 @@ import (
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
+	"github.com/thrasher-corp/gocryptotrader/exchanges/protocol"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/request"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/websocket/wshandler"
@@ -69,9 +70,27 @@ func (l *LakeBTC) SetDefaults() {
 		Supports: exchange.FeaturesSupported{
 			REST:      true,
 			Websocket: true,
-			RESTCapabilities: exchange.ProtocolFeatures{
-				AutoPairUpdates: true,
-				TickerBatching:  true,
+			RESTCapabilities: protocol.Features{
+				TickerBatching:    true,
+				TickerFetching:    true,
+				TradeFetching:     true,
+				OrderbookFetching: true,
+				AutoPairUpdates:   true,
+				AccountInfo:       true,
+				GetOrder:          true,
+				GetOrders:         true,
+				CancelOrders:      true,
+				CancelOrder:       true,
+				SubmitOrder:       true,
+				UserTradeHistory:  true,
+				CryptoWithdrawal:  true,
+				TradeFee:          true,
+				CryptoDepositFee:  true,
+			},
+			WebsocketCapabilities: protocol.Features{
+				TradeFetching:     true,
+				OrderbookFetching: true,
+				Subscribe:         true,
 			},
 			WithdrawPermissions: exchange.AutoWithdrawCrypto |
 				exchange.WithdrawFiatViaWebsiteOnly,
@@ -90,9 +109,6 @@ func (l *LakeBTC) SetDefaults() {
 	l.API.Endpoints.URL = l.API.Endpoints.URLDefault
 	l.Websocket = wshandler.New()
 	l.API.Endpoints.WebsocketURL = lakeBTCWSURL
-	l.Websocket.Functionality = wshandler.WebsocketOrderbookSupported |
-		wshandler.WebsocketTradeDataSupported |
-		wshandler.WebsocketSubscribeSupported
 	l.WebsocketResponseMaxLimit = exchange.DefaultWebsocketResponseMaxLimit
 	l.WebsocketResponseCheckTimeout = exchange.DefaultWebsocketResponseCheckTimeout
 	l.WebsocketOrderbookBufferLimit = exchange.DefaultWebsocketOrderbookBufferLimit
@@ -121,6 +137,7 @@ func (l *LakeBTC) Setup(exch *config.ExchangeConfig) error {
 			RunningURL:                       exch.API.Endpoints.WebsocketURL,
 			Connector:                        l.WsConnect,
 			Subscriber:                       l.Subscribe,
+			Features:                         &l.Features.Supports.WebsocketCapabilities,
 		})
 	if err != nil {
 		return err