mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-13 23:16:45 +00:00
Engine: Protocol Features, coverage, types, BTC markets websocket (#368)
* Attempts to update orderbook so it doesn't need to sort * Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features * update existing feature lists. Expands list definition to match my emotions * Adds bithumb bitmex and bitstamp. adds a couple more types * Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini * Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb * Who can forget good old alphapoint? * Adds btcmarksets websocket :glitch_crab: fixes alphapoint features * Adds extra data not in the documentation :/ * Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet * Removes import cycle via duplicate structs. * Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary * Increase coverage in code.go * One way of determining a test has failed, is when to it fails. Removed redundant explanation * Increases code coverage of conversion * Lint fixes * Fixes orderbook tests * Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook * Secret lints that did not show up via Windows linting * Adds protocol package to contain exchange features * Fixes protocol implementation * Fixes ws tests * Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have * imports and casing * Fixes two more nil error checks
This commit is contained in:
@@ -9,7 +9,7 @@ import (
|
||||
func TestString(t *testing.T) {
|
||||
a := Spot
|
||||
if a.String() != "spot" {
|
||||
t.Fatal("Test failed - TestString returned an unexpected result")
|
||||
t.Fatal("TestString returned an unexpected result")
|
||||
}
|
||||
}
|
||||
|
||||
@@ -18,7 +18,7 @@ func TestToStringArray(t *testing.T) {
|
||||
result := a.Strings()
|
||||
for x := range a {
|
||||
if !common.StringDataCompare(result, a[x].String()) {
|
||||
t.Fatal("Test failed - TestToStringArray returned an unexpected result")
|
||||
t.Fatal("TestToStringArray returned an unexpected result")
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -26,60 +26,60 @@ func TestToStringArray(t *testing.T) {
|
||||
func TestContains(t *testing.T) {
|
||||
a := Items{Spot, Futures}
|
||||
if a.Contains("meow") {
|
||||
t.Fatal("Test failed - TestContains returned an unexpected result")
|
||||
t.Fatal("TestContains returned an unexpected result")
|
||||
}
|
||||
|
||||
if !a.Contains(Spot) {
|
||||
t.Fatal("Test failed - TestContains returned an unexpected result")
|
||||
t.Fatal("TestContains returned an unexpected result")
|
||||
}
|
||||
|
||||
if a.Contains(Binary) {
|
||||
t.Fatal("Test failed - TestContains returned an unexpected result")
|
||||
t.Fatal("TestContains returned an unexpected result")
|
||||
}
|
||||
|
||||
if !a.Contains("SpOt") {
|
||||
t.Error("Test failed - TestContains returned an unexpected result")
|
||||
t.Error("TestContains returned an unexpected result")
|
||||
}
|
||||
}
|
||||
|
||||
func TestJoinToString(t *testing.T) {
|
||||
a := Items{Spot, Futures}
|
||||
if a.JoinToString(",") != "spot,futures" {
|
||||
t.Fatal("Test failed - TestJoinToString returned an unexpected result")
|
||||
t.Fatal("TestJoinToString returned an unexpected result")
|
||||
}
|
||||
}
|
||||
|
||||
func TestIsValid(t *testing.T) {
|
||||
if IsValid("rawr") {
|
||||
t.Fatal("Test failed - TestIsValid returned an unexpected result")
|
||||
t.Fatal("TestIsValid returned an unexpected result")
|
||||
}
|
||||
|
||||
if !IsValid(Spot) {
|
||||
t.Fatal("Test failed - TestIsValid returned an unexpected result")
|
||||
t.Fatal("TestIsValid returned an unexpected result")
|
||||
}
|
||||
}
|
||||
|
||||
func TestNew(t *testing.T) {
|
||||
a := New("Spota")
|
||||
if a != nil {
|
||||
t.Fatal("Test failed - TestNew returned an unexpected result")
|
||||
t.Fatal("TestNew returned an unexpected result")
|
||||
}
|
||||
|
||||
a = New("SpOt")
|
||||
if a == nil {
|
||||
t.Fatal("Test failed - TestNew returned an unexpected result")
|
||||
t.Fatal("TestNew returned an unexpected result")
|
||||
}
|
||||
|
||||
a = New("spot,futures")
|
||||
if a.JoinToString(",") != "spot,futures" {
|
||||
t.Fatal("Test failed - TestNew returned an unexpected result")
|
||||
t.Fatal("TestNew returned an unexpected result")
|
||||
}
|
||||
|
||||
if a := New("Spot_rawr"); a != nil {
|
||||
t.Fatal("Test failed - TestNew returned an unexpected result")
|
||||
t.Fatal("TestNew returned an unexpected result")
|
||||
}
|
||||
|
||||
if a := New("Spot,Rawr"); a != nil {
|
||||
t.Fatal("Test failed - TestNew returned an unexpected result")
|
||||
t.Fatal("TestNew returned an unexpected result")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user