Engine: Protocol Features, coverage, types, BTC markets websocket (#368)

* Attempts to update orderbook so it doesn't need to sort

* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features

* update existing feature lists. Expands list definition to match my emotions

* Adds bithumb bitmex and bitstamp. adds a couple more types

* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini

* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb

* Who can forget good old alphapoint?

* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features

* Adds extra data not in the documentation :/

* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet

* Removes import cycle via duplicate structs.

* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary

* Increase coverage in code.go

* One way of determining a test has failed, is when to it fails. Removed redundant explanation

* Increases code coverage of conversion

* Lint fixes

* Fixes orderbook tests

* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook

* Secret lints that did not show up via Windows linting

* Adds protocol package to contain exchange features

* Fixes protocol implementation

* Fixes ws tests

* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have

* imports and casing

* Fixes two more nil error checks

engine/restful_server_test.go

@@ -15,7 +15,7 @@ func loadConfig(t *testing.T) *config.Config {
 	cfg := config.GetConfig()
 	err := cfg.LoadConfig("", true)
 	if err != nil {
-		t.Error("Test failed. GetCurrencyConfig LoadConfig error", err)
+		t.Error("GetCurrencyConfig LoadConfig error", err)
 	}
 	return cfg
 }
@@ -25,7 +25,7 @@ func makeHTTPGetRequest(t *testing.T, response interface{}) *http.Response {
 
 	err := RESTfulJSONResponse(w, response)
 	if err != nil {
-		t.Error("Test failed. Failed to make response.", err)
+		t.Error("Failed to make response.", err)
 	}
 	return w.Result()
 }
@@ -37,17 +37,17 @@ func TestConfigAllJsonResponse(t *testing.T) {
 	body, err := ioutil.ReadAll(resp.Body)
 	resp.Body.Close()
 	if err != nil {
-		t.Error("Test failed. Body not readable", err)
+		t.Error("Body not readable", err)
 	}
 
 	var responseConfig config.Config
 	jsonErr := json.Unmarshal(body, &responseConfig)
 	if jsonErr != nil {
-		t.Error("Test failed. Response not parseable as json", err)
+		t.Error("Response not parseable as json", err)
 	}
 
 	if reflect.DeepEqual(responseConfig, cfg) {
-		t.Error("Test failed. Json not equal to config")
+		t.Error("Json not equal to config")
 	}
 }
 
@@ -62,7 +62,7 @@ func TestInvalidHostRequest(t *testing.T) {
 	newRouter(true).ServeHTTP(resp, req)
 
 	if status := resp.Code; status != http.StatusNotFound {
-		t.Errorf("Test failed. Response returned wrong status code expected %v got %v", http.StatusNotFound, status)
+		t.Errorf("Response returned wrong status code expected %v got %v", http.StatusNotFound, status)
 	}
 }
 
@@ -77,6 +77,6 @@ func TestValidHostRequest(t *testing.T) {
 	newRouter(true).ServeHTTP(resp, req)
 
 	if status := resp.Code; status != http.StatusOK {
-		t.Errorf("Test failed. Response returned wrong status code expected %v got %v", http.StatusOK, status)
+		t.Errorf("Response returned wrong status code expected %v got %v", http.StatusOK, status)
 	}
 }