Engine: Protocol Features, coverage, types, BTC markets websocket (#368)

* Attempts to update orderbook so it doesn't need to sort

* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features

* update existing feature lists. Expands list definition to match my emotions

* Adds bithumb bitmex and bitstamp. adds a couple more types

* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini

* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb

* Who can forget good old alphapoint?

* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features

* Adds extra data not in the documentation :/

* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet

* Removes import cycle via duplicate structs.

* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary

* Increase coverage in code.go

* One way of determining a test has failed, is when to it fails. Removed redundant explanation

* Increases code coverage of conversion

* Lint fixes

* Fixes orderbook tests

* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook

* Secret lints that did not show up via Windows linting

* Adds protocol package to contain exchange features

* Fixes protocol implementation

* Fixes ws tests

* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have

* imports and casing

* Fixes two more nil error checks

engine/exchange_test.go

@@ -16,7 +16,7 @@ func SetupTest(t *testing.T) {
 		Bot.Config = &config.Cfg
 		err := Bot.Config.LoadConfig("", true)
 		if err != nil {
-			t.Fatalf("Test failed. SetupTest: Failed to load config: %s", err)
+			t.Fatalf("SetupTest: Failed to load config: %s", err)
 		}
 		testSetup = true
 	}
@@ -26,7 +26,7 @@ func SetupTest(t *testing.T) {
 	}
 	err := LoadExchange("Bitfinex", false, nil)
 	if err != nil {
-		t.Errorf("Test failed. SetupTest: Failed to load exchange: %s", err)
+		t.Errorf("SetupTest: Failed to load exchange: %s", err)
 	}
 }
 
@@ -37,7 +37,7 @@ func CleanupTest(t *testing.T) {
 
 	err := UnloadExchange("Bitfinex")
 	if err != nil {
-		t.Fatalf("Test failed. CleanupTest: Failed to unload exchange: %s",
+		t.Fatalf("CleanupTest: Failed to unload exchange: %s",
 			err)
 	}
 }
@@ -46,11 +46,11 @@ func TestCheckExchangeExists(t *testing.T) {
 	SetupTest(t)
 
 	if !CheckExchangeExists("Bitfinex") {
-		t.Errorf("Test failed. TestGetExchangeExists: Unable to find exchange")
+		t.Errorf("TestGetExchangeExists: Unable to find exchange")
 	}
 
 	if CheckExchangeExists("Asdsad") {
-		t.Errorf("Test failed. TestGetExchangeExists: Non-existent exchange found")
+		t.Errorf("TestGetExchangeExists: Non-existent exchange found")
 	}
 
 	CleanupTest(t)
@@ -61,26 +61,26 @@ func TestGetExchangeByName(t *testing.T) {
 
 	exch := GetExchangeByName("Bitfinex")
 	if exch == nil {
-		t.Errorf("Test failed. TestGetExchangeByName: Failed to get exchange")
+		t.Errorf("TestGetExchangeByName: Failed to get exchange")
 	}
 
 	if !exch.IsEnabled() {
-		t.Errorf("Test failed. TestGetExchangeByName: Unexpected result")
+		t.Errorf("TestGetExchangeByName: Unexpected result")
 	}
 
 	exch.SetEnabled(false)
 	bfx := GetExchangeByName("Bitfinex")
 	if bfx.IsEnabled() {
-		t.Errorf("Test failed. TestGetExchangeByName: Unexpected result")
+		t.Errorf("TestGetExchangeByName: Unexpected result")
 	}
 
 	if exch.GetName() != "Bitfinex" {
-		t.Errorf("Test failed. TestGetExchangeByName: Unexpected result")
+		t.Errorf("TestGetExchangeByName: Unexpected result")
 	}
 
 	exch = GetExchangeByName("Asdasd")
 	if exch != nil {
-		t.Errorf("Test failed. TestGetExchangeByName: Non-existent exchange found")
+		t.Errorf("TestGetExchangeByName: Non-existent exchange found")
 	}
 
 	CleanupTest(t)
@@ -91,13 +91,13 @@ func TestReloadExchange(t *testing.T) {
 
 	err := ReloadExchange("asdf")
 	if err != ErrExchangeNotFound {
-		t.Errorf("Test failed. TestReloadExchange: Incorrect result: %s",
+		t.Errorf("TestReloadExchange: Incorrect result: %s",
 			err)
 	}
 
 	err = ReloadExchange("Bitfinex")
 	if err != nil {
-		t.Errorf("Test failed. TestReloadExchange: Incorrect result: %s",
+		t.Errorf("TestReloadExchange: Incorrect result: %s",
 			err)
 	}
 
@@ -105,7 +105,7 @@ func TestReloadExchange(t *testing.T) {
 
 	err = ReloadExchange("asdf")
 	if err != ErrNoExchangesLoaded {
-		t.Errorf("Test failed. TestReloadExchange: Incorrect result: %s",
+		t.Errorf("TestReloadExchange: Incorrect result: %s",
 			err)
 	}
 }
@@ -115,19 +115,19 @@ func TestUnloadExchange(t *testing.T) {
 
 	err := UnloadExchange("asdf")
 	if err != ErrExchangeNotFound {
-		t.Errorf("Test failed. TestUnloadExchange: Incorrect result: %s",
+		t.Errorf("TestUnloadExchange: Incorrect result: %s",
 			err)
 	}
 
 	err = UnloadExchange("Bitfinex")
 	if err != nil {
-		t.Errorf("Test failed. TestUnloadExchange: Failed to get exchange. %s",
+		t.Errorf("TestUnloadExchange: Failed to get exchange. %s",
 			err)
 	}
 
 	err = UnloadExchange("asdf")
 	if err != ErrNoExchangesLoaded {
-		t.Errorf("Test failed. TestUnloadExchange: Incorrect result: %s",
+		t.Errorf("TestUnloadExchange: Incorrect result: %s",
 			err)
 	}
 

engine/helpers_test.go

@@ -31,7 +31,7 @@ func SetupTestHelpers(t *testing.T) {
 			Bot.Config = &config.Cfg
 			err := Bot.Config.LoadConfig("../testdata/configtest.json", true)
 			if err != nil {
-				t.Fatalf("Test failed. SetupTest: Failed to load config: %s", err)
+				t.Fatalf("SetupTest: Failed to load config: %s", err)
 			}
 			testSetup = true
 		}
@@ -428,7 +428,7 @@ func TestGetSpecificTicker(t *testing.T) {
 		&ticker.Price{Pair: p, Last: 1000},
 		asset.Spot)
 	if err != nil {
-		t.Fatal("Test failed. ProcessTicker error", err)
+		t.Fatal("ProcessTicker error", err)
 	}
 
 	tick, err := GetSpecificTicker(currency.NewPairFromStrings("BTC", "USD"), "Bitstamp",
@@ -587,6 +587,6 @@ func TestGetCryptocurrenciesByExchange(t *testing.T) {
 
 	_, err := GetCryptocurrenciesByExchange("Bitfinex", false, false, asset.Spot)
 	if err != nil {
-		t.Fatalf("Test failed. Err %s", err)
+		t.Fatalf("Err %s", err)
 	}
 }

engine/restful_server_test.go

@@ -15,7 +15,7 @@ func loadConfig(t *testing.T) *config.Config {
 	cfg := config.GetConfig()
 	err := cfg.LoadConfig("", true)
 	if err != nil {
-		t.Error("Test failed. GetCurrencyConfig LoadConfig error", err)
+		t.Error("GetCurrencyConfig LoadConfig error", err)
 	}
 	return cfg
 }
@@ -25,7 +25,7 @@ func makeHTTPGetRequest(t *testing.T, response interface{}) *http.Response {
 
 	err := RESTfulJSONResponse(w, response)
 	if err != nil {
-		t.Error("Test failed. Failed to make response.", err)
+		t.Error("Failed to make response.", err)
 	}
 	return w.Result()
 }
@@ -37,17 +37,17 @@ func TestConfigAllJsonResponse(t *testing.T) {
 	body, err := ioutil.ReadAll(resp.Body)
 	resp.Body.Close()
 	if err != nil {
-		t.Error("Test failed. Body not readable", err)
+		t.Error("Body not readable", err)
 	}
 
 	var responseConfig config.Config
 	jsonErr := json.Unmarshal(body, &responseConfig)
 	if jsonErr != nil {
-		t.Error("Test failed. Response not parseable as json", err)
+		t.Error("Response not parseable as json", err)
 	}
 
 	if reflect.DeepEqual(responseConfig, cfg) {
-		t.Error("Test failed. Json not equal to config")
+		t.Error("Json not equal to config")
 	}
 }
 
@@ -62,7 +62,7 @@ func TestInvalidHostRequest(t *testing.T) {
 	newRouter(true).ServeHTTP(resp, req)
 
 	if status := resp.Code; status != http.StatusNotFound {
-		t.Errorf("Test failed. Response returned wrong status code expected %v got %v", http.StatusNotFound, status)
+		t.Errorf("Response returned wrong status code expected %v got %v", http.StatusNotFound, status)
 	}
 }
 
@@ -77,6 +77,6 @@ func TestValidHostRequest(t *testing.T) {
 	newRouter(true).ServeHTTP(resp, req)
 
 	if status := resp.Code; status != http.StatusOK {
-		t.Errorf("Test failed. Response returned wrong status code expected %v got %v", http.StatusOK, status)
+		t.Errorf("Response returned wrong status code expected %v got %v", http.StatusOK, status)
 	}
 }

engine/syncer_test.go

@@ -16,7 +16,7 @@ func TestNewCurrencyPairSyncer(t *testing.T) {
 	Bot.Config = &config.Cfg
 	err := Bot.Config.LoadConfig("", true)
 	if err != nil {
-		t.Fatalf("Test failed. TestNewExchangeSyncer: Failed to load config: %s", err)
+		t.Fatalf("TestNewExchangeSyncer: Failed to load config: %s", err)
 	}
 
 	Bot.Settings.DisableExchangeAutoPairUpdates = true