Engine: Protocol Features, coverage, types, BTC markets websocket (#368)

* Attempts to update orderbook so it doesn't need to sort

* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features

* update existing feature lists. Expands list definition to match my emotions

* Adds bithumb bitmex and bitstamp. adds a couple more types

* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini

* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb

* Who can forget good old alphapoint?

* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features

* Adds extra data not in the documentation :/

* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet

* Removes import cycle via duplicate structs.

* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary

* Increase coverage in code.go

* One way of determining a test has failed, is when to it fails. Removed redundant explanation

* Increases code coverage of conversion

* Lint fixes

* Fixes orderbook tests

* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook

* Secret lints that did not show up via Windows linting

* Adds protocol package to contain exchange features

* Fixes protocol implementation

* Fixes ws tests

* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have

* imports and casing

* Fixes two more nil error checks

config/config_encryption_test.go

@@ -9,7 +9,7 @@ func TestPromptForConfigEncryption(t *testing.T) {
 	t.Parallel()
 
 	if Cfg.PromptForConfigEncryption("", true) {
-		t.Error("Test failed. PromptForConfigEncryption return incorrect bool")
+		t.Error("PromptForConfigEncryption return incorrect bool")
 	}
 }
 
@@ -18,25 +18,25 @@ func TestPromptForConfigKey(t *testing.T) {
 
 	byteyBite, err := PromptForConfigKey(true)
 	if err == nil && len(byteyBite) > 1 {
-		t.Errorf("Test failed. PromptForConfigKey: %s", err)
+		t.Errorf("PromptForConfigKey: %s", err)
 	}
 
 	_, err = PromptForConfigKey(false)
 	if err == nil {
-		t.Fatal(err)
+		t.Error("Expected error")
 	}
 }
 
 func TestEncryptConfigFile(t *testing.T) {
 	_, err := EncryptConfigFile([]byte("test"), nil)
 	if err == nil {
-		t.Fatal("Test failed. Expected different result")
+		t.Fatal("Expected error")
 	}
 
 	sessionDK = []byte("a")
 	_, err = EncryptConfigFile([]byte("test"), nil)
 	if err == nil {
-		t.Fatal("Test failed. Expected different result")
+		t.Fatal("Expected error")
 	}
 
 	sessionDK, err = makeNewSessionDK([]byte("asdf"))
@@ -60,17 +60,17 @@ func TestDecryptConfigFile(t *testing.T) {
 
 	_, err = DecryptConfigFile(result, nil)
 	if err == nil {
-		t.Fatal("Test failed. Expected different result")
+		t.Fatal("Expected error")
 	}
 
 	_, err = DecryptConfigFile([]byte("test"), nil)
 	if err == nil {
-		t.Fatal("Test failed. Expected different result")
+		t.Fatal("Expected error")
 	}
 
 	_, err = DecryptConfigFile([]byte("test"), []byte("AAAAAAAAAAAAAAAA"))
 	if err == nil {
-		t.Fatalf("Test failed. Expected %s", errAESBlockSize)
+		t.Fatalf("Expected %s", errAESBlockSize)
 	}
 
 	result, err = EncryptConfigFile([]byte("test"), []byte("key"))
@@ -86,14 +86,14 @@ func TestDecryptConfigFile(t *testing.T) {
 
 func TestConfirmConfigJSON(t *testing.T) {
 	var result interface{}
-	testConfirmJSON, err := ioutil.ReadFile(ConfigTestFile)
+	testConfirmJSON, err := ioutil.ReadFile(TestFile)
 	if err != nil {
-		t.Errorf("Test failed. testConfirmJSON: %s", err)
+		t.Errorf("testConfirmJSON: %s", err)
 	}
 
 	err = ConfirmConfigJSON(testConfirmJSON, &result)
 	if err != nil || result == nil {
-		t.Errorf("Test failed. testConfirmJSON: %s", err)
+		t.Errorf("testConfirmJSON: %s", err)
 	}
 }
 
@@ -102,7 +102,7 @@ func TestConfirmECS(t *testing.T) {
 
 	ECStest := []byte(EncryptConfirmString)
 	if !ConfirmECS(ECStest) {
-		t.Errorf("Test failed. TestConfirmECS: Error finding ECS.")
+		t.Errorf("TestConfirmECS: Error finding ECS.")
 	}
 }
 
@@ -113,7 +113,7 @@ func TestRemoveECS(t *testing.T) {
 	isremoved := RemoveECS(ECStest)
 
 	if string(isremoved) != "" {
-		t.Errorf("Test failed. TestConfirmECS: Error ECS not deleted.")
+		t.Errorf("TestConfirmECS: Error ECS not deleted.")
 	}
 }
 
@@ -122,6 +122,6 @@ func TestMakeNewSessionDK(t *testing.T) {
 
 	_, err := makeNewSessionDK(nil)
 	if err == nil {
-		t.Fatal("Test failed. makeNewSessionDK passed with nil key")
+		t.Fatal("makeNewSessionDK passed with nil key")
 	}
 }