Engine: Protocol Features, coverage, types, BTC markets websocket (#368)

* Attempts to update orderbook so it doesn't need to sort

* Reverts the ws ob stuff. Gets rid of sorting because it happens later. Adds some exchange features

* update existing feature lists. Expands list definition to match my emotions

* Adds bithumb bitmex and bitstamp. adds a couple more types

* Features for you, features for me, features for bittrex, btcmarkets, btse, coinbasepro, coinut, exmo, gateio and gemini

* Features for hitbtc, huobi, itbit, kraken, lakebtc, lbank, localbitcoins, okcoin, okex, poloniex, yobit, zb

* Who can forget good old alphapoint?

* Adds btcmarksets websocket :glitch_crab: fixes alphapoint features

* Adds extra data not in the documentation :/

* Replaces websocket features by using protocol features. However, it breaks it due to import cycles. I'm not sure what I'll do just yet

* Removes import cycle via duplicate structs.

* Increases coverage of config with `TestCheckCurrencyConfigValues`. Moves all currency pair package types into their own files or places it at the bottom of files if necessary

* Increase coverage in code.go

* One way of determining a test has failed, is when to it fails. Removed redundant explanation

* Increases code coverage of conversion

* Lint fixes

* Fixes orderbook tests

* Re-adds sorting because its important to still have the internal pre-processed orderbook to be representative of a real orderbook

* Secret lints that did not show up via Windows linting

* Adds protocol package to contain exchange features

* Fixes protocol implementation

* Fixes ws tests

* Addresses the following: Removes st-st-stutters in config types, changes GetAvailableForexProviders -> GetSupportedForexProviders, removes errors from tests where error is nil, removes orderbook setup when not necessary, removes import newlines, removes false bools from declaration, changes should of to should have

* imports and casing

* Fixes two more nil error checks
This commit is contained in:
Scott
2019-10-22 10:56:20 +11:00
committed by Adrian Gallagher
parent ec0ed1c1e5
commit ccfcdf26aa
156 changed files with 5228 additions and 4337 deletions

View File

@@ -22,7 +22,7 @@ func TestSetup(t *testing.T) {
commsCfg := cfg.GetCommunicationsConfig()
T.Setup(&commsCfg)
if T.Name != "Telegram" || T.Enabled || T.Token != "testest" || T.Verbose {
t.Error("test failed - telegram Setup() error, unexpected setup values",
t.Error("telegram Setup() error, unexpected setup values",
T.Name,
T.Enabled,
T.Token,
@@ -33,19 +33,19 @@ func TestSetup(t *testing.T) {
func TestConnect(t *testing.T) {
err := T.Connect()
if err == nil {
t.Error("test failed - telegram Connect() error")
t.Error("telegram Connect() error")
}
}
func TestPushEvent(t *testing.T) {
err := T.PushEvent(base.Event{})
if err != nil {
t.Error("test failed - telegram PushEvent() error", err)
t.Error("telegram PushEvent() error", err)
}
T.AuthorisedClients = append(T.AuthorisedClients, 1337)
err = T.PushEvent(base.Event{})
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram PushEvent() error, expected 'Not found' got '%s'",
t.Errorf("telegram PushEvent() error, expected 'Not found' got '%s'",
err)
}
}
@@ -55,27 +55,27 @@ func TestHandleMessages(t *testing.T) {
chatID := int64(1337)
err := T.HandleMessages(cmdHelp, chatID)
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram HandleMessages() error, expected 'Not found' got '%s'",
t.Errorf("telegram HandleMessages() error, expected 'Not found' got '%s'",
err)
}
err = T.HandleMessages(cmdStart, chatID)
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram HandleMessages() error, expected 'Not found' got '%s'",
t.Errorf("telegram HandleMessages() error, expected 'Not found' got '%s'",
err)
}
err = T.HandleMessages(cmdStatus, chatID)
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram HandleMessages() error, expected 'Not found' got '%s'",
t.Errorf("telegram HandleMessages() error, expected 'Not found' got '%s'",
err)
}
err = T.HandleMessages(cmdSettings, chatID)
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram HandleMessages() error, expected 'Not found' got '%s'",
t.Errorf("telegram HandleMessages() error, expected 'Not found' got '%s'",
err)
}
err = T.HandleMessages("Not a command", chatID)
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram HandleMessages() error, expected 'Not found' got '%s'",
t.Errorf("telegram HandleMessages() error, expected 'Not found' got '%s'",
err)
}
}
@@ -84,7 +84,7 @@ func TestGetUpdates(t *testing.T) {
t.Parallel()
_, err := T.GetUpdates()
if err != nil {
t.Error("test failed - telegram GetUpdates() error", err)
t.Error("telegram GetUpdates() error", err)
}
}
@@ -92,7 +92,7 @@ func TestTestConnection(t *testing.T) {
t.Parallel()
err := T.TestConnection()
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram TestConnection() error, expected 'Not found' got '%s'",
t.Errorf("telegram TestConnection() error, expected 'Not found' got '%s'",
err)
}
}
@@ -101,7 +101,7 @@ func TestSendMessage(t *testing.T) {
t.Parallel()
err := T.SendMessage("Test message", int64(1337))
if err.Error() != testErrNotFound {
t.Errorf("test failed - telegram SendMessage() error, expected 'Not found' got '%s'",
t.Errorf("telegram SendMessage() error, expected 'Not found' got '%s'",
err)
}
}
@@ -110,6 +110,6 @@ func TestSendHTTPRequest(t *testing.T) {
t.Parallel()
err := T.SendHTTPRequest("0.0.0.0", nil, nil)
if err == nil {
t.Error("test failed - telegram SendHTTPRequest() error")
t.Error("telegram SendHTTPRequest() error")
}
}