d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 23:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

testing: bybit references, bybit mock testing, pair formatting, standards improvement (#1322)

Browse Source 
* fixes tests

* pair formats and extra fixes

* quick change before shazbert sees

* sneaky lint

* adds bybit mock testing and fixes test

* whoops

* error response instead

* classic forgetting to lint

* bybit live test no longer auto-records results

* ty thrasher- Update exchanges/bybit/bybit_wrapper.go

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>

---------

Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>
This commit is contained in:
Scott
2023-08-21 14:48:56 +10:00
committed by GitHub
parent 577817c46e
commit c7b3ace78c
16 changed files with 92170 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

193
exchanges/bybit/bybit_test.go
View File

@@ -3,8 +3,6 @@ package bybit
import (
"context"
"errors"
"log"
"os"
"strconv"
"strings"
"sync"
@@ -12,12 +10,10 @@ import (
"time"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/config"
"github.com/thrasher-corp/gocryptotrader/currency"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
"github.com/thrasher-corp/gocryptotrader/exchanges/order"
"github.com/thrasher-corp/gocryptotrader/exchanges/request"
"github.com/thrasher-corp/gocryptotrader/exchanges/sharedtestvalues"
"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
@@ -32,52 +28,6 @@ const (
var b = &Bybit{}
func TestMain(m *testing.M) {
b.SetDefaults()
cfg := config.GetConfig()
err := cfg.LoadConfig("../../testdata/configtest.json", true)
if err != nil {
log.Fatal(err)
}
exchCfg, err := cfg.GetExchangeConfig("Bybit")
if err != nil {
log.Fatal(err)
}
exchCfg.API.AuthenticatedSupport = true
exchCfg.API.AuthenticatedWebsocketSupport = false
exchCfg.API.Credentials.Key = apiKey
exchCfg.API.Credentials.Secret = apiSecret
b.Websocket = sharedtestvalues.NewTestWebsocket()
request.MaxRequestJobs = 100
err = b.Setup(exchCfg)
if err != nil {
log.Fatal(err)
}
err = b.UpdateTradablePairs(context.Background(), false)
if err != nil {
log.Fatal(err)
}
// Turn on all pairs for testing
supportedAssets := b.GetAssetTypes(false)
for x := range supportedAssets {
avail, err := b.GetAvailablePairs(supportedAssets[x])
if err != nil {
log.Fatal(err)
}
err = b.CurrencyPairs.StorePairs(supportedAssets[x], avail, true)
if err != nil {
log.Fatal(err)
}
}
os.Exit(m.Run())
}
func TestStart(t *testing.T) {
t.Parallel()
err := b.Start(context.Background(), nil)
@@ -128,7 +78,13 @@ func TestGetTrades(t *testing.T) {
func TestGetKlines(t *testing.T) {
t.Parallel()
_, err := b.GetKlines(context.Background(), "BTCUSDT", "5m", 2000, time.Now().Add(-time.Hour*1), time.Now())
s := time.Now().Add(-time.Hour)
e := time.Now()
if mockTests {
s = time.Unix(1691897100, 0).Round(kline.FiveMin.Duration())
e = time.Unix(1691907100, 0).Round(kline.FiveMin.Duration())
}
_, err := b.GetKlines(context.Background(), "BTCUSDT", "5m", 2000, s, e)
if err != nil {
t.Fatal(err)
}
@@ -2067,7 +2023,6 @@ func TestUpdateTicker(t *testing.T) {
if err != nil {
t.Error(err)
}
_, err = b.UpdateTicker(context.Background(), pair, asset.USDTMarginedFutures)
if err != nil {
t.Error(err)
@@ -2083,18 +2038,27 @@ func TestUpdateTicker(t *testing.T) {
t.Error(err)
}
// Futures update dynamically, so fetch the available tradable futures for this test
availPairs, err := b.FetchTradablePairs(context.Background(), asset.Futures)
if err != nil {
t.Fatal(err)
var pairs currency.Pairs
if mockTests {
var pair2 currency.Pair
pair2, err = currency.NewPairFromString("BTCUSD-U23")
if err != nil {
t.Fatal(err)
}
pairs = pairs.Add(pair2)
} else {
// Futures update dynamically, so fetch the available tradable futures for this test
pairs, err = b.FetchTradablePairs(context.Background(), asset.Futures)
if err != nil {
t.Fatal(err)
}
// Needs to be set before calling extractCurrencyPair
if err = b.SetPairs(pairs, asset.Futures, true); err != nil {
t.Fatal(err)
}
}
// Needs to be set before calling extractCurrencyPair
if err = b.SetPairs(availPairs, asset.Futures, true); err != nil {
t.Fatal(err)
}
_, err = b.UpdateTicker(context.Background(), availPairs[0], asset.Futures)
_, err = b.UpdateTicker(context.Background(), pairs[0], asset.Futures)
if err != nil {
t.Error(err)
}
@@ -2178,12 +2142,7 @@ func TestFetchTradablePairs(t *testing.T) {
func TestUpdateTradablePairs(t *testing.T) {
t.Parallel()
err := b.UpdateTradablePairs(context.Background(), false)
if err != nil {
t.Error(err)
}
err = b.UpdateTradablePairs(context.Background(), true)
err := b.UpdateTradablePairs(context.Background(), true)
if err != nil {
t.Error(err)
}
@@ -2238,25 +2197,28 @@ func TestGetHistoricCandles(t *testing.T) {
if err != nil {
t.Fatal(err)
}
end := time.Now()
start := end.AddDate(0, 0, -3)
e := time.Now()
s := e.AddDate(0, 0, -3)
if mockTests {
s = time.Unix(1691897100, 0).Truncate(kline.OneDay.Duration())
e = time.Unix(1692007100, 0).Truncate(kline.OneDay.Duration())
}
_, err = b.GetHistoricCandles(context.Background(), pair, asset.Spot, kline.OneDay, start, end)
_, err = b.GetHistoricCandles(context.Background(), pair, asset.Spot, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
_, err = b.GetHistoricCandles(context.Background(), pair, asset.USDTMarginedFutures, kline.OneDay, start, end)
_, err = b.GetHistoricCandles(context.Background(), pair, asset.USDTMarginedFutures, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
pair1, err := currency.NewPairFromString("BTCUSD")
pair1, err := currency.NewPairFromString("BTC-USD")
if err != nil {
t.Fatal(err)
}
_, err = b.GetHistoricCandles(context.Background(), pair1, asset.CoinMarginedFutures, kline.OneHour, start, end)
_, err = b.GetHistoricCandles(context.Background(), pair1, asset.CoinMarginedFutures, kline.OneHour, s, e)
if err != nil {
t.Error(err)
}
@@ -2265,8 +2227,17 @@ func TestGetHistoricCandles(t *testing.T) {
if err != nil {
t.Fatal(err)
}
var pair2 currency.Pair
if mockTests {
pair2, err = currency.NewPairFromString("BTCUSD-U23")
if err != nil {
t.Fatal(err)
}
} else {
pair2 = enabled[0]
}
_, err = b.GetHistoricCandles(context.Background(), enabled[0], asset.Futures, kline.OneHour, start, end)
_, err = b.GetHistoricCandles(context.Background(), pair2, asset.Futures, kline.OneHour, s, e)
if err != nil {
t.Error(err)
}
@@ -2276,7 +2247,7 @@ func TestGetHistoricCandles(t *testing.T) {
t.Fatal(err)
}
_, err = b.GetHistoricCandles(context.Background(), pair3, asset.USDCMarginedFutures, kline.OneDay, start, end)
_, err = b.GetHistoricCandles(context.Background(), pair3, asset.USDCMarginedFutures, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
@@ -2288,16 +2259,19 @@ func TestGetHistoricCandlesExtended(t *testing.T) {
if err != nil {
t.Fatal(err)
}
e := time.Now()
s := e.AddDate(0, 0, -3)
if mockTests {
s = time.Unix(1691897100, 0).Truncate(kline.OneDay.Duration())
e = time.Unix(1692007100, 0).Truncate(kline.OneDay.Duration())
}
startTime := time.Now().Add(-time.Hour * 24 * 3)
end := time.Now().Add(-time.Hour * 1)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair, asset.Spot, kline.OneMin, startTime, end)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair, asset.Spot, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
_, err = b.GetHistoricCandlesExtended(context.Background(), pair, asset.USDTMarginedFutures, kline.OneMin, startTime, end)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair, asset.USDTMarginedFutures, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
@@ -2306,8 +2280,7 @@ func TestGetHistoricCandlesExtended(t *testing.T) {
if err != nil {
t.Fatal(err)
}
_, err = b.GetHistoricCandlesExtended(context.Background(), pair1, asset.CoinMarginedFutures, kline.OneHour, startTime, end)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair1, asset.CoinMarginedFutures, kline.OneHour, s, e)
if err != nil {
t.Error(err)
}
@@ -2316,8 +2289,17 @@ func TestGetHistoricCandlesExtended(t *testing.T) {
if err != nil {
t.Fatal(err)
}
var pair2 currency.Pair
if mockTests {
pair2, err = currency.NewPairFromString("BTCUSD-U23")
if err != nil {
t.Fatal(err)
}
} else {
pair2 = enabled[0]
}
_, err = b.GetHistoricCandlesExtended(context.Background(), enabled[0], asset.Futures, kline.OneDay, startTime, end)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair2, asset.Futures, kline.OneHour, s, e)
if err != nil {
t.Error(err)
}
@@ -2327,7 +2309,7 @@ func TestGetHistoricCandlesExtended(t *testing.T) {
t.Fatal(err)
}
_, err = b.GetHistoricCandlesExtended(context.Background(), pair3, asset.USDCMarginedFutures, kline.FiveMin, startTime, end)
_, err = b.GetHistoricCandlesExtended(context.Background(), pair3, asset.USDCMarginedFutures, kline.OneDay, s, e)
if err != nil {
t.Error(err)
}
@@ -2979,8 +2961,11 @@ func TestGetUSDCKlines(t *testing.T) {
if err != nil {
t.Fatal(err)
}
_, err = b.GetUSDCKlines(context.Background(), pair, "5", time.Now().Add(-time.Hour), 0)
s := time.Now().Add(-time.Hour)
if mockTests {
s = time.Unix(1691897100, 0)
}
_, err = b.GetUSDCKlines(context.Background(), pair, "5", s, 0)
if err != nil {
t.Error(err)
}
@@ -2992,8 +2977,11 @@ func TestGetUSDCMarkPriceKlines(t *testing.T) {
if err != nil {
t.Fatal(err)
}
_, err = b.GetUSDCMarkPriceKlines(context.Background(), pair, "5", time.Now().Add(-time.Hour), 0)
s := time.Now().Add(-time.Hour)
if mockTests {
s = time.Unix(1691897100, 0)
}
_, err = b.GetUSDCMarkPriceKlines(context.Background(), pair, "5", s, 0)
if err != nil {
t.Error(err)
}
@@ -3005,8 +2993,11 @@ func TestGetUSDCIndexPriceKlines(t *testing.T) {
if err != nil {
t.Fatal(err)
}
_, err = b.GetUSDCIndexPriceKlines(context.Background(), pair, "5", time.Now().Add(-time.Hour), 0)
s := time.Now().Add(-time.Hour)
if mockTests {
s = time.Unix(1691897100, 0)
}
_, err = b.GetUSDCIndexPriceKlines(context.Background(), pair, "5", s, 0)
if err != nil {
t.Error(err)
}
@@ -3018,8 +3009,12 @@ func TestGetUSDCPremiumIndexKlines(t *testing.T) {
if err != nil {
t.Fatal(err)
}
s := time.Now().Add(-time.Hour)
if mockTests {
s = time.Unix(1692077100, 0)
}
_, err = b.GetUSDCPremiumIndexKlines(context.Background(), pair, "5", time.Now().Add(-time.Hour), 0)
_, err = b.GetUSDCPremiumIndexKlines(context.Background(), pair, "5", s, 0)
if err != nil {
t.Error(err)
}
@@ -3350,6 +3345,9 @@ func TestCancelBatchOrders(t *testing.T) {
func TestUpdateTickers(t *testing.T) {
t.Parallel()
if mockTests {
t.Skip("test it not relevant in a mock setting")
}
supportedAssets := b.GetAssetTypes(false)
ctx := context.Background()
for x := range supportedAssets {
@@ -3375,9 +3373,12 @@ func TestUpdateTickers(t *testing.T) {
func TestGetTickersV5(t *testing.T) {
t.Parallel()
_, err := b.GetTickersV5(context.Background(), "bruh", "", "")
if err != nil && err.Error() != "Illegal category" {
t.Error(err)
var err error
if !mockTests {
_, err = b.GetTickersV5(context.Background(), "bruh", "", "")
if err != nil && err.Error() != "Illegal category" {
t.Error(err)
}
}
_, err = b.GetTickersV5(context.Background(), "option", "", "")