exchanges: Remove FTX implementation and fix minor test issues (#1100)

* exchanges: Start removal of FTX

* Get tests happy again

* okx: improve logic and add basic coverage

* Fix linterino

* Round 2 plus rm useless assignment in test

* Fix exchange_wrapper_issues test error

* Fix nitters

* Address nitters
This commit is contained in:
Adrian Gallagher
2023-01-25 16:40:04 +11:00
committed by GitHub
parent 05558aabfb
commit c785ae73a7
57 changed files with 211 additions and 9661 deletions

View File

@@ -42,11 +42,12 @@ import (
"github.com/thrasher-corp/gocryptotrader/exchanges/account"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/binance"
"github.com/thrasher-corp/gocryptotrader/exchanges/binanceus"
gctkline "github.com/thrasher-corp/gocryptotrader/exchanges/kline"
gctorder "github.com/thrasher-corp/gocryptotrader/exchanges/order"
)
const testExchange = "binance"
const testExchange = "binanceus"
var leet = decimal.NewFromInt(1337)
@@ -71,11 +72,14 @@ func TestSetupFromConfig(t *testing.T) {
if !errors.Is(err, base.ErrStrategyNotFound) {
t.Errorf("received: %v, expected: %v", err, base.ErrStrategyNotFound)
}
const testExchange = "bybit"
cfg.CurrencySettings = []config.CurrencySettings{
{
ExchangeName: testExchange,
Base: currency.BTC,
Quote: currency.NewCode("0624"),
Quote: currency.USDT,
Asset: asset.Spot,
},
{
@@ -96,8 +100,6 @@ func TestSetupFromConfig(t *testing.T) {
"hello": "moto",
},
}
cfg.CurrencySettings[0].Base = currency.BTC
cfg.CurrencySettings[0].Quote = currency.USDT
cfg.DataSettings.APIData = &config.APIData{}
err = bt.SetupFromConfig(cfg, "", "", false)
@@ -156,7 +158,7 @@ func TestLoadDataAPI(t *testing.T) {
cfg := &config.Config{
CurrencySettings: []config.CurrencySettings{
{
ExchangeName: "Binance",
ExchangeName: testExchange,
Asset: asset.Spot,
Base: cp.Base,
Quote: cp.Quote,
@@ -180,7 +182,7 @@ func TestLoadDataAPI(t *testing.T) {
},
}
em := engine.ExchangeManager{}
exch, err := em.NewExchangeByName("Binance")
exch, err := em.NewExchangeByName(testExchange)
if err != nil {
t.Fatal(err)
}
@@ -209,7 +211,7 @@ func TestLoadDataCSV(t *testing.T) {
cfg := &config.Config{
CurrencySettings: []config.CurrencySettings{
{
ExchangeName: "Binance",
ExchangeName: testExchange,
Asset: asset.Spot,
Base: cp.Base,
Quote: cp.Quote,
@@ -234,7 +236,7 @@ func TestLoadDataCSV(t *testing.T) {
},
}
em := engine.ExchangeManager{}
exch, err := em.NewExchangeByName("Binance")
exch, err := em.NewExchangeByName(testExchange)
if err != nil {
t.Fatal(err)
}
@@ -1543,7 +1545,7 @@ func TestSetExchangeCredentials(t *testing.T) {
t.Errorf("received '%v' expected '%v'", err, gctcommon.ErrNilPointer)
}
cfg := &config.Config{}
f := &binance.Binance{}
f := &binanceus.Binanceus{}
f.SetDefaults()
b := f.GetBase()
err = setExchangeCredentials(cfg, b)

View File

@@ -20,6 +20,7 @@ import (
"github.com/thrasher-corp/gocryptotrader/engine"
"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
"github.com/thrasher-corp/gocryptotrader/exchanges/binance"
"github.com/thrasher-corp/gocryptotrader/exchanges/binanceus"
"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
)
@@ -328,7 +329,7 @@ func TestFetchLatestData(t *testing.T) {
currency.PairFormat{
Uppercase: true,
})
f := &binance.Binance{}
f := &binanceus.Binanceus{}
f.SetDefaults()
fb := f.GetBase()
fbA := fb.CurrencyPairs.Pairs[asset.Spot]
@@ -392,7 +393,7 @@ func TestLoadCandleData(t *testing.T) {
t.Errorf("received '%v' expected '%v'", err, gctcommon.ErrNilPointer)
}
exch := &binance.Binance{}
exch := &binanceus.Binanceus{}
exch.SetDefaults()
cp := currency.NewPair(currency.BTC, currency.USDT).Format(
currency.PairFormat{
@@ -443,7 +444,7 @@ func TestSetDataForClosingAllPositions(t *testing.T) {
currency.PairFormat{
Uppercase: true,
})
f := &binance.Binance{}
f := &binanceus.Binanceus{}
f.SetDefaults()
fb := f.GetBase()
fbA := fb.CurrencyPairs.Pairs[asset.Spot]