Exchanges: Remove WalletAddress (#1882)

* Exchanges: Remove cancel order walletAddress

* Order: Refactor TestMatchFilter

TestMatchFilter had inconsistent testing of empty values, and was
painful when a field was removed due to index methodology.
This should provide equal test clarity, but improve maintainability and
improve coverage on empty values.
This commit is contained in:
Gareth Kirwan
2025-04-30 09:10:36 +02:00
committed by GitHub
parent 88ac5274c9
commit c2d876d8b0
29 changed files with 5321 additions and 5375 deletions

View File

@@ -1359,13 +1359,12 @@ func (s *RPCServer) CancelOrder(ctx context.Context, r *gctrpc.CancelOrderReques
err = s.OrderManager.Cancel(ctx,
&order.Cancel{
Exchange: r.Exchange,
AccountID: r.AccountId,
OrderID: r.OrderId,
Side: side,
WalletAddress: r.WalletAddress,
Pair: p,
AssetType: a,
Exchange: r.Exchange,
AccountID: r.AccountId,
OrderID: r.OrderId,
Side: side,
Pair: p,
AssetType: a,
})
if err != nil {
return nil, err
@@ -1408,12 +1407,11 @@ func (s *RPCServer) CancelBatchOrders(ctx context.Context, r *gctrpc.CancelBatch
orderID := orders[x]
status[orderID] = order.Cancelled.String()
req[x] = order.Cancel{
AccountID: r.AccountId,
OrderID: orderID,
Side: side,
WalletAddress: r.WalletAddress,
Pair: pair,
AssetType: assetType,
AccountID: r.AccountId,
OrderID: orderID,
Side: side,
Pair: pair,
AssetType: assetType,
}
}