d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

common: Replace StringDataCompare with slices.Contains and cleanup string funcs (#1631)

Browse Source 
* common: Replace StringDataCompare with slices.Contains and cleanup string funcs

* common/docs: Update SliceDifference and remove outdated steps from ADD_NEW_EXCHANGE.md

* common: Improve SliceDifference
This commit is contained in:
Adrian Gallagher
2024-09-13 10:43:20 +10:00
committed by GitHub
parent 22cb0eb9b9
commit b8e836d74f
32 changed files with 201 additions and 370 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
docs/ADD_NEW_EXCHANGE.md
View File

@@ -251,43 +251,6 @@ var Exchanges = []string{
"yobit",
```
#### Increment the default number of supported exchanges in [config/config_test.go](../config/config_test.go):
```go
func TestGetEnabledExchanges(t *testing.T) {
cfg := GetConfig()
err := cfg.LoadConfig(TestFile, true)
if !errors.Is(err, errConfigDefineErrorExample) {
t.Errorf("received: '%v' but expected '%v'", err, errConfigDefineErrorExample)
}
exchanges := cfg.GetEnabledExchanges()
// modify the value of defaultEnabledExchanges at the top of the
// config_test.go file to match the total count of exchanges
if len(exchanges) != defaultEnabledExchanges {
t.Errorf("received: '%v' but expected '%v'", len(exchanges), defaultEnabledExchanges)
}
if !common.StringDataCompare(exchanges, "Bitfinex") {
t.Errorf("received: '%v' but expected '%v'",
common.StringDataCompare(exchanges, "Bitfinex"),
true)
}
}
```
#### Increment the number of supported exchanges in [the gctscript exchange wrapper test file](../gctscript/wrappers/gct/exchange/exchange_test.go):
```go
func TestExchange_Exchanges(t *testing.T) {
t.Parallel()
x := exchangeTest.Exchanges(false)
y := len(x)
expected := 28 // modify this value to match the total count of exchanges
if y != expected {
t.Fatalf("expected %v received %v", expected , y)
}
}
```
#### Setup and run the [documentation tool](../cmd/documentation):
- Create a new file named *exchangename*.tmpl