d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-07 07:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Withdraw additional functionality (validation/submission/tracking) (#409)

Browse Source 
* reworked request struct and exchange response started work on validation system

* removed import cycle until work around

* Added intial withdraw support via CLI added

* Added Crypto command to gctcli

* moved var declartion to single line

* Test updates for binance and anx

* All exchange tests have been updated test coverage added to validate

* First pass at adding withdrawl select from database

* started adding basic lru cache system

* Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear

* wording changes on comments

* removed exported var's in strut as they are not required

* Added README

* README updates

* corrected ID on commands

* rm line :D

* merged in origin/cache

* linter fixes (gofmt)

* Added basic cache lookup to events

* swapped to mutex over rwmutex updated comments

* unexported getNewest & getOldest

* unexported getNewest & getOldest

* Updated comments and cited references in source

* updated comments

* WIP

* Migrated exchange WithdrawFiat wrapper to new struct response

* Migrated exchange WithdrawFiat wrapper to new struct response

* started work on bank management

* Added exchange level banking details back with migration to banking package

* Removed broken tests for now

* Added validation to bank accounts

* removed duplicate bank details from withdraw struct

* Test coverage increased

* gofmt

* merged upstream/master with clean up

* First pass at adding command line linking to gctcli

* added validation for crypto address, added gctcli support to retreive previous withdrawal requests

* general cleanup

* general cleanup

* reordered imports

* Increased test coverage moved to database sublogger

* Pass incorrect currency no longer return error from c.CheckBankAccountConfig

* remove TestMain() for now as other tests in this package will need to be reworked

* Happy little race car

* Reverted to upstream tests

* Added test covarege for validation method, corrected response on cli protobuf

* query clean up and removal of duplicated code

* cleaned up queries into singlem ethod increased test coverage

* Migrated international fund withdraw to new exchange response and added cache size override

* Migrated international fund withdraw to new exchange response and added cache size override

* Extended gctcli commands

* lowered default cache to 25

* small code clean up

* added get by date method

* add returned error

* cli commands cleaing return error on nil results to fix out of bounds

* merged write & read helpers into one for test coverage and increased engine/withdraw test coverage

* gofmt

* Added test coverage for valid ID

* removed unused param

* converted to use timestamp package from protobuf

* gofmt

* use built in RFC3339 timestamp

* remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it

* also use ptype on byid

* code flow improvements

* remove inverse conditional check and linters run

* removed test data

* removed comment

* removed comment

* also write failures to database for auditing

* converted to use default time for start & end

* Default to time.Now() minus 30 days

* Default to time.Now() minus 30 days

* small code clean up

* fixed missing semicolon on migrations, code clean up

* updated sqlite migrations

* Added additonal check for exchange level bank account if global is not found

* case sensativity fix for currency names

* use correct compare

* test coverage fixed

* removed space

* return pointer to banking.Account

* return pointer to banking.Account

* added else check back to validate()

* Added empty string as default to migration over NULL due to retrivial of data
This commit is contained in:
Andrew
2020-02-26 15:45:13 +11:00
committed by GitHub
parent def3cdf226
commit b26ec86d43
122 changed files with 18066 additions and 2029 deletions
Download Patch File Download Diff File Expand all files Collapse all files

131
gctrpc/rpc.proto
View File

@@ -1,6 +1,7 @@
syntax = "proto3";
import "google/api/annotations.proto";
import "google/protobuf/timestamp.proto";
package gctrpc;
@@ -244,6 +245,8 @@ message AddPortfolioAddressRequest {
string coin_type = 2;
string description = 3;
double balance = 4;
string supported_exchanges = 5;
bool cold_storage = 6;
}
message AddPortfolioAddressResponse {}
@@ -434,28 +437,90 @@ message GetCryptocurrencyDepositAddressResponse {
string address = 1;
}
message WithdrawCurrencyRequest {
message WithdrawFiatRequest {
string exchange = 1;
string description = 2;
string one_time_password = 3;
string account_id = 4;
int64 pin = 5;
string trade_password = 6;
string currency = 7;
string address = 8;
string address_tag = 9;
double amount = 10;
double fee_amount = 11;
string bank_name = 12;
string bank_address = 13;
string bank_city = 14;
string bank_country = 15;
string swife_code = 16;
string wire_currency = 17;
string currency = 2;
double amount = 3;
string description = 4;
string bank_account_id = 5;
}
message WithdrawCryptoRequest {
string exchange = 1;
string address = 2;
string address_tag = 3;
string currency = 4;
double amount = 5;
double fee = 6;
string description = 7;
}
message WithdrawResponse {
string result = 1;
string id = 1;
string status = 2;
}
message WithdrawalEventByIDRequest {
string id = 1;
}
message WithdrawalEventByIDResponse {
WithdrawalEventResponse event = 2;
}
message WithdrawalEventsByExchangeRequest {
string exchange = 1;
string id = 2;
int32 limit = 3;
}
message WithdrawalEventsByDateRequest {
string exchange = 1;
string start = 2;
string end = 3;
int32 limit = 4;
}
message WithdrawalEventsByExchangeResponse {
repeated WithdrawalEventResponse event = 2;
}
message WithdrawalEventResponse {
string id = 2;
WithdrawlExchangeEvent exchange = 3;
WithdrawalRequestEvent request = 4;
google.protobuf.Timestamp created_at = 5;
google.protobuf.Timestamp updated_at = 6;
}
message WithdrawlExchangeEvent {
string name = 1;
string id = 2;
string status = 3;
}
message WithdrawalRequestEvent {
string currency = 2;
string description = 3;
double amount = 4;
int32 type = 5;
FiatWithdrawalEvent fiat = 6;
CryptoWithdrawalEvent crypto = 7;
}
message FiatWithdrawalEvent {
string bank_name = 1;
string account_name = 2;
string account_number = 3;
string bsb = 4;
string swift = 5;
string iban = 6;
}
message CryptoWithdrawalEvent {
string address = 1;
string address_tag = 2;
double fee = 3;
}
message GetLoggerDetailsRequest {
@@ -845,16 +910,38 @@ service GoCryptoTrader {
};
}
rpc WithdrawCryptocurrencyFunds(WithdrawCurrencyRequest) returns (WithdrawResponse) {
rpc WithdrawFiatFunds(WithdrawFiatRequest) returns (WithdrawResponse) {
option (google.api.http) = {
post: "/v1/withdrawcryptofunds"
post: "/v1/withdrawfiatfunds"
body: "*"
};
}
rpc WithdrawFiatFunds(WithdrawCurrencyRequest) returns (WithdrawResponse) {
rpc WithdrawCryptocurrencyFunds(WithdrawCryptoRequest) returns (WithdrawResponse) {
option (google.api.http) = {
post: "/v1/withdrawfiatfunds"
post: "/v1/withdrawithdrawcryptofundswfiatfunds"
body: "*"
};
}
rpc WithdrawalEventByID(WithdrawalEventByIDRequest) returns (WithdrawalEventByIDResponse) {
option (google.api.http) = {
post: "/v1/withdrawaleventbyid"
body: "*"
};
}
rpc WithdrawalEventsByExchange(WithdrawalEventsByExchangeRequest) returns (WithdrawalEventsByExchangeResponse) {
option (google.api.http) = {
post: "/v1/withdrawaleventbyid"
body: "*"
};rpcse
}
rpc WithdrawalEventsByDate(WithdrawalEventsByDateRequest) returns (WithdrawalEventsByExchangeResponse) {
option (google.api.http) = {
post: "/v1/withdrawaleventbydate"
body: "*"
};
}