Withdraw additional functionality (validation/submission/tracking) (#409)

* reworked request struct and exchange response started work on validation system

* removed import cycle until work around

* Added intial withdraw support via CLI added

* Added Crypto command to gctcli

* moved var declartion to single line

* Test updates for binance and anx

* All exchange tests have been updated test coverage added to validate

* First pass at adding withdrawl select from database

* started adding basic lru cache system

* Added basic LRU cache including Add Get Remove Contains ContainsOrAdd Clear

* wording changes on comments

* removed exported var's in strut as they are not required

* Added README

* README updates

* corrected ID on commands

* rm line :D

* merged in origin/cache

* linter fixes (gofmt)

* Added basic cache lookup to events

* swapped to mutex over rwmutex updated comments

* unexported getNewest & getOldest

* unexported getNewest & getOldest

* Updated comments and cited references in source

* updated comments

* WIP

* Migrated exchange WithdrawFiat wrapper to new struct response

* Migrated exchange WithdrawFiat wrapper to new struct response

* started work on bank management

* Added exchange level banking details back with migration to banking package

* Removed broken tests for now

* Added validation to bank accounts

* removed duplicate bank details from withdraw struct

* Test coverage increased

* gofmt

* merged upstream/master with clean up

* First pass at adding command line linking to gctcli

* added validation for crypto address, added gctcli support to retreive previous withdrawal requests

* general cleanup

* general cleanup

* reordered imports

* Increased test coverage moved to database sublogger

* Pass incorrect currency no longer return error from c.CheckBankAccountConfig

* remove TestMain() for now as other tests in this package will need to be reworked

* Happy little race car

* Reverted to upstream tests

* Added test covarege for validation method, corrected response on cli protobuf

* query clean up and removal of duplicated code

* cleaned up queries into singlem ethod increased test coverage

* Migrated international fund withdraw to new exchange response and added cache size override

* Migrated international fund withdraw to new exchange response and added cache size override

* Extended gctcli commands

* lowered default cache to 25

* small code clean up

* added get by date method

* add returned error

* cli commands cleaing return error on nil results to fix out of bounds

* merged write & read helpers into one for test coverage and increased engine/withdraw test coverage

* gofmt

* Added test coverage for valid ID

* removed unused param

* converted to use timestamp package from protobuf

* gofmt

* use built in RFC3339 timestamp

* remove setting of CreatedAt & UpdatedAt and allow ORm to take care of it

* also use ptype on byid

* code flow improvements

* remove inverse conditional check and linters run

* removed test data

* removed comment

* removed comment

* also write failures to database for auditing

* converted to use default time for start & end

* Default to time.Now() minus 30 days

* Default to time.Now() minus 30 days

* small code clean up

* fixed missing semicolon on migrations, code clean up

* updated sqlite migrations

* Added additonal check for exchange level bank account if global is not found

* case sensativity fix for currency names

* use correct compare

* test coverage fixed

* removed space

* return pointer to banking.Account

* return pointer to banking.Account

* added else check back to validate()

* Added empty string as default to migration over NULL due to retrivial of data

cmd/exchange_wrapper_issues/main.go

@@ -23,7 +23,8 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/exchanges/order"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/orderbook"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/ticker"
-	"github.com/thrasher-corp/gocryptotrader/exchanges/withdraw"
+	"github.com/thrasher-corp/gocryptotrader/portfolio/banking"
+	"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
 )
 
 func main() {
@@ -622,15 +623,14 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
 			Response:   jsonifyInterface([]interface{}{r19}),
 		})
 
-		genericWithdrawRequest := withdraw.GenericInfo{
-			Amount:   config.OrderSubmission.Amount,
+		withdrawRequest := withdraw.Request{
 			Currency: p.Quote,
+			Crypto: &withdraw.CryptoRequest{
+				Address: withdrawAddressOverride,
+			},
+			Amount: config.OrderSubmission.Amount,
 		}
-		withdrawRequest := withdraw.CryptoRequest{
-			GenericInfo: genericWithdrawRequest,
-			Address:     withdrawAddressOverride,
-		}
-		var r20 string
+		var r20 *withdraw.ExchangeResponse
 		r20, err = e.WithdrawCryptocurrencyFunds(&withdrawRequest)
 		msg = ""
 		if err != nil {
@@ -666,53 +666,59 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
 			Response:   jsonifyInterface([]interface{}{r21}),
 		})
 
-		fiatWithdrawRequest := withdraw.FiatRequest{
-			GenericInfo:                   genericWithdrawRequest,
-			BankAccountName:               config.BankDetails.BankAccountName,
-			BankAccountNumber:             config.BankDetails.BankAccountNumber,
-			SwiftCode:                     config.BankDetails.SwiftCode,
-			IBAN:                          config.BankDetails.Iban,
-			BankCity:                      config.BankDetails.BankCity,
-			BankName:                      config.BankDetails.BankName,
-			BankAddress:                   config.BankDetails.BankAddress,
-			BankCountry:                   config.BankDetails.BankCountry,
-			BankPostalCode:                config.BankDetails.BankPostalCode,
-			BankCode:                      config.BankDetails.BankCode,
-			IsExpressWire:                 config.BankDetails.IsExpressWire,
-			RequiresIntermediaryBank:      config.BankDetails.RequiresIntermediaryBank,
-			IntermediaryBankName:          config.BankDetails.IntermediaryBankName,
-			IntermediaryBankAccountNumber: config.BankDetails.IntermediaryBankAccountNumber,
-			IntermediarySwiftCode:         config.BankDetails.IntermediarySwiftCode,
-			IntermediaryIBAN:              config.BankDetails.IntermediaryIban,
-			IntermediaryBankCity:          config.BankDetails.IntermediaryBankCity,
-			IntermediaryBankAddress:       config.BankDetails.IntermediaryBankAddress,
-			IntermediaryBankCountry:       config.BankDetails.IntermediaryBankCountry,
-			IntermediaryBankPostalCode:    config.BankDetails.IntermediaryBankPostalCode,
-			IntermediaryBankCode:          config.BankDetails.IntermediaryBankCode,
+		withdrawRequestFiat := withdraw.Request{
+			Currency: p.Quote,
+			Amount:   config.OrderSubmission.Amount,
+			Fiat: &withdraw.FiatRequest{
+				Bank: &banking.Account{
+					AccountName:    config.BankDetails.BankAccountName,
+					AccountNumber:  config.BankDetails.BankAccountNumber,
+					SWIFTCode:      config.BankDetails.SwiftCode,
+					IBAN:           config.BankDetails.Iban,
+					BankPostalCity: config.BankDetails.BankCity,
+					BankName:       config.BankDetails.BankName,
+					BankAddress:    config.BankDetails.BankAddress,
+					BankCountry:    config.BankDetails.BankCountry,
+					BankPostalCode: config.BankDetails.BankPostalCode,
+					BankCode:       config.BankDetails.BankCode,
+				},
+
+				IsExpressWire:                 config.BankDetails.IsExpressWire,
+				RequiresIntermediaryBank:      config.BankDetails.RequiresIntermediaryBank,
+				IntermediaryBankName:          config.BankDetails.IntermediaryBankName,
+				IntermediaryBankAccountNumber: config.BankDetails.IntermediaryBankAccountNumber,
+				IntermediarySwiftCode:         config.BankDetails.IntermediarySwiftCode,
+				IntermediaryIBAN:              config.BankDetails.IntermediaryIban,
+				IntermediaryBankCity:          config.BankDetails.IntermediaryBankCity,
+				IntermediaryBankAddress:       config.BankDetails.IntermediaryBankAddress,
+				IntermediaryBankCountry:       config.BankDetails.IntermediaryBankCountry,
+				IntermediaryBankPostalCode:    config.BankDetails.IntermediaryBankPostalCode,
+				IntermediaryBankCode:          config.BankDetails.IntermediaryBankCode,
+			},
 		}
-		var r22 string
-		r22, err = e.WithdrawFiatFunds(&fiatWithdrawRequest)
+		var r22 *withdraw.ExchangeResponse
+		r22, err = e.WithdrawFiatFunds(&withdrawRequestFiat)
 		msg = ""
 		if err != nil {
 			msg = err.Error()
 			responseContainer.ErrorCount++
 		}
 		responseContainer.EndpointResponses = append(responseContainer.EndpointResponses, EndpointResponse{
-			SentParams: jsonifyInterface([]interface{}{fiatWithdrawRequest}),
+			SentParams: jsonifyInterface([]interface{}{withdrawRequestFiat}),
 			Function:   "WithdrawFiatFunds",
 			Error:      msg,
 			Response:   r22,
 		})
 
-		var r23 string
-		r23, err = e.WithdrawFiatFundsToInternationalBank(&fiatWithdrawRequest)
+		var r23 *withdraw.ExchangeResponse
+		r23, err = e.WithdrawFiatFundsToInternationalBank(&withdrawRequestFiat)
 		msg = ""
 		if err != nil {
 			msg = err.Error()
 			responseContainer.ErrorCount++
 		}
 		responseContainer.EndpointResponses = append(responseContainer.EndpointResponses, EndpointResponse{
-			SentParams: jsonifyInterface([]interface{}{fiatWithdrawRequest}),
+			SentParams: jsonifyInterface([]interface{}{withdrawRequestFiat}),
 			Function:   "WithdrawFiatFundsToInternationalBank",
 			Error:      msg,
 			Response:   r23,