sharedtestvalues: Add helper functions and implement throughout exchange tests (#1163)

* exchanges/sharedtestvalues: implement new functions to handle test skipping and announcements for standardising. * exchanges: fin test impl. * linter: fixes * exchange_template: fix test * allocate so it doesn't make a panic at the disco * glorious: nits * glorious: nits * Update exchanges/sharedtestvalues/sharedtestvalues.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchanges/sharedtestvalues/sharedtestvalues.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * glorious: nits * linter: fix * linter: shhhh --------- Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io> Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
2026-06-06 07:26:47 +00:00 · 2023-04-28 13:05:42 +10:00
parent 492ea20f21
commit b20cf75d13
63 changed files with 2115 additions and 3161 deletions
--- a/exchanges/binance/binance_test.go
+++ b/exchanges/binance/binance_test.go
@@ -17,6 +17,7 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/exchanges/asset"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/kline"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/order"
+	"github.com/thrasher-corp/gocryptotrader/exchanges/sharedtestvalues"
 	"github.com/thrasher-corp/gocryptotrader/portfolio/withdraw"
 )

@@ -28,17 +29,13 @@ const (
 )

 var (
-	b Binance
+	b = &Binance{}
 	// this lock guards against orderbook tests race
 	binanceOrderBookLock = &sync.Mutex{}
 	// this pair is used to ensure that endpoints match it correctly
 	testPairMapping = currency.NewPair(currency.DOGE, currency.USDT)
 )

-func areTestAPIKeysSet() bool {
-	return b.ValidateAPICredentials(b.GetDefaultCredentials()) == nil
-}
-
 func setFeeBuilder() *exchange.FeeBuilder {
 	return &exchange.FeeBuilder{
 		Amount:        1,
@@ -414,9 +411,7 @@ func TestUCompositeIndexInfo(t *testing.T) {

 func TestUFuturesNewOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UFuturesNewOrder(context.Background(),
 		&UFuturesNewOrderRequest{
 			Symbol:      currency.NewPair(currency.BTC, currency.USDT),
@@ -434,9 +429,7 @@ func TestUFuturesNewOrder(t *testing.T) {

 func TestUPlaceBatchOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	var data []PlaceBatchOrderData
 	var tempData PlaceBatchOrderData
 	tempData.Symbol = "BTCUSDT"
@@ -454,9 +447,7 @@ func TestUPlaceBatchOrders(t *testing.T) {

 func TestUGetOrderData(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UGetOrderData(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "123", "")
 	if err != nil {
 		t.Error(err)
@@ -465,9 +456,7 @@ func TestUGetOrderData(t *testing.T) {

 func TestUCancelOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UCancelOrder(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "123", "")
 	if err != nil {
 		t.Error(err)
@@ -476,9 +465,7 @@ func TestUCancelOrder(t *testing.T) {

 func TestUCancelAllOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UCancelAllOpenOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT))
 	if err != nil {
 		t.Error(err)
@@ -487,9 +474,7 @@ func TestUCancelAllOpenOrders(t *testing.T) {

 func TestUCancelBatchOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UCancelBatchOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT), []string{"123"}, []string{})
 	if err != nil {
 		t.Error(err)
@@ -498,9 +483,7 @@ func TestUCancelBatchOrders(t *testing.T) {

 func TestUAutoCancelAllOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UAutoCancelAllOpenOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT), 30)
 	if err != nil {
 		t.Error(err)
@@ -509,9 +492,7 @@ func TestUAutoCancelAllOpenOrders(t *testing.T) {

 func TestUFetchOpenOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UFetchOpenOrder(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "123", "")
 	if err != nil {
 		t.Error(err)
@@ -520,9 +501,7 @@ func TestUFetchOpenOrder(t *testing.T) {

 func TestUAllAccountOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAllAccountOpenOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT))
 	if err != nil {
 		t.Error(err)
@@ -531,9 +510,7 @@ func TestUAllAccountOpenOrders(t *testing.T) {

 func TestUAllAccountOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAllAccountOrders(context.Background(), currency.EMPTYPAIR, 0, 0, time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -546,9 +523,7 @@ func TestUAllAccountOrders(t *testing.T) {

 func TestUAccountBalanceV2(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAccountBalanceV2(context.Background())
 	if err != nil {
 		t.Error(err)
@@ -557,9 +532,7 @@ func TestUAccountBalanceV2(t *testing.T) {

 func TestUAccountInformationV2(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAccountInformationV2(context.Background())
 	if err != nil {
 		t.Error(err)
@@ -568,9 +541,7 @@ func TestUAccountInformationV2(t *testing.T) {

 func TestUChangeInitialLeverageRequest(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UChangeInitialLeverageRequest(context.Background(), currency.NewPair(currency.BTC, currency.USDT), 2)
 	if err != nil {
 		t.Error(err)
@@ -579,9 +550,7 @@ func TestUChangeInitialLeverageRequest(t *testing.T) {

 func TestUChangeInitialMarginType(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	err := b.UChangeInitialMarginType(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "ISOLATED")
 	if err != nil {
 		t.Error(err)
@@ -590,9 +559,7 @@ func TestUChangeInitialMarginType(t *testing.T) {

 func TestUModifyIsolatedPositionMarginReq(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UModifyIsolatedPositionMarginReq(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "LONG", "add", 5)
 	if err != nil {
 		t.Error(err)
@@ -601,9 +568,7 @@ func TestUModifyIsolatedPositionMarginReq(t *testing.T) {

 func TestUPositionMarginChangeHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.UPositionMarginChangeHistory(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "add", 5, time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -612,9 +577,7 @@ func TestUPositionMarginChangeHistory(t *testing.T) {

 func TestUPositionsInfoV2(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UPositionsInfoV2(context.Background(), currency.NewPair(currency.BTC, currency.USDT))
 	if err != nil {
 		t.Error(err)
@@ -623,9 +586,7 @@ func TestUPositionsInfoV2(t *testing.T) {

 func TestUAccountTradesHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAccountTradesHistory(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "", 5, time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -634,9 +595,7 @@ func TestUAccountTradesHistory(t *testing.T) {

 func TestUAccountIncomeHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAccountIncomeHistory(context.Background(), currency.EMPTYPAIR, "", 5, time.Now().Add(-time.Hour*48), time.Now())
 	if err != nil {
 		t.Error(err)
@@ -645,9 +604,7 @@ func TestUAccountIncomeHistory(t *testing.T) {

 func TestUGetNotionalAndLeverageBrackets(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UGetNotionalAndLeverageBrackets(context.Background(), currency.NewPair(currency.BTC, currency.USDT))
 	if err != nil {
 		t.Error(err)
@@ -656,9 +613,7 @@ func TestUGetNotionalAndLeverageBrackets(t *testing.T) {

 func TestUPositionsADLEstimate(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UPositionsADLEstimate(context.Background(), currency.NewPair(currency.BTC, currency.USDT))
 	if err != nil {
 		t.Error(err)
@@ -667,9 +622,7 @@ func TestUPositionsADLEstimate(t *testing.T) {

 func TestUAccountForcedOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.UAccountForcedOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "ADL", 5, time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -821,9 +774,7 @@ func TestGetFuturesSwapTickerChangeStats(t *testing.T) {

 func TestFuturesGetFundingHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesGetFundingHistory(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), 5, time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -837,9 +788,7 @@ func TestFuturesGetFundingHistory(t *testing.T) {

 func TestGetFuturesHistoricalTrades(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetFuturesHistoricalTrades(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "", 5)
 	if err != nil {
 		t.Error(err)
@@ -958,9 +907,7 @@ func TestFuturesBasisData(t *testing.T) {

 func TestFuturesNewOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.FuturesNewOrder(
 		context.Background(),
 		&FuturesNewOrderRequest{
@@ -979,9 +926,7 @@ func TestFuturesNewOrder(t *testing.T) {

 func TestFuturesBatchOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	var data []PlaceBatchOrderData
 	var tempData PlaceBatchOrderData
 	tempData.Symbol = "BTCUSD_PERP"
@@ -1000,9 +945,7 @@ func TestFuturesBatchOrder(t *testing.T) {

 func TestFuturesBatchCancelOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.FuturesBatchCancelOrders(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), []string{"123"}, []string{})
 	if err != nil {
 		t.Error(err)
@@ -1011,9 +954,7 @@ func TestFuturesBatchCancelOrders(t *testing.T) {

 func TestFuturesGetOrderData(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesGetOrderData(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "123", "")
 	if err != nil {
 		t.Error(err)
@@ -1022,9 +963,7 @@ func TestFuturesGetOrderData(t *testing.T) {

 func TestCancelAllOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.FuturesCancelAllOpenOrders(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"))
 	if err != nil {
 		t.Error(err)
@@ -1033,9 +972,7 @@ func TestCancelAllOpenOrders(t *testing.T) {

 func TestAutoCancelAllOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.AutoCancelAllOpenOrders(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), 30000)
 	if err != nil {
 		t.Error(err)
@@ -1044,9 +981,7 @@ func TestAutoCancelAllOpenOrders(t *testing.T) {

 func TestFuturesOpenOrderData(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesOpenOrderData(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "", "")
 	if err != nil {
 		t.Error(err)
@@ -1055,9 +990,7 @@ func TestFuturesOpenOrderData(t *testing.T) {

 func TestGetFuturesAllOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetFuturesAllOpenOrders(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "")
 	if err != nil {
 		t.Error(err)
@@ -1066,9 +999,7 @@ func TestGetFuturesAllOpenOrders(t *testing.T) {

 func TestGetAllFuturesOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetAllFuturesOrders(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "", time.Time{}, time.Time{}, 0, 2)
 	if err != nil {
 		t.Error(err)
@@ -1077,9 +1008,7 @@ func TestGetAllFuturesOrders(t *testing.T) {

 func TestFuturesChangeMarginType(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.FuturesChangeMarginType(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "ISOLATED")
 	if err != nil {
 		t.Error(err)
@@ -1088,9 +1017,7 @@ func TestFuturesChangeMarginType(t *testing.T) {

 func TestGetFuturesAccountBalance(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetFuturesAccountBalance(context.Background())
 	if err != nil {
 		t.Error(err)
@@ -1099,9 +1026,7 @@ func TestGetFuturesAccountBalance(t *testing.T) {

 func TestGetFuturesAccountInfo(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.GetFuturesAccountInfo(context.Background())
 	if err != nil {
 		t.Error(err)
@@ -1110,9 +1035,7 @@ func TestGetFuturesAccountInfo(t *testing.T) {

 func TestFuturesChangeInitialLeverage(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.FuturesChangeInitialLeverage(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), 5)
 	if err != nil {
 		t.Error(err)
@@ -1121,9 +1044,7 @@ func TestFuturesChangeInitialLeverage(t *testing.T) {

 func TestModifyIsolatedPositionMargin(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	_, err := b.ModifyIsolatedPositionMargin(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "BOTH", "add", 5)
 	if err != nil {
 		t.Error(err)
@@ -1132,9 +1053,7 @@ func TestModifyIsolatedPositionMargin(t *testing.T) {

 func TestFuturesMarginChangeHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesMarginChangeHistory(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "add", time.Time{}, time.Time{}, 10)
 	if err != nil {
 		t.Error(err)
@@ -1143,9 +1062,7 @@ func TestFuturesMarginChangeHistory(t *testing.T) {

 func TestFuturesPositionsInfo(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesPositionsInfo(context.Background(), "BTCUSD_PERP", "")
 	if err != nil {
 		t.Error(err)
@@ -1154,9 +1071,7 @@ func TestFuturesPositionsInfo(t *testing.T) {

 func TestFuturesTradeHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesTradeHistory(context.Background(), currency.NewPairWithDelimiter("BTCUSD", "PERP", "_"), "", time.Time{}, time.Time{}, 5, 0)
 	if err != nil {
 		t.Error(err)
@@ -1165,9 +1080,7 @@ func TestFuturesTradeHistory(t *testing.T) {

 func TestFuturesIncomeHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesIncomeHistory(context.Background(), currency.EMPTYPAIR, "TRANSFER", time.Time{}, time.Time{}, 5)
 	if err != nil {
 		t.Error(err)
@@ -1176,9 +1089,7 @@ func TestFuturesIncomeHistory(t *testing.T) {

 func TestFuturesForceOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesForceOrders(context.Background(), currency.EMPTYPAIR, "ADL", time.Time{}, time.Time{})
 	if err != nil {
 		t.Error(err)
@@ -1187,9 +1098,7 @@ func TestFuturesForceOrders(t *testing.T) {

 func TestUGetNotionalLeverage(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesNotionalBracket(context.Background(), "BTCUSD")
 	if err != nil {
 		t.Error(err)
@@ -1202,9 +1111,7 @@ func TestUGetNotionalLeverage(t *testing.T) {

 func TestFuturesPositionsADLEstimate(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.FuturesPositionsADLEstimate(context.Background(), currency.EMPTYPAIR)
 	if err != nil {
 		t.Error(err)
@@ -1365,9 +1272,9 @@ func TestQueryOrder(t *testing.T) {

 	_, err := b.QueryOrder(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "", 1337)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("QueryOrder() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("QueryOrder() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock QueryOrder() error", err)
@@ -1376,9 +1283,7 @@ func TestQueryOrder(t *testing.T) {

 func TestOpenOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip()
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	_, err := b.OpenOrders(context.Background(), currency.EMPTYPAIR)
 	if err != nil {
 		t.Error(err)
@@ -1396,9 +1301,9 @@ func TestAllOrders(t *testing.T) {

 	_, err := b.AllOrders(context.Background(), currency.NewPair(currency.BTC, currency.USDT), "", "")
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("AllOrders() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("AllOrders() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock AllOrders() error", err)
@@ -1414,7 +1319,7 @@ func TestGetFeeByTypeOfflineTradeFee(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if !areTestAPIKeysSet() || mockTests {
+	if !sharedtestvalues.AreAPICredentialsSet(b) || mockTests {
 		if feeBuilder.FeeType != exchange.OfflineTradeFee {
 			t.Errorf("Expected %v, received %v", exchange.OfflineTradeFee, feeBuilder.FeeType)
 		}
@@ -1430,7 +1335,7 @@ func TestGetFee(t *testing.T) {

 	var feeBuilder = setFeeBuilder()

-	if areTestAPIKeysSet() && mockTests {
+	if sharedtestvalues.AreAPICredentialsSet(b) && mockTests {
 		// CryptocurrencyTradeFee Basic
 		if _, err := b.GetFee(context.Background(), feeBuilder); err != nil {
 			t.Error(err)
@@ -1515,9 +1420,9 @@ func TestGetActiveOrders(t *testing.T) {

 	_, err = b.GetActiveOrders(context.Background(), &getOrdersRequest)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("GetActiveOrders() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("GetActiveOrders() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock GetActiveOrders() error", err)
@@ -1544,9 +1449,9 @@ func TestGetOrderHistory(t *testing.T) {

 	_, err = b.GetOrderHistory(context.Background(), &getOrdersRequest)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("GetOrderHistory() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("GetOrderHistory() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock GetOrderHistory() error", err)
@@ -1567,9 +1472,9 @@ func TestNewOrderTest(t *testing.T) {

 	err := b.NewOrderTest(context.Background(), req)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("NewOrderTest() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("NewOrderTest() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock NewOrderTest() error", err)
@@ -1585,9 +1490,9 @@ func TestNewOrderTest(t *testing.T) {

 	err = b.NewOrderTest(context.Background(), req)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("NewOrderTest() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("NewOrderTest() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock NewOrderTest() error", err)
@@ -1770,8 +1675,8 @@ func TestGetAggregatedTradesErrors(t *testing.T) {
 func TestSubmitOrder(t *testing.T) {
 	t.Parallel()

-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}

 	var orderSubmission = &order.Submit{
@@ -1791,9 +1696,9 @@ func TestSubmitOrder(t *testing.T) {

 	_, err := b.SubmitOrder(context.Background(), orderSubmission)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("SubmitOrder() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("SubmitOrder() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock SubmitOrder() error", err)
@@ -1803,8 +1708,8 @@ func TestSubmitOrder(t *testing.T) {
 func TestCancelExchangeOrder(t *testing.T) {
 	t.Parallel()

-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}
 	var orderCancellation = &order.Cancel{
 		OrderID:       "1",
@@ -1816,9 +1721,9 @@ func TestCancelExchangeOrder(t *testing.T) {

 	err := b.CancelOrder(context.Background(), orderCancellation)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("CancelExchangeOrder() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("CancelExchangeOrder() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock CancelExchangeOrder() error", err)
@@ -1828,8 +1733,8 @@ func TestCancelExchangeOrder(t *testing.T) {
 func TestCancelAllExchangeOrders(t *testing.T) {
 	t.Parallel()

-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}
 	var orderCancellation = &order.Cancel{
 		OrderID:       "1",
@@ -1841,9 +1746,9 @@ func TestCancelAllExchangeOrders(t *testing.T) {

 	_, err := b.CancelAllOrders(context.Background(), orderCancellation)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("CancelAllExchangeOrders() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("CancelAllExchangeOrders() expecting an error when no keys are set")
 	case mockTests && err != nil:
 		t.Error("Mock CancelAllExchangeOrders() error", err)
@@ -1851,10 +1756,8 @@ func TestCancelAllExchangeOrders(t *testing.T) {
 }

 func TestGetAccountInfo(t *testing.T) {
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
 	t.Parallel()
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	items := asset.Items{
 		asset.CoinMarginedFutures,
 		asset.USDTMarginedFutures,
@@ -1864,6 +1767,7 @@ func TestGetAccountInfo(t *testing.T) {
 	for i := range items {
 		assetType := items[i]
 		t.Run(fmt.Sprintf("Update info of account [%s]", assetType.String()), func(t *testing.T) {
+			t.Parallel()
 			_, err := b.UpdateAccountInfo(context.Background(), assetType)
 			if err != nil {
 				t.Error(err)
@@ -1874,9 +1778,7 @@ func TestGetAccountInfo(t *testing.T) {

 func TestWrapperGetActiveOrders(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	p, err := currency.NewPairFromString("EOS-USDT")
 	if err != nil {
 		t.Error(err)
@@ -1908,9 +1810,7 @@ func TestWrapperGetActiveOrders(t *testing.T) {

 func TestWrapperGetOrderHistory(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	p, err := currency.NewPairFromString("EOSUSD_PERP")
 	if err != nil {
 		t.Error(err)
@@ -1951,9 +1851,7 @@ func TestWrapperGetOrderHistory(t *testing.T) {

 func TestCancelOrder(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() || !canManipulateRealOrders {
-		t.Skip("skipping test: api keys not set or canManipulateRealOrders set to false")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b, canManipulateRealOrders)
 	p, err := currency.NewPairFromString("EOS-USDT")
 	if err != nil {
 		t.Error(err)
@@ -1991,9 +1889,7 @@ func TestCancelOrder(t *testing.T) {

 func TestGetOrderInfo(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	tradablePairs, err := b.FetchTradablePairs(context.Background(),
 		asset.CoinMarginedFutures)
 	if err != nil {
@@ -2020,8 +1916,8 @@ func TestModifyOrder(t *testing.T) {

 func TestGetAllCoinsInfo(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() && !mockTests {
-		t.Skip("API keys not set")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	}
 	_, err := b.GetAllCoinsInfo(context.Background())
 	if err != nil {
@@ -2031,8 +1927,8 @@ func TestGetAllCoinsInfo(t *testing.T) {

 func TestWithdraw(t *testing.T) {
 	t.Parallel()
-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}

 	withdrawCryptoRequest := withdraw.Request{
@@ -2048,37 +1944,37 @@ func TestWithdraw(t *testing.T) {
 	_, err := b.WithdrawCryptocurrencyFunds(context.Background(),
 		&withdrawCryptoRequest)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("Withdraw() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("Withdraw() expecting an error when no keys are set")
 	}
 }

 func TestDepositHistory(t *testing.T) {
 	t.Parallel()
-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}
 	_, err := b.DepositHistory(context.Background(), currency.ETH, "", time.Time{}, time.Time{}, 0, 10000)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error(err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("expecting an error when no keys are set")
 	}
 }

 func TestWithdrawHistory(t *testing.T) {
 	t.Parallel()
-	if areTestAPIKeysSet() && !canManipulateRealOrders && !mockTests {
-		t.Skip("API keys set, canManipulateRealOrders false, skipping test")
+	if !mockTests {
+		sharedtestvalues.SkipTestIfCannotManipulateOrders(t, b, canManipulateRealOrders)
 	}
 	_, err := b.GetWithdrawalsHistory(context.Background(), currency.ETH, asset.Spot)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("GetWithdrawalsHistory() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("GetWithdrawalsHistory() expecting an error when no keys are set")
 	}
 }
@@ -2105,9 +2001,9 @@ func TestGetDepositAddress(t *testing.T) {
 	t.Parallel()
 	_, err := b.GetDepositAddress(context.Background(), currency.USDT, "", currency.BNB.String())
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error("GetDepositAddress() error", err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("GetDepositAddress() error cannot be nil")
 	case mockTests && err != nil:
 		t.Error("Mock GetDepositAddress() error", err)
@@ -2370,13 +2266,13 @@ func TestGetWsAuthStreamKey(t *testing.T) {
 	key, err := b.GetWsAuthStreamKey(context.Background())
 	switch {
 	case mockTests && err != nil,
-		!mockTests && areTestAPIKeysSet() && err != nil:
+		!mockTests && sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Fatal(err)
-	case !mockTests && !areTestAPIKeysSet() && err == nil:
+	case !mockTests && !sharedtestvalues.AreAPICredentialsSet(b) && err == nil:
 		t.Fatal("Expected error")
 	}

-	if key == "" && (areTestAPIKeysSet() || mockTests) {
+	if key == "" && (sharedtestvalues.AreAPICredentialsSet(b) || mockTests) {
 		t.Error("Expected key")
 	}
 }
@@ -2385,9 +2281,9 @@ func TestMaintainWsAuthStreamKey(t *testing.T) {
 	err := b.MaintainWsAuthStreamKey(context.Background())
 	switch {
 	case mockTests && err != nil,
-		!mockTests && areTestAPIKeysSet() && err != nil:
+		!mockTests && sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Fatal(err)
-	case !mockTests && !areTestAPIKeysSet() && err == nil:
+	case !mockTests && !sharedtestvalues.AreAPICredentialsSet(b) && err == nil:
 		t.Fatal("Expected error")
 	}
 }
@@ -2509,9 +2405,9 @@ func TestGetAvailableTransferChains(t *testing.T) {
 	t.Parallel()
 	_, err := b.GetAvailableTransferChains(context.Background(), currency.BTC)
 	switch {
-	case areTestAPIKeysSet() && err != nil:
+	case sharedtestvalues.AreAPICredentialsSet(b) && err != nil:
 		t.Error(err)
-	case !areTestAPIKeysSet() && err == nil && !mockTests:
+	case !sharedtestvalues.AreAPICredentialsSet(b) && err == nil && !mockTests:
 		t.Error("error cannot be nil")
 	case mockTests && err != nil:
 		t.Error(err)
@@ -2571,9 +2467,7 @@ func TestProcessUpdate(t *testing.T) {

 func TestUFuturesHistoricalTrades(t *testing.T) {
 	t.Parallel()
-	if !areTestAPIKeysSet() {
-		t.Skip("skipping test: api keys not set")
-	}
+	sharedtestvalues.SkipTestIfCredentialsUnset(t, b)
 	cp, err := currency.NewPairFromString("BTCUSDT")
 	if err != nil {
 		t.Error(err)
--- a/exchanges/binance/binance_wrapper.go
+++ b/exchanges/binance/binance_wrapper.go
@@ -1661,9 +1661,9 @@ func (b *Binance) GetOrderHistory(ctx context.Context, req *order.GetOrdersReque
 	return req.Filter(b.Name, orders), nil
 }

-// ValidateCredentials validates current credentials used for wrapper
+// ValidateAPICredentials validates current credentials used for wrapper
 // functionality
-func (b *Binance) ValidateCredentials(ctx context.Context, assetType asset.Item) error {
+func (b *Binance) ValidateAPICredentials(ctx context.Context, assetType asset.Item) error {
 	_, err := b.UpdateAccountInfo(ctx, assetType)
 	return b.CheckTransientError(err)
 }