From b109c18e5e82a556af3160e5a149376ce98750b7 Mon Sep 17 00:00:00 2001 From: Adrian Gallagher Date: Fri, 2 Feb 2018 09:28:33 +1100 Subject: [PATCH] Fix Binance/Bithumb ticker/orderbook --- exchanges/binance/binance.go | 6 ------ exchanges/binance/binance_wrapper.go | 6 ++---- exchanges/bithumb/bithumb.go | 1 + 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/exchanges/binance/binance.go b/exchanges/binance/binance.go index 62830579..db83e1db 100644 --- a/exchanges/binance/binance.go +++ b/exchanges/binance/binance.go @@ -437,12 +437,6 @@ func (b *Binance) SendAuthHTTPRequest(method, path string, params url.Values, re hmacSignedStr := common.HexEncodeToString(hmacSigned) params.Set("signature", hmacSignedStr) - if b.Nonce.Get() == 0 { - b.Nonce.Set(time.Now().UnixNano() / int64(time.Millisecond)) - } else { - b.Nonce.Inc() - } - headers := make(map[string]string) headers["X-MBX-APIKEY"] = b.APIKey headers["Content-Type"] = "application/x-www-form-urlencoded" diff --git a/exchanges/binance/binance_wrapper.go b/exchanges/binance/binance_wrapper.go index fce25f1b..ffab4dbd 100644 --- a/exchanges/binance/binance_wrapper.go +++ b/exchanges/binance/binance_wrapper.go @@ -40,7 +40,7 @@ func (b *Binance) UpdateTicker(p pair.CurrencyPair, assetType string) (ticker.Pr tickerPrice.High = tick.HighPrice tickerPrice.Last = tick.LastPrice tickerPrice.Low = tick.LowPrice - tickerPrice.Volume = tick.LastQty + tickerPrice.Volume = tick.Volume ticker.ProcessTicker(b.GetName(), p, tickerPrice, assetType) @@ -68,9 +68,7 @@ func (b *Binance) GetOrderbookEx(currency pair.CurrencyPair, assetType string) ( // UpdateOrderbook updates and returns the orderbook for a currency pair func (b *Binance) UpdateOrderbook(p pair.CurrencyPair, assetType string) (orderbook.Base, error) { var orderBook orderbook.Base - currency := p.GetFirstCurrency().String() - - orderbookNew, err := b.GetOrderBook(currency, 1000) + orderbookNew, err := b.GetOrderBook(p.Pair().String(), 1000) if err != nil { return orderBook, err } diff --git a/exchanges/bithumb/bithumb.go b/exchanges/bithumb/bithumb.go index 0ec5b945..f4bc8c54 100644 --- a/exchanges/bithumb/bithumb.go +++ b/exchanges/bithumb/bithumb.go @@ -62,6 +62,7 @@ func (b *Bithumb) SetDefaults() { b.RequestCurrencyPairFormat.Uppercase = true b.ConfigCurrencyPairFormat.Delimiter = "" b.ConfigCurrencyPairFormat.Uppercase = true + b.ConfigCurrencyPairFormat.Index = "KRW" b.AssetTypes = []string{ticker.Spot} }