log: fix bug, expand test coverage and slightly optimize (#847)

* log: fix bugs expand coverage and optimise

* log: fix linter issues

* log: fix linter issue and pack methods in same file

* log: drop defer

* logger: move global check inside getfields  and remove unused test function

* logger: Increase note thanks @gloriouscode

* logger: wrap error with writer type

* logger: change variable name

* logger: change variable names and remove validsublogger func as it doesn't add functionality over a standard map call

* logs: error when unsupported output is applied on setup calls

* logs: add glorious suggestion

* logger: add protection to reduce olympic gold medal races

* logger: fix linter issues

* log: glorious niterinos
This commit is contained in:
Ryan O'Hara-Reid
2021-11-30 16:43:27 +11:00
committed by GitHub
parent f266bd14f5
commit ac692b04f4
27 changed files with 767 additions and 329 deletions

View File

@@ -30,7 +30,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error

View File

@@ -33,7 +33,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error
testhelpers.PostgresTestDatabase = testhelpers.GetConnectionDetails()

View File

@@ -30,7 +30,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error
testhelpers.PostgresTestDatabase = testhelpers.GetConnectionDetails()

View File

@@ -30,7 +30,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error

View File

@@ -28,7 +28,11 @@ func TestMain(m *testing.M) {
}
if verbose {
testhelpers.EnableVerboseTestOutput()
err = testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
t := m.Run()

View File

@@ -33,7 +33,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error
testhelpers.PostgresTestDatabase = testhelpers.GetConnectionDetails()

View File

@@ -29,7 +29,11 @@ var (
func TestMain(m *testing.M) {
if verbose {
testhelpers.EnableVerboseTestOutput()
err := testhelpers.EnableVerboseTestOutput()
if err != nil {
fmt.Printf("failed to enable verbose test output: %v", err)
os.Exit(1)
}
}
var err error

View File

@@ -118,14 +118,15 @@ func migrateDB(db *sql.DB) error {
}
// EnableVerboseTestOutput enables debug output for SQL queries
func EnableVerboseTestOutput() {
c := log.GenDefaultSettings()
func EnableVerboseTestOutput() error {
log.RWM.Lock()
log.GlobalLogConfig = &c
log.GlobalLogConfig = log.GenDefaultSettings()
log.RWM.Unlock()
log.SetupGlobalLogger()
if err := log.SetupGlobalLogger(); err != nil {
return err
}
DBLogger := database.Logger{}
boil.DebugMode = true
boil.DebugWriter = DBLogger
return nil
}