orders: Add derive modify struct method from order.Detail (#948)

* orders: Add derive modify struct method to order.Detail and then subsequent method to derive and standardize response details

* exchanges: call modify method in wrappers

* linter: fixes

* engine/wsroutineman: remove print summary

* glorious: nits, removed modifyOrder functionality for Bithumb. There are not docs to support this.

* Update exchanges/order/orders.go

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>

* glorious: nits

Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
This commit is contained in:
Ryan O'Hara-Reid
2022-05-30 14:38:21 +10:00
committed by GitHub
parent 293d6104ed
commit a63aa6b616
42 changed files with 298 additions and 427 deletions

View File

@@ -83,10 +83,13 @@ func (f omfExchange) GetActiveOrders(ctx context.Context, req *order.GetOrdersRe
}}, nil
}
func (f omfExchange) ModifyOrder(ctx context.Context, action *order.Modify) (*order.Modify, error) {
ans := *action
ans.ID = "modified_order_id"
return &ans, nil
func (f omfExchange) ModifyOrder(ctx context.Context, action *order.Modify) (*order.ModifyResponse, error) {
ans, err := action.DeriveModifyResponse()
if err != nil {
return nil, err
}
ans.OrderID = "modified_order_id"
return ans, nil
}
func TestSetupOrderManager(t *testing.T) {
@@ -317,12 +320,12 @@ func TestStore_modifyOrder(t *testing.T) {
t.Error(err)
}
err = m.orderStore.modifyExisting("fake_order_id", &order.Modify{
err = m.orderStore.modifyExisting("fake_order_id", &order.ModifyResponse{
Exchange: testExchange,
ID: "another_fake_order_id",
Price: 16,
Amount: 256,
OrderID: "another_fake_order_id",
Price: 16,
Amount: 256,
})
if err != nil {
t.Error(err)